Organization Settings: replace old Settings app #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
changed the title
14 tasks
…dant information from usePerssionsByRole()
…permissions can render children
bpierre
approved these changes
Aug 21, 2019
| ? `Please select the ${sanitizeNetworkType( | ||
| network.type | ||
| )} network in your Ethereum provider.` | ||
| : `Please unlock your account in your Ethereum provider.`} |
There was a problem hiding this comment.
Time to use getProviderString(), this is our only case 😆
| > | ||
| <LocalIdentityBadge | ||
| entity={checksummedDaoAddr} | ||
| shorten={shortAddresses} |
There was a problem hiding this comment.
Should we keep the badges shortened all the time, now that they always open to the full address?
There was a problem hiding this comment.
I do like expanding them when there's room, it makes the screen look a little bit more interesting 😄.
…istency with other usages
Co-Authored-By: Pierre Bertet <hello@pierre.world>
Co-Authored-By: Pierre Bertet <hello@pierre.world>
Co-Authored-By: Pierre Bertet <hello@pierre.world>
2color
added a commit
that referenced
this pull request
Aug 28, 2019
…tions * origin/newstyle: MenuPanel tweaks (#933) Home redesign (#934) SignerPanel: consolidate external transaction props into intent object (#931) useLocalIdentity: handle remove case (#930) Add AppInternal to manage the layout logic of internal apps (#932) MenuPanel: adjust for new styles (#923) SignerPanel: display warning for external transactions (#850) Remove Badge and update occurrences for Tag (#901) SignerPanel: adjust for new styles (#920) Organization Settings: replace old Settings app (#896) Permissions: new style (#899) Sidepanel: redesign feedback indicator (#907) eslint: make sure curly braces are used everywhere (#924) Org switcher: new style + add FavoritesMenu (#925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Settings to be Organization Settings for 0.8:
Requires https://github.com/aragon/aragon-ui/pull/508.
TODO: