Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org switcher: add a generic FavoritesMenu component #925

Merged
merged 8 commits into from
Aug 21, 2019

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Aug 21, 2019

Also use new aragonUI features: useTheme(), textStyles, GU, IconStar, IconStarFilled.

Also use new aragonUI features: useTheme(), textStyles, GU, IconStar,
IconStarFilled.
@bpierre bpierre requested a review from sohkai August 21, 2019 08:06
@auto-assign auto-assign bot requested a review from AquiGorka August 21, 2019 08:06
@vercel vercel bot temporarily deployed to staging August 21, 2019 08:09 Inactive
@sohkai sohkai mentioned this pull request Aug 21, 2019
2 tasks
@vercel vercel bot temporarily deployed to staging August 21, 2019 11:12 Inactive
@sohkai
Copy link
Contributor

sohkai commented Aug 21, 2019

@bpierre Pushed a few commits to move the organization switcher changes in #923 to here.

I've touched the components in FavoriteMenu slightly, but I think these will be needed anyway (based on the designs):

  • c7eac1a: always apply the border, as the org switcher also has these separators now
  • a100dc0: applying the height here makes it slightly easier to use the button in the org switcher, but not a big deal
  • 9f7fb60: adjusts the style to reduce padding between the icon and text, and bumps the text to 16px (the designs for onboarding also seems to use this font size)

And finally, 3834386 reverts the linting change; I think there may have been a new version of prettier :).

@bpierre bpierre merged commit 9abb859 into newstyle Aug 21, 2019
@bpierre bpierre deleted the newstyle-favorites-menu branch August 21, 2019 11:20
2color added a commit that referenced this pull request Aug 28, 2019
…tions

* origin/newstyle:
  MenuPanel tweaks (#933)
  Home redesign (#934)
  SignerPanel: consolidate external transaction props into intent object (#931)
  useLocalIdentity: handle remove case (#930)
  Add AppInternal to manage the layout logic of internal apps (#932)
  MenuPanel: adjust for new styles (#923)
  SignerPanel: display warning for external transactions (#850)
  Remove Badge and update occurrences for Tag (#901)
  SignerPanel: adjust for new styles (#920)
  Organization Settings: replace old Settings app (#896)
  Permissions: new style (#899)
  Sidepanel: redesign feedback indicator (#907)
  eslint: make sure curly braces are used everywhere (#924)
  Org switcher: new style + add FavoritesMenu (#925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants