MenuPanel: adjust for new styles #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
commented
Aug 20, 2019
sohkai
force-pushed
the
newstyle-menupanel
branch
from
d538082 to
59c52c2
Compare
bpierre
reviewed
Aug 21, 2019
… to global handler
sohkai
force-pushed
the
newstyle-menupanel
branch
from
59c52c2 to
d80f643
Compare
|
@sohkai @dizzypaty Merging this so we can start building on it, we can open another PR if we decide to tweak the org switcher look. |
2color
added a commit
that referenced
this pull request
Aug 28, 2019
…tions * origin/newstyle: MenuPanel tweaks (#933) Home redesign (#934) SignerPanel: consolidate external transaction props into intent object (#931) useLocalIdentity: handle remove case (#930) Add AppInternal to manage the layout logic of internal apps (#932) MenuPanel: adjust for new styles (#923) SignerPanel: display warning for external transactions (#850) Remove Badge and update occurrences for Tag (#901) SignerPanel: adjust for new styles (#920) Organization Settings: replace old Settings app (#896) Permissions: new style (#899) Sidepanel: redesign feedback indicator (#907) eslint: make sure curly braces are used everywhere (#924) Org switcher: new style + add FavoritesMenu (#925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the menu panel and organization switcher to the refreshed designs:
Also simplifies the aragon.js error handling a bit, to push everything to the global error handler for now. We used to have reload states for the apps in case they weren't able to load (e.g. because of a bad IPFS connection) but these errors are not propagated the same way from aragon.js anymore and we should later revisit how to properly handle these cases (#84, #361).
Smaller layouts:
With app instances:
Organization switcher:
@dizzypaty We should discuss this in a bit more detail; I think it looks a bit odd as it is, but was the best compromise I could think of to keep the current org in the popover (and thereby favoritable).
TODO:
CombinedPaneland autocollapse mode