Sidepanel feedback #907
Sidepanel feedback #907
Conversation
| justify-content: center; | ||
| width: 60px; | ||
| height: 60px; | ||
| border: 2px solid ${color}; |
There was a problem hiding this comment.
We should increase the border when it's successful or had an error (designs have them at 3px but we may want to play around with this).
There was a problem hiding this comment.
If I recall correctly this was updated to 40px width and height and 3px border right?
There was a problem hiding this comment.
We have to check with @dizzypaty on this; that was only for the Voting app but may not be the case for the signing panel itself (since its feedback surface is much larger).
There was a problem hiding this comment.
Yes, it was updated in the Voting app module (to be 40x40px) to make it more compact for that context. But we should keep the current size (60x60px) on the signer panel. As Brett said, the reason being its surface being larger here and being the most important item the users need to look at when performing this action. Once we standarize this component, it will make sense to define all its possible sizes depending on where is presented.
…tions * origin/newstyle: MenuPanel tweaks (#933) Home redesign (#934) SignerPanel: consolidate external transaction props into intent object (#931) useLocalIdentity: handle remove case (#930) Add AppInternal to manage the layout logic of internal apps (#932) MenuPanel: adjust for new styles (#923) SignerPanel: display warning for external transactions (#850) Remove Badge and update occurrences for Tag (#901) SignerPanel: adjust for new styles (#920) Organization Settings: replace old Settings app (#896) Permissions: new style (#899) Sidepanel: redesign feedback indicator (#907) eslint: make sure curly braces are used everywhere (#924) Org switcher: new style + add FavoritesMenu (#925)
Accompanying changes for Voting (although these apply everywhere)