Home redesign #934
Merged
Home redesign #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bpierre
commented
Aug 24, 2019
bpierre
commented
AquiGorka
reviewed
Aug 26, 2019
| onMessage={this.handleAppMessage} | ||
| onOpenApp={this.openApp} | ||
| /> | ||
| <AppInternal> |
There was a problem hiding this comment.
Wonder if it would make sense to wrap Home within its own file? What do you think?
There was a problem hiding this comment.
You mean in a different way than it is now? https://github.com/aragon/aragon/pull/934/files#diff-cdace88e2d25deba8b1d9ed1f6560baf
There was a problem hiding this comment.
Just wondering if it could be:
export default React.memo(props => <AppInternal><Home {..props} /></AppInternal>)To avoid more code in Wrapper, no other reason.
There was a problem hiding this comment.
Oh I see, yes good idea! We are probably going to wrap every app in OrgView with Root, so maybe we can do this + move all the AppInternal inside the apps at the same time 👍
AquiGorka
approved these changes
Aug 26, 2019
2color
added a commit
that referenced
this pull request
Aug 28, 2019
…tions * origin/newstyle: MenuPanel tweaks (#933) Home redesign (#934) SignerPanel: consolidate external transaction props into intent object (#931) useLocalIdentity: handle remove case (#930) Add AppInternal to manage the layout logic of internal apps (#932) MenuPanel: adjust for new styles (#923) SignerPanel: display warning for external transactions (#850) Remove Badge and update occurrences for Tag (#901) SignerPanel: adjust for new styles (#920) Organization Settings: replace old Settings app (#896) Permissions: new style (#899) Sidepanel: redesign feedback indicator (#907) eslint: make sure curly braces are used everywhere (#924) Org switcher: new style + add FavoritesMenu (#925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.