Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuPanel tweaks #933

Merged
merged 7 commits into from
Aug 27, 2019
Merged

MenuPanel tweaks #933

merged 7 commits into from
Aug 27, 2019

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Aug 24, 2019

  • Remove references to the org switcher.
  • Spacing / transition tweaks.
  • Fix the vertical alignment of the labels.
  • Re-add the “slide down” effect on the system apps.

bpierre added 2 commits August 24, 2019 22:56
@bpierre
MenuPanel: remove references to the org switcher
c2edd08
@bpierre
MenuPanel: spacing / transition tweaks
1996f96 
- Fix the labels vertical alignment
- Re-add the “slide down” effect on the system apps
- Spacing
@bpierre bpierre requested a review from sohkai August 24, 2019 21:02
@auto-assign auto-assign bot requested a review from AquiGorka August 24, 2019 21:02
@bpierre bpierre changed the title Menupanel tweaks MenuPanel tweaks Aug 24, 2019
@vercel vercel bot temporarily deployed to staging August 24, 2019 21:06 Inactive
AquiGorka
AquiGorka approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:slide-emoji:

@vercel vercel bot temporarily deployed to staging August 26, 2019 14:24 Inactive
@vercel vercel bot temporarily deployed to staging August 26, 2019 14:28 Inactive
sohkai
sohkai approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpierre I've just added a few commits that revert the removal of the OrgSwitcher (as discussed offline; we'll be keeping this 😄).

@bpierre
Copy link
Contributor Author

bpierre commented Aug 26, 2019

@sohkai Thank you 🙈

@bpierre bpierre merged commit 640c3b4 into newstyle Aug 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the menupanel-tweaks branch August 27, 2019 22:55
2color added a commit that referenced this pull request Aug 28, 2019
@2color
Merge remote-tracking branch 'origin/newstyle' into newstyle-notifica…
433ea60 
…tions

* origin/newstyle:
  MenuPanel tweaks (#933)
  Home redesign (#934)
  SignerPanel: consolidate external transaction props into intent object (#931)
  useLocalIdentity: handle remove case (#930)
  Add AppInternal to manage the layout logic of internal apps (#932)
  MenuPanel: adjust for new styles (#923)
  SignerPanel: display warning for external transactions (#850)
  Remove Badge and update occurrences for Tag (#901)
  SignerPanel: adjust for new styles (#920)
  Organization Settings: replace old Settings app (#896)
  Permissions: new style (#899)
  Sidepanel: redesign feedback indicator (#907)
  eslint: make sure curly braces are used everywhere (#924)
  Org switcher: new style + add FavoritesMenu (#925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AquiGorka AquiGorka AquiGorka approved these changes

@sohkai sohkai sohkai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bpierre @AquiGorka @sohkai