Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openpilot performance on various cars and calibration module #149

Closed
hongyuli opened this issue Nov 8, 2017 · 1 comment
Closed

Openpilot performance on various cars and calibration module #149

hongyuli opened this issue Nov 8, 2017 · 1 comment

Comments

@hongyuli
Copy link

hongyuli commented Nov 8, 2017

Hi,

I noticed (1) on demo videos, openpilot did a great job on lane keeping, (2) comma AI is also trying to extend the compatibility to more vehicles. I'm just curious about what would be the performance of openpilot on different cars? Or, the question might be how could openpilot maintain a good performance for various cars?

To adapt openpilot to different cars, a couple of parameters will affect the end to end driving performance, such as camera pose, camera/smartphone mounting position, steering ratio, etc. Steering ratio might be easy to calibrate. However, for camera pose and camera/smartphone mounting position, they may largely affect the model performance. So, I'm wondering

(1) Does openpilot/NEO have to be mounted on a specific fixed location? I checked the NEO tutorial, it seems the 3D printed case has to be mounted on a specific location as shown in https://www.youtube.com/watch?v=GzrHNI6eCHo . However, in this demo video https://www.youtube.com/watch?v=PwOnsT2UW5o&t=204s even though a general phone mount is used, the system could also work.

(2) What is the calibration process of openpilot? Does current open source code include any calibration functionality? Is it included in currently black boxed visiond, or a sperate model not open sourced yet, or comma ai has a large training dataset including various camera mounting positions and poses? Just curious about how to make the model to have such a good compatibility.

Thanks a lot.

rbiasini pushed a commit that referenced this issue Jan 25, 2019
9ee6285 optimize board build for size to avoid going over the limit. (#150)
20e8fa9 Start introducing Bounties
a2046e9 make it smaller
1dfcf2b update panda price
37ee289 chrysler safety: fixed comments
c2dfbad tesla safety: return -1 to block forward (#149)
74c0c1b update README
be0061d Chrysler: safety now based on motor torque
039d183 Chrysler: fixed regression test
9193eeb Chrysler: safety limits updated
04f1d44 Chrysler safety: 3 sa max rate down for now
cf3ecd6 Chrysler safety: re-using hyundai framework
49ed9bc Update CLICKS for longer bootup time of EONS and avoid unwanted fast charge mode

git-subtree-dir: panda
git-subtree-split: 9ee6285
legonigel pushed a commit that referenced this issue Mar 26, 2019
3a55ae9 New camry steer message (#149)
6cd0238 Add 2019 CR-V Hybrid DBC (#148)
721e9b2 Subaru: set speed can be in kph and it needs 8 bits
0e98b2c Subaru: update LKAS_State
945b6ad Subaru: slightly touched wheel speed factor
608a4a62 Add files via upload (#147)
6a29f7e Subaru: fixed DOOR_OPEN sgs
434debb Adds dbc for 2017 lexus is300h (hybrid) (#146)
679dd42 Subaru: some cleanup to dbc
38140d2 Subaru: endianess consistency in wheel speeds
8281813 Subaru Global: more endianess consistency. Still a long way to go
a3b78a3 Subaru Global: simplified Stalk Message
b8250bc fixed sign in steering angle
9552df4 Subaru: left steer is positive
4aca14c SUBARU LKAS: minus sign to steer command to match standard convention
a6cc574 Merge pull request #145 from Jafaral/master
abcb9a2  Add Mazda CX-5 2017 GT
f4a8f79 Pedal: back again at 6 bytes
3fd25bf Pedal: same checksum and counter (#143)
2c74c55 Toyota pedal: messages are now 7 bytes
732f3fc Toyota pedal: added counter
acf0da7 Subaru global dbc (#142)
e0fa5d0 Subaru: added global dbc
cb22125 change chrysler radar to all big endian to avoid OP can parser bug (#141)
ecf99e0 chrysler car model in LKAS message so we can use CAN packer (#140)

git-subtree-dir: opendbc
git-subtree-split: 3a55ae9
@legonigel
Copy link

Your EON should be mounted roughly center of the windshield where it can see the whole road. For example see some community guides here and here.

There is calibration in openpilot. See calibrationd, but the camera is still expected to be generally close to the center of the windshield.

mespiritu pushed a commit to mespiritu/openpilot that referenced this issue Apr 1, 2019
 Fix crash when user reverts to 0.5.9 from 0.5.10
Jamezz pushed a commit to jamezz-comma/openpilot that referenced this issue Apr 5, 2019
avolmensky pushed a commit to avolmensky/openpilot that referenced this issue Jun 10, 2019
* New steer message

More accuracy and less latency

* Fixed range

* Removed extra line

* Moved signal to the correct message and ran generator

Saw checksum and threw it under the wrong message
icmma pushed a commit to priuscom/openpilot that referenced this issue Jun 16, 2019
avolmensky pushed a commit to avolmensky/openpilot that referenced this issue Jun 30, 2019
DrFritzi pushed a commit to DrFritzi/openpilotOld that referenced this issue Jan 30, 2021
SebastienLubrano pushed a commit to SebastienLubrano/openpilot that referenced this issue Aug 9, 2021
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
nworb-cire pushed a commit to opgm/openpilot that referenced this issue Aug 2, 2024
…#149)

* ui: Driving Screen Off: show/hide toggles with param updates

* not just yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants