Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Update - Add Skins #140

Closed
wants to merge 63 commits into from
Closed

UI Update - Add Skins #140

wants to merge 63 commits into from

Conversation

klaus385
Copy link

@klaus385 klaus385 commented Oct 4, 2017

@pjlao307 decided that he wasn't going to be updating his ui-update branch. However, I am one of the users that greatly appreciates it. As such I have talked with @pjlao307 before submitting this updated pull request for 0.3.7 of openpilot.

This pull request allows for the other "Add Skins" pull request to be closed. As such I hope that this request will be able to be merged so others can have the option of using skins.

pjlao307 and others added 30 commits July 3, 2017 11:14
Merge from commaai/openpilot:devel
openpilot v0.3.5 release
openpilot v0.3.5 release
…eloads the PNGs because the UIScene is re-initialized so the PNGs are taken out of UIScene struct
openpilot v0.3.6 tweaks
@klaus385
Copy link
Author

klaus385 commented Oct 5, 2017

@energee just fixed this issue of stripping the colors though the size increases on each image. Which I assume that's what you meant by heavy.

speed-svg-color.zip

@pjlao307
Copy link
Contributor

pjlao307 commented Oct 5, 2017

The delay in starting up visiond is because it has to extract and load the PNGs into memory. So if you can speed that process up that would solve the delay issue. Otherwise, you can just remove the use of those PNGs and get rid of the "notch" code so it's just the background circles around the speeds.

@klaus385
Copy link
Author

klaus385 commented Nov 3, 2017

Updated for 0.3.8.2 still praying you will merge this or if not then is their a ui update coming up the pipe?

@mcampa
Copy link

mcampa commented Dec 20, 2017

Can you post screenshots?

@klaus385
Copy link
Author

@mcampa sure though with the updates of 0.4 these UI changes are irrelevant.

Thus, I’m closing this Pull Request.

@klaus385 klaus385 closed this Dec 27, 2017
rbiasini pushed a commit that referenced this pull request Nov 17, 2018
293fa33 Honda: fixed message forwarding addresses from can2 to can0
799c338 Chrysler safety controls (#130)
c05b15b Toyota frc on (#141)
8291971 Toyota: using a more generalized CRUISE_ACTIVE bit that works on all cars
6f157aa Toyota frc on (#140)
8d2470c bumped panda version
915ee4f Honda: forwarding CAN0 to camera, so camera can stay on (#139)

git-subtree-dir: panda
git-subtree-split: 293fa33
legonigel pushed a commit that referenced this pull request Mar 26, 2019
3a55ae9 New camry steer message (#149)
6cd0238 Add 2019 CR-V Hybrid DBC (#148)
721e9b2 Subaru: set speed can be in kph and it needs 8 bits
0e98b2c Subaru: update LKAS_State
945b6ad Subaru: slightly touched wheel speed factor
608a4a6 Add files via upload (#147)
6a29f7e Subaru: fixed DOOR_OPEN sgs
434debb Adds dbc for 2017 lexus is300h (hybrid) (#146)
679dd42 Subaru: some cleanup to dbc
38140d2 Subaru: endianess consistency in wheel speeds
8281813 Subaru Global: more endianess consistency. Still a long way to go
a3b78a3 Subaru Global: simplified Stalk Message
b8250bc fixed sign in steering angle
9552df4 Subaru: left steer is positive
4aca14c SUBARU LKAS: minus sign to steer command to match standard convention
a6cc574 Merge pull request #145 from Jafaral/master
abcb9a2  Add Mazda CX-5 2017 GT
f4a8f79 Pedal: back again at 6 bytes
3fd25bf Pedal: same checksum and counter (#143)
2c74c55 Toyota pedal: messages are now 7 bytes
732f3fc Toyota pedal: added counter
acf0da7 Subaru global dbc (#142)
e0fa5d0 Subaru: added global dbc
cb22125 change chrysler radar to all big endian to avoid OP can parser bug (#141)
ecf99e0 chrysler car model in LKAS message so we can use CAN packer (#140)

git-subtree-dir: opendbc
git-subtree-split: 3a55ae9
mespiritu pushed a commit to mespiritu/openpilot that referenced this pull request Apr 1, 2019
Matched gas profiles from dynamic follow to release2
avolmensky pushed a commit to avolmensky/openpilot that referenced this pull request Jun 10, 2019
avolmensky pushed a commit to avolmensky/openpilot that referenced this pull request Jun 30, 2019
* Honda: forwarding CAN0 to camera, so camera can stay on

* forward cam on toyota

* fwd some honda camera msgs

* add crv and rdx steering msg to honda fwd filter

* only fwd cam on toyota if frc is connected

* toyota: remove unused variables

* toyota: don't forward frc bus when switch 1 is high
SippieCup pushed a commit to SippieCup/openpilot that referenced this pull request Jan 17, 2020
SebastienLubrano pushed a commit to SebastienLubrano/openpilot that referenced this pull request Aug 9, 2021
CT921 pushed a commit to CT921/openpilot that referenced this pull request Apr 22, 2022
Change unsafeMode to resolve controls mismatch
mlocoteta pushed a commit to mlocoteta/openpilot that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants