Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with on android with TextInput focus inside ScrollView #17892

Closed
wants to merge 467 commits into from
Closed

Fixes issue with on android with TextInput focus inside ScrollView #17892

wants to merge 467 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Mar 7, 2018

  1. Clean up FabricUIManagerViewHierarchyTest

    Reviewed By: mdvacca
    
    Differential Revision: D7165823
    
    fbshipit-source-id: e6d2a83bf9e089c67d69de6581d177bdf0d2ec4e
    ayc1 authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    6fc4163 View commit details
    Browse the repository at this point in the history
  2. check for GET and Head in send request

    Summary:
    React Native had an underlying problem connecting to Firestore (Google's latest database) from Android devices. You can follow the issue [here](firebase/firebase-js-sdk#283).
    The main problem was in NetworkingModule.java. Please refer to section 3 of 4.5.6 in whatwg.org's guideline https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send
    
    In this [video](https://www.youtube.com/watch?v=tILagf46ys8), I am showing how the react native behaved before adding the new fix and how it worked after the new fix added.  The new fix starts at 50 seconds.
    
    [ANDROID] [BUGFIX] [FIRESTORE][XMLHttpRequest][ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.java] - Fixes the connection to Firestore by following whatwg.org's XMLHttpRequest send() method
    Closes #17940
    
    Differential Revision: D7173468
    
    Pulled By: hramos
    
    fbshipit-source-id: 354d36f03d611889073553b93a7c43c6d4363ff3
    samsafay authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    d52569c View commit details
    Browse the repository at this point in the history
  3. Allow Inspector to handle 2 renderers

    Summary: To avoid crashing when there are 2 different renderers, let the Inspector be a bit lenient.
    
    Reviewed By: yungsters
    
    Differential Revision: D7175338
    
    fbshipit-source-id: ee5f86252f090361e42b6e2a93ae56c4c83c8c53
    fkgozali authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    d7b5b2e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c129457 View commit details
    Browse the repository at this point in the history
  5. Type TextStyleProp

    Reviewed By: yungsters
    
    Differential Revision: D7176472
    
    fbshipit-source-id: 35f499bdac6c089d5f45884f6f11ea539c8b7085
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    321ba06 View commit details
    Browse the repository at this point in the history
  6. Merging tests for flattenStyle

    Reviewed By: yungsters
    
    Differential Revision: D7176652
    
    fbshipit-source-id: 25b6f2e4f8397ba6f07b2913775b91af90b45750
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    135637c View commit details
    Browse the repository at this point in the history
  7. Remove Unused Exports from StyleSheetTypes

    Summary: These types were barely used and unnecessary.
    
    Reviewed By: yungsters
    
    Differential Revision: D7177287
    
    fbshipit-source-id: 63cb6d3aae4889a92b2c23f0df864b5657e6e1ee
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    b58e377 View commit details
    Browse the repository at this point in the history
  8. Fixing bugs in link and unlink

    Summary:
    Android uses the name of the package, not the config, for the `isInstalled` check. Sending both parameters to `isInstalled` so we have a consistent API.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    A bug was uncovered in the react-native link command where Android would not unlink because the wrong parameters were being sent to `isInstalled`.
    
    Successfully linked and unlinked `react-native-fs` on Windows and Mac. Jest tests pass.
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    
    [CLI][BUGFIX][local-cli/link/link.js] - Fix issue with `isInstalled` check for Android
    [CLI][BUGFIX][local-cli/link/unlink.js] - Fix issue with `isInstalled` check for Android
    [CLI][BUGFIX][local-cli/link/ios/common/unregisterNativeModule.js] - Fix references to unregister implementations.
    Closes #18207
    
    Differential Revision: D7180885
    
    Pulled By: hramos
    
    fbshipit-source-id: 5f479cd9d7b1ebd8626b461e9dc1f22988e2c61f
    rozele authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    ec88489 View commit details
    Browse the repository at this point in the history
  9. iOS Surface: properly reset some internal states when JS reloads

    Summary:
    There are a few important states that didn't reset correctly when reloading JS:
    * the RCTSurfaceStage was stuck at all bits enabled, hence no further stage change happened (even though the state "reset" to `RCTSurfaceStageBridgeDidLoad`)
    * the RCTSurfaceView didn't get recreated, because the _view ivar was never cleared
    * similarly, the _touchHandler ivar attached to the _view was never re-setup --> all touches after JS reload were dropped before this diff
    
    Reviewed By: mmmulani
    
    Differential Revision: D7178038
    
    fbshipit-source-id: ba49bc205f8bf43842471b7ab748cef8549ea212
    fkgozali authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    cade297 View commit details
    Browse the repository at this point in the history
  10. Make StyleSheet.create type private

    Summary:
    This type is being used in many places where a much simpler type is often better. In a real pinch this type can still be accessed as so:
    
    ```
    function returnsStyleSheet(
    ): $Call<typeof StyleSheet.create, *> {
      return StyleSheet.create({
        root: {
          background: 'white',
        }
      })
    }
    
    returnsStyleSheet().foo // foo doesn't exist
    returnsStyleSheet().root // okay
    ```
    
    Reviewed By: yungsters
    
    Differential Revision: D7178524
    
    fbshipit-source-id: 3c0ed03486ca00f1e287261e402fd47807f1fc3d
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    ee26d9b View commit details
    Browse the repository at this point in the history
  11. Rename StyleProp to DangerouslyImpreciseStyleProp

    Summary:
    We want to rename these types to be more clear what they are actually for. I did this with a find and replace:
    
    ```
    import type {StyleProp} from 'StyleSheet';
    ```
    
    to
    
    ```
    import type {DangerouslyImpreciseStyleProp} from 'StyleSheet';
    ```
    
    and `StyleProp` to `DangerouslyImpreciseStyleProp`.
    
    Reviewed By: yungsters
    
    Differential Revision: D7178609
    
    fbshipit-source-id: 32952e0c3a8b6aceef306f1f3c18844feb18f1aa
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    49ffc9f View commit details
    Browse the repository at this point in the history
  12. StyleObj -> DangerouslyImpreciseStyleProp

    Summary:
    Migrating everything to import from StyleSheet instead of StyleSheetTypes.
    
    Search and replaced
    ```
    import type {StyleObj} from 'StyleSheetTypes';
    ```
    to
    ```
    import type {DangerouslyImpreciseStyleProp} from 'StyleSheet';
    ```
    
    and then replacing `StyleObj` with `DangerouslyImpreciseStyleProp` and fixing up the remaining flow errors by hand.
    
    Reviewed By: yungsters
    
    Differential Revision: D7184077
    
    fbshipit-source-id: b8dabb9d48038b5a997ab715687300bad57aa9d4
    elicwhite authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    a3c07c9 View commit details
    Browse the repository at this point in the history
  13. Bump metro@0.29.0

    Reviewed By: BYK
    
    Differential Revision: D7181876
    
    fbshipit-source-id: a1b567303b8024b832bf43dd6be56ccebffaf39c
    rafeca authored and facebook-github-bot committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    3c23645 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. Move __StyleProp to StyleSheet

    Reviewed By: yungsters
    
    Differential Revision: D7185815
    
    fbshipit-source-id: 897ae37af3f03aa1408f020bcc7e61004d4dbc0d
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    cf89a2c View commit details
    Browse the repository at this point in the history
  2. Mark more ObjC methods called from RN as dynamic

    Reviewed By: kostiakoval
    
    Differential Revision: D7174480
    
    fbshipit-source-id: 38af8e6e94cb8cdf6aa551d9df1b3e16543387e5
    tgrlnc authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    23e0f86 View commit details
    Browse the repository at this point in the history
  3. iOS: create C++ <-> ObjC++ connector for FabricUIManager to do UI ope…

    …rations
    
    Reviewed By: shergin
    
    Differential Revision: D7162911
    
    fbshipit-source-id: 3e303020dafdccc51f52c3359a7054dc8a787978
    fkgozali authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    7bf3b20 View commit details
    Browse the repository at this point in the history
  4. Fix RefreshControl's dependency on AndroidSwipeRefreshLayout

    Reviewed By: mdvacca
    
    Differential Revision: D7185836
    
    fbshipit-source-id: 726e6e6792f1f3971c2f7de9bb83ff888815220d
    ayc1 authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    a162dc8 View commit details
    Browse the repository at this point in the history
  5. Initialize ReactChoreographer before creating the TimingModule

    Reviewed By: mdvacca
    
    Differential Revision: D7185838
    
    fbshipit-source-id: f775f5668ccff3b311c95a0bdd37a420ec64b7d4
    ayc1 authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    596bcb6 View commit details
    Browse the repository at this point in the history
  6. Don't assume the SourceCode native module exists

    Reviewed By: yungsters
    
    Differential Revision: D7185837
    
    fbshipit-source-id: e8efc22ac0af092dbc1fdf616b0b3f111390dd5d
    ayc1 authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    8cdc7d3 View commit details
    Browse the repository at this point in the history
  7. Add eslint-plugin-react-native Yarn package and enable no-inline-styl…

    …es rule for Marketplace
    
    Reviewed By: TheSavior
    
    Differential Revision: D7158098
    
    fbshipit-source-id: 52c92c5427d27278c8f82ffa5d61b7e9ebbf7824
    SnowCoderAlex authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    89757ed View commit details
    Browse the repository at this point in the history
  8. Convert constant with build flags to function

    Reviewed By: ttsugriy
    
    Differential Revision: D7184372
    
    fbshipit-source-id: c66f473ad15898532f24c6276898ab250e749744
    Jakub Grzmiel authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    5f497ca View commit details
    Browse the repository at this point in the history
  9. Remove usage of Internal StyleSheet type

    Summary: This type shouldn't be necessary from outside code. All callsites were able to be fixed by using the other types like TextStyleProp
    
    Reviewed By: yungsters
    
    Differential Revision: D7187551
    
    fbshipit-source-id: 34fb7fb5f5e72e6cfcb9748157cb5eb6ad3e1f46
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    d89517d View commit details
    Browse the repository at this point in the history
  10. Remove usage of Styles type

    Summary: This type was often used when (View|Text|Image)StyleProp should have been used instead. Since there were no valid usages of it in our codebase, we are not making it public anymore.
    
    Reviewed By: yungsters
    
    Differential Revision: D7188658
    
    fbshipit-source-id: 7112cc4a7da7b007b5c758a0890d2e0b8fe1797a
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    852084a View commit details
    Browse the repository at this point in the history
  11. Prettier

    Reviewed By: yungsters
    
    Differential Revision: D7188912
    
    fbshipit-source-id: 3466c542dc0fb1832b4545b1a307183efcd72b1d
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    5b32358 View commit details
    Browse the repository at this point in the history
  12. Rename Style to DangerouslyImpreciseStyle

    Reviewed By: yungsters
    
    Differential Revision: D7190268
    
    fbshipit-source-id: d652a95be7550d65cfbfc59f41d7bda92915bacf
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    4895c64 View commit details
    Browse the repository at this point in the history
  13. Update additional license headers

    Reviewed By: sophiebits
    
    Differential Revision: D7196607
    
    fbshipit-source-id: 9e6452f583b2b5616f5bb38f26f2ae33c14bb820
    hramos authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    f2ad77f View commit details
    Browse the repository at this point in the history
  14. Ignore yarn.lock and package-lock.json in oss

    Summary:
    Attn janicduplessis
    Closes #18281
    
    Differential Revision: D7200858
    
    Pulled By: hramos
    
    fbshipit-source-id: 8566251255a12aba3a3f9d6af532c4f842a8c41e
    hramos authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    ecd3d95 View commit details
    Browse the repository at this point in the history
  15. Fix typing of View refs

    Reviewed By: olegbl
    
    Differential Revision: D7192405
    
    fbshipit-source-id: 9d9bce8202a5e8f44d92ef6d0afbf8f55e9ea95a
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    49396aa View commit details
    Browse the repository at this point in the history
  16. propTypes are optional for native components

    Summary:
    We plan to migrate native components like View, Text, and Image to be typed with Flow instead of propTypes so that we can better enforce our usages.
    
    This change makes it so that *if* propTypes are defined they must cover the native props. However, if they aren't specified, the validation doesn't occur.
    
    Eventually, the prop validation should occur via codegen that generates an interface the native component must implement from the flow types defined in JS.
    
    Reviewed By: yungsters
    
    Differential Revision: D7203649
    
    fbshipit-source-id: a8095aa46807ce03272e2962289e8f5705b422b9
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    dbdf43b View commit details
    Browse the repository at this point in the history
  17. AccessibilityLabel is optional

    Summary:
    We have a bunch of components internally that use accessibilityLabel in invalid ways.
    View was originally typed as any so invalid usages weren't caught. In order to fix these we have to move forward with getting back to flow having no errors. We are weakening these types to get there and we can tighten them again later.
    
    Reviewed By: yungsters
    
    Differential Revision: D7203260
    
    fbshipit-source-id: 2282eba14899c620de5b4b1c1b2670b157f2fc9e
    elicwhite authored and facebook-github-bot committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    214da52 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2018

  1. fabric/debug module and DebugStringConvertible class

    Summary:
    This is a very first diff in a series of undefined length implementing React Native Shadow Tree infra in C++.
    All Shadow Nodes, Props and etc. implements `DebugStringConvertible`.
    
    Authored by shergin
    
    Reviewed By: shergin
    
    Differential Revision: D7163868
    
    fbshipit-source-id: 9c001aa5bd0723f709a07b1833f512c51e3bec11
    fkgozali authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    34f8e7f View commit details
    Browse the repository at this point in the history
  2. fabric/core module and Sealable class

    Summary:
    `Sealable` class represents something which can be *sealed* (imperatively marked as immutable).
    
    Authored by shergin
    
    Reviewed By: shergin
    
    Differential Revision: D7174883
    
    fbshipit-source-id: 8b26ca5b1a5154953a099895778eab86228acc46
    fkgozali authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    3c86701 View commit details
    Browse the repository at this point in the history
  3. RN: Prettify Systrace

    Reviewed By: TheSavior
    
    Differential Revision: D7207468
    
    fbshipit-source-id: 05ae6e003ae3e55bc2d3a905f41c28f7041dd7f0
    yungsters authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    118521c View commit details
    Browse the repository at this point in the history
  4. RN: Delete Systrace for RelayClassic

    Reviewed By: TheSavior
    
    Differential Revision: D7207462
    
    fbshipit-source-id: 6dd5c5fd22c0a5a7d77331d6adf7b362c3d3e037
    yungsters authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a8c4b63 View commit details
    Browse the repository at this point in the history
  5. RN: Delete Systrace.swizzleJSON

    Reviewed By: TheSavior
    
    Differential Revision: D7207460
    
    fbshipit-source-id: 14b1174d6a5c75e1acba7272376d1c462bc13cb6
    yungsters authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    3e141cb View commit details
    Browse the repository at this point in the history
  6. Fix race condition when there're two flags next to each other

    Reviewed By: yungsters
    
    Differential Revision: D7194598
    
    fbshipit-source-id: a76328d63f649403de15503596a179c7baaf7dc3
    alexeylang authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    8803ab2 View commit details
    Browse the repository at this point in the history
  7. Make fetchSegment native hook name consistent with __ prefix

    Reviewed By: jeanlauliac
    
    Differential Revision: D7205472
    
    fbshipit-source-id: 4cef66539167ed47cf0ac8d3665c20114ffff375
    fromcelticpark authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    20fcf47 View commit details
    Browse the repository at this point in the history
  8. Clone ReactShadowNode when Yoga clones a YogaNode during layout

    Reviewed By: achen1
    
    Differential Revision: D7195840
    
    fbshipit-source-id: d596e3ada8fe48577b91295721d41c0afd33087f
    mdvacca authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a7558d5 View commit details
    Browse the repository at this point in the history
  9. Add extra debug information to ReactShadowNodes objects

    Reviewed By: achen1
    
    Differential Revision: D7195373
    
    fbshipit-source-id: 6611726c3e1f92f387e00e733b1b8909a3e9edc2
    mdvacca authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    e31781b View commit details
    Browse the repository at this point in the history
  10. Add "newProps" map into ReactShadowNode

    Reviewed By: achen1
    
    Differential Revision: D7205127
    
    fbshipit-source-id: 6c27070806de36cab7adf9c392a10c815aee90d4
    mdvacca authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c883d4e View commit details
    Browse the repository at this point in the history
  11. Fixing Assorted View Flow Types

    Reviewed By: yungsters
    
    Differential Revision: D7209495
    
    fbshipit-source-id: e4b247e947b3463ea1200298e6078c7485d636e7
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    2520c64 View commit details
    Browse the repository at this point in the history
  12. Making values optional in ViewPropTypes

    Reviewed By: yungsters
    
    Differential Revision: D7209560
    
    fbshipit-source-id: fd0c55c4f69648927380d12ad9a6b9bcb98047eb
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    f1316ca View commit details
    Browse the repository at this point in the history
  13. Add Sonar support to Oculus Twilight Android

    Reviewed By: alex1kom
    
    Differential Revision: D7177071
    
    fbshipit-source-id: 685d40e564d391d18592cedfcc12d8ac743a5331
    Caleb Meredith authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a48b4d5 View commit details
    Browse the repository at this point in the history
  14. Adding FlowFixMe when switching between Component and Ref

    Reviewed By: yungsters
    
    Differential Revision: D7215800
    
    fbshipit-source-id: 175f769a2b1fc67e72b10e113a96eb4167437ab0
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    25b8ec8 View commit details
    Browse the repository at this point in the history
  15. AndroidInfoModule now also returns Android ID

    Summary: Added Android ID as one of the constants returned by AndroidInfoModule
    
    Reviewed By: fkgozali
    
    Differential Revision: D7206029
    
    fbshipit-source-id: 110b33235d3023b4a4607d37acc3440cfe735cef
    L33tcodex0r authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    216c8ec View commit details
    Browse the repository at this point in the history
  16. Type VirtualizedList's ref

    Reviewed By: yungsters
    
    Differential Revision: D7215114
    
    fbshipit-source-id: 867a7b897f27d415269c11572708afeb570b4be0
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    b6b80f6 View commit details
    Browse the repository at this point in the history
  17. Mock ReactNative.NativeComponent native methods in jest

    Reviewed By: yungsters
    
    Differential Revision: D7218964
    
    fbshipit-source-id: f4b25a533b7e150c978863ff8411dc80937a4fed
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    3e9a371 View commit details
    Browse the repository at this point in the history
  18. Clear cache to resolve iOS, tvOS workflow

    Summary:
    tvOS and iOS workflows were flaky, apparently due to a stale cache that contained a problematic version of the Metro dependency. Thanks to motiz88 for identifying the potential cause of flakiness in react-native-community/releases#2 (comment).
    
    https://circleci.com/workflow-run/440180a2-e888-4f27-bec9-b8e5d9be6708
    
    [GENERAL] [MINOR] [CI] - Resolve iOS, tvOS failures in Circle
    Closes #18304
    
    Differential Revision: D7220150
    
    Pulled By: hramos
    
    fbshipit-source-id: 0f5e68c779dfce44e6deb8b813a3ac9e25a2ab97
    hramos authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c9d7562 View commit details
    Browse the repository at this point in the history
  19. Tightening types for View and VirtualizedList

    Reviewed By: yungsters
    
    Differential Revision: D7215391
    
    fbshipit-source-id: fa144c0dc3fd897864403b589e943ea88e78a999
    elicwhite authored and facebook-github-bot committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    5035af8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2018

  1. Bump metro@0.30.0

    Reviewed By: BYK
    
    Differential Revision: D7214924
    
    fbshipit-source-id: 4f50ec27e2dceb18e9ef82e741675df295235d74
    rafeca authored and facebook-github-bot committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    274d6ce View commit details
    Browse the repository at this point in the history
  2. Add existing Android checks to Circle.

    Summary:
    Moving towards reusing existing scripts to ensure local and CI tests are kept in sync.
    Closes #18307
    
    Differential Revision: D7222664
    
    Pulled By: hramos
    
    fbshipit-source-id: ecce91e32159c55b19c29eab69a6754642f02236
    hramos authored and facebook-github-bot committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    1ff1e57 View commit details
    Browse the repository at this point in the history
  3. Migrating View to be a Flow Typed ES6 class

    Summary:
    The flow type for View using createReactClass was essentially `any`, allowing any Prop to be passed in, only pseudo enforced at run time via propTypes.
    
    This diff converts View away from createReactClass and instead uses ReactNative.NativeComponent. This was previously typed as any as well which didn't buy us much. This change converts View to be an ES6 React class component to ensure proptypechecking, and exposes the methods copied from NativeMethodsMixin.
    
    Reviewed By: yungsters
    
    Differential Revision: D5933888
    
    fbshipit-source-id: eae63b818203e0e86741f9f154ec9cf3498369e2
    elicwhite authored and facebook-github-bot committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    26734a8 View commit details
    Browse the repository at this point in the history
  4. Upgrade to Flow v0.67

    Reviewed By: gabelevi
    
    Differential Revision: D7208080
    
    fbshipit-source-id: 81380aca39b7a74646a4a44af1e5571bc5629b77
    nmote authored and facebook-github-bot committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    adabae2 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2018

  1. Fix Android Sanity Buck version check

    Summary:
    [GENERAL] [MINOR] [./scripts/validate-android-test-env.sh] - Fix buck version check
    Closes #18311
    
    Differential Revision: D7227452
    
    Pulled By: hramos
    
    fbshipit-source-id: c7b32afc36821fbb2462317581ae32d3b257de03
    hramos authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    e057322 View commit details
    Browse the repository at this point in the history
  2. Move Text PropTypes to it's own file

    Reviewed By: fkgozali
    
    Differential Revision: D7226404
    
    fbshipit-source-id: b5637dee9a4f10daf0682e46f1ec8920ea03ae33
    elicwhite authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    cd8128b View commit details
    Browse the repository at this point in the history
  3. Fixing misuses of the Text type

    Reviewed By: fkgozali
    
    Differential Revision: D7227752
    
    fbshipit-source-id: 3577c86b416a7c04190063243839e98e2a80ec7f
    elicwhite authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    3fd82d3 View commit details
    Browse the repository at this point in the history
  4. RN: Remove DebugEnvironment from OSS

    Reviewed By: TheSavior
    
    Differential Revision: D7209266
    
    fbshipit-source-id: 9f9ce66121ff375e5a5d965d58f4137616407853
    yungsters authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    01fffa2 View commit details
    Browse the repository at this point in the history
  5. export CompositeAnimation type

    Differential Revision: D7216928
    
    fbshipit-source-id: 9e8c456c7e94ec3456061ad5c699c0eae30cbe5e
    zjj010104 authored and facebook-github-bot committed Mar 11, 2018
    Configuration menu
    Copy the full SHA
    450e562 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2018

  1. Use -fdata-sections in mode/opt

    Differential Revision: D7194366
    
    fbshipit-source-id: 676f2db2e493230b8d9698941f003ec4e96f15ea
    amirlivneh authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    19dd9a2 View commit details
    Browse the repository at this point in the history
  2. Loosen Platform check to allow better code sharing for out-of-tree pl…

    …atforms
    
    Summary:
    Don't lock out other non-iOS platforms (e.g. Windows) with an overly
    specific check. This change allows this JS file to be re-used instead of copied and modified. There was one other instance of this pattern, but I'll submit it separate for easier cherry-picking.
    
    Tested Android and iOS playground on simulators.
    
     [GENERAL] [ENHANCEMENT] - some core ReactNative JS library files will be easier to re-use across RN platforms.
    Closes #18308
    
    Differential Revision: D7230803
    
    Pulled By: hramos
    
    fbshipit-source-id: 11e03183535a7453cee00dc1e795c27f2fd2bf5d
    Matt Hargett authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    84affbd View commit details
    Browse the repository at this point in the history
  3. Fix tvOS react-native init release build (#18288)

    Summary:
    Add correct dependencies and linker flags to the HelloWorld template Xcode project so that HelloWorld-tvOSTests builds correctly for release builds.  Fixes #18288 .
    
    Tested with `react-native init --version=https://github.com/dlowder-salesforce/react-native#tvos-init-release-fix` .
    
    [IOS][BUGFIX][ local-cli/templates/ios/HelloWorld ]- fix release build for tvOS
    Closes #18337
    
    Differential Revision: D7240376
    
    Pulled By: hramos
    
    fbshipit-source-id: a4ad219e7d6b06bd6928d55ed7398f8fc9352e72
    douglowder authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    3002c4e View commit details
    Browse the repository at this point in the history
  4. Don't truncate in the middle of an emoji

    Reviewed By: adiphos, mantong01
    
    Differential Revision: D7198155
    
    fbshipit-source-id: 360955de7ed686170a23b9883058e3137e17b277
    Vince0613 authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    9c8c597 View commit details
    Browse the repository at this point in the history
  5. Add support for springDamping in SpringInterpolator

    Reviewed By: mdvacca
    
    Differential Revision: D7201334
    
    fbshipit-source-id: 50929b4294188cd5a2a8ffa2080c38c0a9983535
    axe-fb authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    1dde989 View commit details
    Browse the repository at this point in the history
  6. Support Image resizeMode=repeat on Android

    Summary:
    `<Image resizeMode="repeat" />` for Android, matching the iOS implementation (#7968). (Non-goal: changing the component's API for finer-grained control / feature parity with CSS - this would be nice in the future)
    
    As requested in e.g. #14158.
    
    Given facebook/fresco#1575, and lacking the context to follow the specific recommendations in facebook/fresco#1575 (comment), I've opted for a minimal change within RN itself.
    
    It's likely that performance can be improved by offloading this work to Fresco in some clever way; but I'm assuming that the present naive approach is still an improvement over a userland implementation with `onLayout` and multiple `<Image>` instances.
    
    - Picking up on a TODO note in the existing code, I implemented `MultiPostprocessor` to allow arbitrary chaining of Fresco-compatible postprocessors inside `ReactImageView`.
    - Rather than extensively refactor `ImageResizeMode`, `ReactImageManager` and `ReactImageView`, I mostly preserved the existing API that maps `resizeMode` values to [`ScaleType`](http://frescolib.org/javadoc/reference/com/facebook/drawee/drawable/ScalingUtils.ScaleType.html) instances, and simply added a second mapping, to [`TileMode`](https://developer.android.com/reference/android/graphics/Shader.TileMode.html).
    - To match the iOS rendering exactly for oversized images, I found that scaling with a custom `ScaleType` was required - a kind of combination of `CENTER_INSIDE` and `FIT_START` which Fresco doesn't provide - so I implemented that as `ScaleTypeStartInside`. (This is, frankly, questionable as the default behaviour on iOS to begin with - but I am aiming for parity here)
    - `resizeMode="repeat"` is therefore unpacked by the view manager to the effect of:
      ```js
         view.setScaleType(ScaleTypeStartInside.INSTANCE);
         view.setTileMode(Shader.TileMode.REPEAT);
       ```
      And the added postprocessing in the view (in case of a non-`CLAMP` tile mode) consists of waiting for layout, allocating a destination bitmap and painting the source bitmap with the requested tile mode and scale type.
    
    Note that as in #17398 (comment), I have neither updated nor tested the "Flat" UI implementation - everything compiles but I've taken [this comment](#12770 (comment)) to mean there's no point in trying to wade through it on my own right now; I'm happy to tackle it if given some pointers.
    
    Also, I'm happy to address any code style issues or other feedback; I'm new to this codebase and a very infrequent Android/Java coder.
    
    Tested by enabling the relevant case in RNTester on Android.
    
    | iOS | Android |
    |-|-|
    | <img src=https://user-images.githubusercontent.com/2246565/34461897-4e12008e-ee2f-11e7-8581-1dc0cc8f2779.png width=300>| <img src=https://user-images.githubusercontent.com/2246565/34461894-40b2c8ec-ee2f-11e7-8a8f-96704f3c8caa.png width=300> |
    
    Docs update: facebook/react-native-website#106
    
    [ANDROID] [FEATURE] [Image] - Implement resizeMode=repeat
    Closes #17404
    
    Reviewed By: achen1
    
    Differential Revision: D7070329
    
    Pulled By: mdvacca
    
    fbshipit-source-id: 6a72fcbdcc7c7c2daf293dc1d8b6728f54ad0249
    motiz88 authored and facebook-github-bot committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    0459e4f View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. Convert Text to ES6 Class

    Summary: Utilizing ES6 Classes instead of createReactClass lets us actually enforce the way Text is used via Flow.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7227755
    
    fbshipit-source-id: 8e8285f9ebb3783a0dc4837c37c163178910ff9f
    elicwhite authored and facebook-github-bot committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    ab92c00 View commit details
    Browse the repository at this point in the history
  2. Change newly imported file to MIT license

    Summary:
    The project at large switched to MIT last month. A PR that was opened prior to the change was merged, this PR updates the file to use the correct license.
    
    None, trivial PR
    
    [ANDROID] [MINOR] [Image] Update license
    Closes #18343
    
    Differential Revision: D7252836
    
    Pulled By: hramos
    
    fbshipit-source-id: b7c207c782f4bf19c12d121e86f394e52326a5ab
    hramos authored and facebook-github-bot committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    7a1c618 View commit details
    Browse the repository at this point in the history
  3. Use MIT license

    Summary: Closes #18352
    
    Differential Revision: D7257144
    
    Pulled By: hramos
    
    fbshipit-source-id: 477ff82f74cfa3fd0681c9522cc5199a60b24921
    hramos authored and facebook-github-bot committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    aa323d4 View commit details
    Browse the repository at this point in the history
  4. Refactor RCTInputAccessoryView view hierarchy and names

    Reviewed By: shergin
    
    Differential Revision: D7196162
    
    fbshipit-source-id: 07a5c13d4cdb876f5a632d7d53859eab5e235f49
    Peter Argany authored and facebook-github-bot committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    c136c54 View commit details
    Browse the repository at this point in the history
  5. Add docs for Swift usage to RCTBridgeModule.h

    Summary:
    Clarifies how to get a reference to RCTBridge from a Swift RCTBridgeModule.
    
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    In writing native modules for Swift, I have run into issues where the documentation applies only to Objective-C and does not supply adequate information for how one might accomplish something in Swift.
    
    This is a good example, where the `synthesize` method simply does not apply to Swift code.
    
    [IOS][ENHANCEMENT][Base/RCTBridgeModule.h] Add documentation for Swift usage.
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #18231
    
    Differential Revision: D7262850
    
    Pulled By: hramos
    
    fbshipit-source-id: c6babb3edd786be8571eb49258d594f2fb99141d
    ejmartin504 authored and facebook-github-bot committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    ca898f4 View commit details
    Browse the repository at this point in the history
  6. Fix clang-6 compile error (virtual destructor)

    Reviewed By: smeenai
    
    Differential Revision: D7264312
    
    fbshipit-source-id: f0567452127ceba6cfa13d05bb2a00a5af7aac05
    Naris Siamwalla authored and facebook-github-bot committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    41acb0a View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. Fix crash in Sapienz bot for Interpolator type

    Reviewed By: mdvacca
    
    Differential Revision: D7252818
    
    fbshipit-source-id: 30c585a2e6f6c2d7a7e7013c26c6228d8ef29aa6
    axe-fb authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    9737774 View commit details
    Browse the repository at this point in the history
  2. Don't wrap ListEmptyComponent in an extra view

    Summary:
    A common UI pattern for list empty states is some text/images centered inside the visible part of the list. This is pretty hard to do currently because we wrap ListEmptyComponent with an extra view with no way to style it so we cannot just use `flex: 1` to make it fill the available space.
    
    - Added an example of ListEmptyComponent in the FlatList example in RNTester
    
    Before (no way to make ListEmptyComponent fill the space):
    <img width="377" alt="screen shot 2018-03-05 at 5 24 15 pm" src="https://user-images.githubusercontent.com/2677334/37003152-129db3ac-209a-11e8-9600-110f10d57144.png">
    
    After:
    <img width="377" alt="screen shot 2018-03-05 at 5 09 20 pm" src="https://user-images.githubusercontent.com/2677334/37002809-e6971178-2098-11e8-8cf7-74bfb2f6a992.png">
    
    - Tested some edge cases like returning null from the ListEmptyComponent
    
    - Tested in an app that uses FlatList + ListEmptyComponent
    
    [GENERAL] [MINOR] [VirtualizedList] - Don't wrap ListEmptyComponent in an extra view
    Closes #18206
    
    Differential Revision: D7266274
    
    Pulled By: sahrens
    
    fbshipit-source-id: 4636d2418474a4c86ac63e5e18a9afc391a518c5
    janicduplessis authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    db061ea View commit details
    Browse the repository at this point in the history
  3. Revert #17927

    Summary:
    This change is a revert of [#17927](#17927) pull-request.
    The pull-request caused an issue with the keyboard covering the text field at the bottom of the scroll view.
    
    Reviewed By: shergin
    
    Differential Revision: D7246609
    
    fbshipit-source-id: 149f825274c4fa79ab593f1bae3602667d16ddee
    Sahil Ohri authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    8466db0 View commit details
    Browse the repository at this point in the history
  4. Remove the usage of YGUndefined in the default values of Border in YG…

    …Style
    
    Reviewed By: emilsjolander
    
    Differential Revision: D7195115
    
    fbshipit-source-id: e635cf55ac94d8a90caef6cafce281579da2cbfc
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    af4a363 View commit details
    Browse the repository at this point in the history
  5. Changed the return type of YGResolveValue

    Reviewed By: emilsjolander
    
    Differential Revision: D7195099
    
    fbshipit-source-id: 72c4163cd08691cf6e40df05394cc52e83b0de14
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    9f7e703 View commit details
    Browse the repository at this point in the history
  6. Change the type of flex to YGFloatOptional

    Reviewed By: emilsjolander
    
    Differential Revision: D7211327
    
    fbshipit-source-id: 0d979b6ba00317317b98bbc6e63979c7f1feb2da
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    5b3d595 View commit details
    Browse the repository at this point in the history
  7. Change the type of flexGrow to YGFloatOptional

    Reviewed By: emilsjolander
    
    Differential Revision: D7215355
    
    fbshipit-source-id: 1298ee332551d44e4d070169a1e4103d005c4f43
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    3274e9f View commit details
    Browse the repository at this point in the history
  8. Change the type of flexShrink to YGFloatOptional

    Reviewed By: emilsjolander
    
    Differential Revision: D7232171
    
    fbshipit-source-id: 3111119d3d74a7035c01132bff61b30cf44e120a
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    e3af150 View commit details
    Browse the repository at this point in the history
  9. Remove the use of YGUndefined for flex-basis

    Reviewed By: emilsjolander
    
    Differential Revision: D7243924
    
    fbshipit-source-id: 2bfaca1a5e3da40d5292a273cabf705f59c9d666
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    f3ef8f8 View commit details
    Browse the repository at this point in the history
  10. Expose layout diffing flag to java

    Reviewed By: emilsjolander
    
    Differential Revision: D7272067
    
    fbshipit-source-id: e67e82eb057e4c7124904c715f9dca4dcfea21ea
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    321b107 View commit details
    Browse the repository at this point in the history
  11. Bump metro@0.30.1

    Reviewed By: BYK
    
    Differential Revision: D7259632
    
    fbshipit-source-id: ef713d35a953cd829d6a8684d2fa9cfa30e69ac4
    rafeca authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    a01ae8b View commit details
    Browse the repository at this point in the history
  12. React sync for revisions ab4280b...ad9544f

    Reviewed By: bvaughn
    
    Differential Revision: D7256390
    
    fbshipit-source-id: 9fe1324da93cb8f4a7f478e1037944774b9b95ff
    hramos authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    4f8328b View commit details
    Browse the repository at this point in the history
  13. Expose native show message method in header

    Reviewed By: mmmulani
    
    Differential Revision: D7201691
    
    fbshipit-source-id: b5f74351a9be7e6e9a7fc7145a09ba9854efc002
    Eric Czarny authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    bec97dc View commit details
    Browse the repository at this point in the history
  14. Move Fabric JSC bindings to oss

    Reviewed By: mdvacca
    
    Differential Revision: D7205065
    
    fbshipit-source-id: 5876cb3e08ee96e39b80e6b377c60600f404ca21
    ayc1 authored and facebook-github-bot committed Mar 14, 2018
    2 Configuration menu
    Copy the full SHA
    3a2bdf5 View commit details
    Browse the repository at this point in the history
  15. Adds _lineHeight = NAN; to RCTTextAttributes

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    On iOS, when the parent Text contains the `lineHeight` style prop, and the children are also Text components they don't inherit the lineHeight prop.
    
    This is for **iOS** only.
    Create a react-native project with React Native 0.54.0 or 0.54.1 and change the app to:
    ```js
    import React, { Component } from 'react';
    import { StyleSheet, Text, View } from 'react-native';
    
    type Props = {};
    export default class App extends Component<Props> {
      render() {
        return (
          <View style={styles.container}>
            <Text style={{ fontWeight: 'bold', lineHeight: 40 }}>
              <Text style={{ color: 'orange' }}>I am bold and orange, </Text>
              <Text style={{ color: 'red' }}>I am bold and red, </Text>
              <Text style={{ color: 'blue' }}>I am bold and blue, </Text>
              <Text style={{ color: 'purple' }}>I am bold and purple, </Text>
              <Text style={{ color: 'yellow' }}>I am bold and yellow, </Text>
              <Text style={{ color: 'pink' }}>I am bold and pink</Text>
            </Text>
          </View>
        );
      }
    }
    
    const styles = StyleSheet.create({
      container: {
        backgroundColor: 'black',
        flex: 1,
        justifyContent: 'center',
        padding: 50,
      },
    });
    ```
    It displays:
    ![iphone - 2018-03-12 at 21 51 53](https://user-images.githubusercontent.com/480605/37308941-b56f082e-263f-11e8-9c23-892f77077169.png)
    
    But should look like:
    ![iphone - 2018-03-12 at 21 48 15](https://user-images.githubusercontent.com/480605/37308784-4efaddf2-263f-11e8-992b-ee0b6bb9a97b.png)
    
    New &lt;Text> iOS 2716f53
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    [IOS] [MINOR] [Text] - Inherit lineheight
    Closes #18340
    
    Differential Revision: D7276655
    
    Pulled By: shergin
    
    fbshipit-source-id: 0fe26536bb74da77be8405911fc699a622bc0b2f
    aparedes authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    7ce943e View commit details
    Browse the repository at this point in the history
  16. Move Image PropTypes to a new file

    Reviewed By: yungsters
    
    Differential Revision: D7270058
    
    fbshipit-source-id: 91ad7700b7e89c393c6977bfd82494d2febda4a4
    elicwhite authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    6765699 View commit details
    Browse the repository at this point in the history
  17. Create Flow Props for Image

    Reviewed By: yungsters
    
    Differential Revision: D7270057
    
    fbshipit-source-id: 1ecac28e4060fe0e85a4f0698406f8986ae16caf
    elicwhite authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    8bac869 View commit details
    Browse the repository at this point in the history
  18. Adding documentation to new StyleSheet Flow Types

    Summary: Adding some explanation and examples of when to use these types.
    
    Reviewed By: yungsters
    
    Differential Revision: D7270185
    
    fbshipit-source-id: c82f061ffb77e33133a59d268a08f7a95fd02fb6
    elicwhite authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    28c9c68 View commit details
    Browse the repository at this point in the history
  19. Add number-pad keyboardType

    Summary:
    On Android there's no number-pad but numeric instead, for my use-case I need number only (without decimal and sign, for PIN input)
    
    I write it so there's no breaking change for those already using the `TextInput` Component
    
    None
    
    [ANDROID][ENHANCEMENT][Component] Add number-pad keyboardType
    Closes #18350
    
    Reviewed By: achen1
    
    Differential Revision: D7269721
    
    Pulled By: mdvacca
    
    fbshipit-source-id: 82571dce948e0cf2e4354dc46c69198ec69ba65a
    khaeransori authored and facebook-github-bot committed Mar 14, 2018
    1 Configuration menu
    Copy the full SHA
    c595509 View commit details
    Browse the repository at this point in the history
  20. Add MIT license to Fabric

    Reviewed By: fkgozali
    
    Differential Revision: D7278262
    
    fbshipit-source-id: 39f4c73b8f693162eb037125bf64fecc7eb0cf8b
    ayc1 authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    304db5c View commit details
    Browse the repository at this point in the history
  21. Add Fabric integration test

    Reviewed By: fkgozali
    
    Differential Revision: D7207630
    
    fbshipit-source-id: 69cc10d7d45031eec9f3d934b981a5e4bb62a0ef
    ayc1 authored and facebook-github-bot committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    d678058 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. React sync for revisions ad9544f...ced176e

    Reviewed By: sebmarkbage
    
    Differential Revision: D7281277
    
    fbshipit-source-id: 75a638114cf2a65a5c973dbdf218f6d3ba042cc4
    Brian Vaughn authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    22004db View commit details
    Browse the repository at this point in the history
  2. Refactor resolvePlugins out to prepare for babel 7

    Reviewed By: BYK
    
    Differential Revision: D7287074
    
    fbshipit-source-id: ec703f7292b63b679dbad055a6e43ac907729bfe
    Peter van der Zee authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    6b1dc71 View commit details
    Browse the repository at this point in the history
  3. Fix setter and getter of margin, position, border and padding

    Reviewed By: emilsjolander
    
    Differential Revision: D7274115
    
    fbshipit-source-id: 942a91e6562ef789ae79102a828f397889468fa7
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    040642d View commit details
    Browse the repository at this point in the history
  4. Fix getters and setters if min and max Dimension

    Reviewed By: emilsjolander
    
    Differential Revision: D7274807
    
    fbshipit-source-id: 7c1a4c19e8d0552b089a410c3330392cb26a6a47
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    da2d410 View commit details
    Browse the repository at this point in the history
  5. Extract NativeExtensionsProvider definition

    Reviewed By: danzimm
    
    Differential Revision: D6964355
    
    fbshipit-source-id: e20dfa99bd9d8784a5f31a313302104d6dc33652
    Dmitry Zakharov authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    c989ea8 View commit details
    Browse the repository at this point in the history
  6. Gatekeeper for Native Extensions

    Reviewed By: danzimm, johnislarry
    
    Differential Revision: D6965463
    
    fbshipit-source-id: 28bcfbff980abfda3c63d7016ccf05beb1d178eb
    Dmitry Zakharov authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    8e85bf8 View commit details
    Browse the repository at this point in the history
  7. Replace js Dimensions with shadow view in InputAccessoryViewExample

    Reviewed By: mmmulani
    
    Differential Revision: D7196168
    
    fbshipit-source-id: 031ed5ab24d1075f775ec71e5b78d32e03fe8f6f
    Peter Argany authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    139d554 View commit details
    Browse the repository at this point in the history
  8. Fixed a typo and added a test case

    Reviewed By: emilsjolander
    
    Differential Revision: D7289221
    
    fbshipit-source-id: 48ee9ccfac4adee51d515a366b5a11790f7236fc
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    ce92b85 View commit details
    Browse the repository at this point in the history
  9. Moved YGFloatOptional from C struct to C++ struct

    Reviewed By: emilsjolander
    
    Differential Revision: D7288555
    
    fbshipit-source-id: f61cc92c8fd0d48d2fc1f4d0e6fcef155f19ff8a
    priteshrnandgaonkar authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    9102ff9 View commit details
    Browse the repository at this point in the history
  10. Remove @xplat cell syntax in open source

    Differential Revision: D7292243
    
    fbshipit-source-id: f1c162be8bc90669481f04de8aa71f3d9dbece36
    hramos authored and facebook-github-bot committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    f376fe3 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. Bump metro@0.30.2

    Reviewed By: BYK
    
    Differential Revision: D7292431
    
    fbshipit-source-id: 2d81e502e060ecd278977b838e0ef2db7e13b0e3
    rafeca authored and facebook-github-bot committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    b02b167 View commit details
    Browse the repository at this point in the history
  2. Local cli/android/normalize project name

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Scoped packages are starting to be the new thing, and gradle does not work properly with '/' in the project name, so this PR links them and replaces '/' by '_' . This only affects android.
    
    I added tests in the 2 impacted functions + a test file for the normalizer function
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
    -->
    [CLI] [BUGFIX] [local-cli/link/link.js] - On android, Scoped packages will now get the '/' replaced with '_' to ensure gradle works nicely.  ⚠️ However if you previously linked scoped packages, they will get linked again. ⚠️
    Closes #18275
    
    Differential Revision: D7305227
    
    Pulled By: hramos
    
    fbshipit-source-id: 1c95563e884175529692948b29407a7733c44353
    Titozzz authored and facebook-github-bot committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    dbd4759 View commit details
    Browse the repository at this point in the history
  3. Prevent show a hidden status bar when opening modals, fix #7474

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    Closes the old #7474, keeping the status bar hidden when displaying a modal
    or dialog, this is accomplished by verifying if the activity status bar is hidden or not.
    
    Added a test to [RNTester](https://github.com/facebook/react-native/tree/master/RNTester), so it can be tested from there:
    
    1. Run [RNTester](https://github.com/facebook/react-native/tree/master/RNTester) project
    2. Go to <StatusBar> tests
    3. Set `hidden: true` in the *StatusBar hidden* samples
    4. Set `modal visible: true` and see the result
    
    Here are some gifs to help see the results:
    ![fail](https://user-images.githubusercontent.com/1649955/36345378-f443ad7e-1407-11e8-850d-d6317fb34da4.gif)
    ![success](https://user-images.githubusercontent.com/1649955/36345392-1c590b56-1408-11e8-9244-a2e828f579ab.gif)
    
    none
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [ GENERAL  ]   [ BUGFIX      ]   [ [StatusBar] - Prevent show a hidden status bar when opening modals
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    [ GENERAL  ]   [ BUGFIX      ]   [StatusBar] - Prevent show a hidden status bar when opening modals
    Closes #18004
    
    Differential Revision: D7307564
    
    Pulled By: hramos
    
    fbshipit-source-id: 47e481ead78204865811ddf2ef3d27da77ad8b8f
    t4deu authored and facebook-github-bot committed Mar 16, 2018
    3 Configuration menu
    Copy the full SHA
    076b1ce View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2018

  1. Explicitly set path to yarn

    Summary:
    Due to issues with Circle's Docker images ([link](https://twitter.com/circleci/status/974694807091073024)), jobs are failing with an error "yarn not found".
    
    Test Plan
    Run on Circle
    
    Release Notes
    [GENERAL][MINOR][.circleci] - Fix Circle issue
    Closes #18419
    
    Differential Revision: D7312052
    
    Pulled By: hramos
    
    fbshipit-source-id: 2768b9c69046a2f80518430024d3e7afbbd7de65
    hramos authored and facebook-github-bot committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    6f6084d View commit details
    Browse the repository at this point in the history
  2. Simplify templates

    Summary:
    Trivial PR.
    
    [GENERAL][MINOR][.circleci/, bots/] - Simplify GitHub templates
    Closes #18418
    
    Differential Revision: D7311869
    
    Pulled By: hramos
    
    fbshipit-source-id: b87599c53938406d585d711492aacbdde2fcb02a
    hramos authored and facebook-github-bot committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    6426735 View commit details
    Browse the repository at this point in the history
  3. Add a way to dismiss PopupMenu elements

    Summary:
    In native Android apps, like the YouTube app, context menus are closed when the device orientation changes.
    
    In React Native apps instead, when having a [PopupMenu](https://developer.android.com/reference/android/widget/PopupMenu.html) open and rotating the device, the PopupMenu is not dismissed and appears in a wrong position on the screen.
    
    This PR exposes a `dismissPopupMenu` method to allow the application to dismiss any open PopupMenu:
    
    ```(javascript)
    UIManager.dismissPopupMenu()
    ```
    Closes #15636
    
    Differential Revision: D6837663
    
    Pulled By: hramos
    
    fbshipit-source-id: 7b0f4f04341129ad45c703a50897e17d93651974
    miguelsm authored and facebook-github-bot committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    353c070 View commit details
    Browse the repository at this point in the history
  4. Enable obfuscation in ProGuard rules by default

    Summary:
    This PR enables obfuscation in ProGuard by default when creating a new project, and documents how developers can turn obfuscation off if they desire.
    
    The ProGuard phase is currently disabled by default. If a developer wanted to enable ProGuard, the first thing they would see is the following line in their build.gradle file: `def enableProguardInReleaseBuilds = false`
    
    It's really easy to assume that enabling this flag will setup code shrinking and obfuscation, as this is the default behaviour for a completely native Android Studio project, or when running ProGuard from the command line directly.
    
    However, the generated ProGuard rules override the default behaviour. Without visually inspecting the rules file, searching for a mapping file, or analyzing the Dex file classes, this isn't immediately obvious, as the APK will be smaller, and gradle will show the Proguard task as completing.
    
    Personally I find this confusing and really wasn't expecting for obfuscation to be disabled - most Android Error Reporting services allow deobfuscation of stacktraces via mapping files.
    
    1. Create a new project using `react-native init MyProject`
    2. Observe that `-dontobfuscate` is commented out
    
    [ANDROID] [MINOR] [ProGuard] - Enables obfuscation by default in newly created projects
    Closes #17754
    
    Differential Revision: D7251680
    
    Pulled By: hramos
    
    fbshipit-source-id: cf9ca7753640643377a51daa4fa9065516197340
    fractalwrench authored and facebook-github-bot committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    c2fd54f View commit details
    Browse the repository at this point in the history
  5. Fix Android job

    Summary:
    Yarn is not used in the Android step, not directly
    
    Test Plan
    Circle
    
    Release Notes
    
    [GENERAL][MINOR][.circleci] - Fix Android CI job
    Closes #18421
    
    Differential Revision: D7314158
    
    Pulled By: hramos
    
    fbshipit-source-id: ad40346b6a1c1f63a1b952fd05cbe9398d9c59a1
    hramos authored and facebook-github-bot committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    6f588b3 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2018

  1. Add inverted prop in SectionListExample

    Summary:
    This PR adds an option to pass`inverted` prop to SectionListExample in RNTester. FlatListExample already has this option but it's not available in SectionListExample.
    
    Run RNTester app on device or simulator and select SectionListExample. Depending on switching `inverted` option, you can see either inverted list or not.
    
    [GENERAL][ENHANCEMENT][RNTeater] - Add inverted prop to SectionListExample
    Closes #18370
    
    Differential Revision: D7317168
    
    Pulled By: hramos
    
    fbshipit-source-id: c6c212c705e686281f23954775cc3465cce3c8df
    kyo504 authored and facebook-github-bot committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    541485c View commit details
    Browse the repository at this point in the history
  2. iOS OSS: fixed RNTester - missing RCTInputAccessoryShadowView.* in .x…

    …codeproj
    
    Reviewed By: yungsters
    
    Differential Revision: D7317380
    
    fbshipit-source-id: 0a40d62c70cd3c3a875e5a418f4b77fecb0417b1
    fkgozali authored and facebook-github-bot committed Mar 18, 2018
    Configuration menu
    Copy the full SHA
    1c53471 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2018

  1. Sealable: fixed semantic; atomic type for the flag variable

    Summary:
    * Fixed semantic: all kinds of derivative instances lose `sealed` flag (which is expected);
     * Using atomic<bool> for `sealed_` ivar.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7230674
    
    fbshipit-source-id: abe786610c20a45a0fabb9068120e24adeeeac7f
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    d16772a View commit details
    Browse the repository at this point in the history
  2. Abstract classes for ShadowNode and Props

    Summary: Foundation clases for Fabric designed to be "const-first".
    
    Reviewed By: fkgozali
    
    Differential Revision: D7230672
    
    fbshipit-source-id: 433acd35a7958d5d577358b0a306923f970e573f
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    c623455 View commit details
    Browse the repository at this point in the history
  3. fabric/graphics module: all about graphics

    Summary: `fabric/graphics` provides graphics primitives; the implementation should be platform-specific eventually.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7230675
    
    fbshipit-source-id: ff05d2673072fad5ee6f331f0155561969e1a8b6
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    608d1fb View commit details
    Browse the repository at this point in the history
  4. Introducing ComponentDescriptor

    Summary:
    Abstract class and default template implementation.
    `ComponentDescriptor`s define basic logic of managing (creation, cloning, applying props) ShadowNode of particular type.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7230671
    
    fbshipit-source-id: c32636f4db0716b55a1637f61c4f1872fc52cea7
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    840638c View commit details
    Browse the repository at this point in the history
  5. Introducing LayoutableShadowNode

    Summary: LayoutableShadowNode defines a unified interface (and set of primitives) essential for laying out shadow nodes.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7230668
    
    fbshipit-source-id: d8c1772d4c3bd1f87c41f7240a39aecebf3696ae
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    811d5bf View commit details
    Browse the repository at this point in the history
  6. Introducing ConcreteShadowNode

    Summary: ConcreteShadowNode defines a template which connects typed Props and typed ShadowNode.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7230667
    
    fbshipit-source-id: be28314d6846d69960e921da852f01232951f965
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    6b0960c View commit details
    Browse the repository at this point in the history
  7. fabric/view module

    Summary: Defines `<View>`: Yoga-powered, Accessible and styleable component.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7230673
    
    fbshipit-source-id: 08a1d8626c0b41260fafdca938d4fe9489b1b793
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    965e60b View commit details
    Browse the repository at this point in the history
  8. fabric/uimanager module

    Summary: `fabric/uimanager` implements FabricUIModule.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7230669
    
    fbshipit-source-id: db6228021352598feac7854b5871d9d6c5c85119
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    c2ad59a View commit details
    Browse the repository at this point in the history
  9. Switching to the new FabricUIManager and all new shadow tree infra

    Reviewed By: fkgozali
    
    Differential Revision: D7230670
    
    fbshipit-source-id: bca7d2859b87931c0d15406782b7d689de1d8c36
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    4cda0df View commit details
    Browse the repository at this point in the history
  10. DebugStringConvertibleOptions: Formating

    Summary:
    DebugStringConvertibleOptions allows pretty-format debug strings.
    https://pxl.cl/ch0m
    
    Reviewed By: fkgozali
    
    Differential Revision: D7312622
    
    fbshipit-source-id: 0ed62520bbc521790bedf5a6d18c796b42f85658
    shergin authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    378da73 View commit details
    Browse the repository at this point in the history
  11. Added nestedScrollEnabled prop to scroll view for android

    Summary:
    Nested scrolling in scrollViews, listViews and flatLists are enabled on iOS by default, but needs to be enabled manually on Android. This PR introduces a `nestedScrollEnabled` property to ScrollViews to support nested scrolling on Android 21 and above.
    
    Enabling nested scroll will resolve issues with coordinator layout in android and required to support a collapsing toolbar.
    
    Tested on the test app. We are also using this property in our app currently to support scrolling behaviour required by coordinator layouts.
    
    [ANDROID] [ENHANCEMENT] [ScrollView] - Added a prop to enable nested scrolling
    Closes #18299
    
    Reviewed By: sahrens
    
    Differential Revision: D7256604
    
    Pulled By: mdvacca
    
    fbshipit-source-id: fb8b7f1b5bed39837a2066db7f2a8798d52a3fd6
    tuncaulubilge authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    263d04d View commit details
    Browse the repository at this point in the history
  12. iOS C++: Add ICxxExceptionManager to access RCTExceptionsManager nati…

    …ve module
    
    Summary: It is sometimes useful to report soft/fatal errors from C++ (native) to the same RCTExceptionsManager that is already handling JS exceptions. `ICxxExceptionManager` is an approach to provide such access, which impl provided for ObjC++.
    
    Reviewed By: shergin
    
    Differential Revision: D7224944
    
    fbshipit-source-id: 8c607226b67851d46f4c787f5b6e6c8cb6a1afea
    fkgozali authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    f42b589 View commit details
    Browse the repository at this point in the history
  13. iOS JSC: Use ICxxExceptionManager to report exception

    Reviewed By: shergin
    
    Differential Revision: D7224945
    
    fbshipit-source-id: 8aadbc04c700d6e965be311085d95332571b00b0
    fkgozali authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    53a0470 View commit details
    Browse the repository at this point in the history
  14. Wrong height when TextInput has an empty string

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    The caret/cursor did not appear when the TextInput was empty. Found that the cause was because the frame of the TextInput had an height of 0
    
    Just fill and clear a TextInput and the caret/cursor will always appear there.
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    [IOS] [BUGFIX] [TextInput] - This was causing the cursor/caret to not appear since the size of the frame had an height of 0.
    Closes #18355
    
    Differential Revision: D7319723
    
    Pulled By: shergin
    
    fbshipit-source-id: b0249ab5493b6ac310d1898ff20c0bad78cf82c9
    reyalpsirc authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    def789c View commit details
    Browse the repository at this point in the history
  15. Make access to SourceCode Native Extension lazy

    Reviewed By: fromcelticpark
    
    Differential Revision: D6987478
    
    fbshipit-source-id: 6d600131239be34480bd1c5a0ca84b4fab360386
    Dmitry Zakharov authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    c732429 View commit details
    Browse the repository at this point in the history
  16. Added console warning to InputAccessoryView

    Reviewed By: mmmulani
    
    Differential Revision: D7305377
    
    fbshipit-source-id: 4a9888b5592014956c3aa44baffb2ac3a0329b88
    Peter Argany authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    15bc6d1 View commit details
    Browse the repository at this point in the history
  17. Create a new instrumentation test that does not enforce rendering a s…

    …ingle RN component
    
    Reviewed By: mdvacca
    
    Differential Revision: D7293466
    
    fbshipit-source-id: 8ddaf9a52f4d6324e8b37f3c6fd4d3e0db6f3a12
    ayc1 authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    12c208c View commit details
    Browse the repository at this point in the history
  18. Properly tear down the reachabilityRef in RCTNetInfo

    Summary: The pull request that added this (#17397) simply forgot to remove the callback, which would cause crashes if the RCTNetInfo module was ever deallocated. While that usually doesn't happen in apps, it can if the user logs out and you need to wipe all the RCT modules (to remove user data, for instance).
    
    Reviewed By: PeteTheHeat
    
    Differential Revision: D7322999
    
    fbshipit-source-id: e49ec7311b39920f7b7743a5854c0dda1dbccc73
    Mehdi Mulani authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    9d45de6 View commit details
    Browse the repository at this point in the history
  19. Remove @xplat cell syntax in open source, part 2

    Differential Revision: D7325421
    
    fbshipit-source-id: 95e3ee0a6c41292b1d2e1fc8b0691861ad69468f
    hramos authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    41db09d View commit details
    Browse the repository at this point in the history
  20. Fixed <TextInput> bug with autocapitalization

    Reviewed By: shergin
    
    Differential Revision: D7304936
    
    fbshipit-source-id: ef587db89b64e7111dfdeb049c3a1a334c15430b
    Peter Argany authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    ff70ecf View commit details
    Browse the repository at this point in the history
  21. Fix clang-6 strictness surrounding virtual destructors

    Reviewed By: smeenai
    
    Differential Revision: D7326765
    
    fbshipit-source-id: 9df477dfa89812e05e79b5e6d510bcbbc793381c
    Naris Siamwalla authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    12535ae View commit details
    Browse the repository at this point in the history
  22. RCTObjcExecutor: fix initializer-list initialization order build warn…

    …ing.
    
    Summary:
    Fixes: #18384
    
    Previously line 42 had a warning of: `Field 'm_jsThread' will be initialized after field 'm_delegate'`
    
    This appears to be because the private member fields are declared in a different order than the initializer-list was told to initialize things.
    
    I chose to re-order the initializer list because that fixes the warning by matching the code structure to what the compiler was telling us it was going to do.
    
    An alternate fix would be to change the order of the member variables declared in the `private:` section to match the coded order in the initializer list. This might be the right move if the initializer list had the correct intent, but this would be a breaking change from a behavior perspective, so I'd need somebody with more knowledge to suggest this is the right move.
    
    A. Examine line to see the warning is gone.
    B. Get a C++ guru to figure out the intent of this file and see if this actually exposed a bug that recommends we go with the alternate fix suggested above.
    
    [IOS][MINOR][React/CxxBridge/] - Build warning fix
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #18385
    
    Differential Revision: D7328272
    
    Pulled By: mhorowitz
    
    fbshipit-source-id: 59d7ace6222c4609ac7d023f97e522e85e02a9db
    fbartho authored and facebook-github-bot committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    75a7359 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2018

  1. Fabric: Equality operators for geometry types

    Summary: We will need this soon.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7330338
    
    fbshipit-source-id: 30aeadc182893e86c6a039c74d245f9b56624151
    shergin authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    aaaa946 View commit details
    Browse the repository at this point in the history
  2. Fabric: Proper return value of `LayoutableShadowNode::setLayoutMetric…

    …s()`
    
    Summary: `LayoutableShadowNode::setLayoutMetrics()` must return `false` is nothing was changes.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7330334
    
    fbshipit-source-id: 700d50b0047919fa2b919acfa72825f100cd496f
    shergin authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    a5a3456 View commit details
    Browse the repository at this point in the history
  3. Fabric: Complete implementation of layoutMetricsFromYogaNode

    Summary: That was simply incomplete.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7330336
    
    fbshipit-source-id: c495c7f61d8e551fa963bfa6cc0408343eb8439b
    shergin authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    ff288b7 View commit details
    Browse the repository at this point in the history
  4. Fabric: Improved YogaLayoutableShadowNode printing

    Summary: `LTR` is actually a default value for `direction` here, because an `inherit` value makes no sense for YGLayout (because it's *computed* value by definition).
    
    Reviewed By: fkgozali
    
    Differential Revision: D7330335
    
    fbshipit-source-id: b3c7736c104689f2296e150f0cf57d622483d537
    shergin authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    39383d1 View commit details
    Browse the repository at this point in the history
  5. Fabric: Introducting ShadowNode.sourceNode, the node used in copy-c…

    …onstructor
    
    Summary: We will need this later in the diffing alogrithm.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7330337
    
    fbshipit-source-id: 3da44a62e4d5f30deed28b18a5779544153244f3
    shergin authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    b808bfd View commit details
    Browse the repository at this point in the history
  6. iOS: set the default measure size correctly for RCTSurfaceHostingView

    Summary: The RCTRootView default needs to be translated during init of RCTSurfaceHostingView correctly.
    
    Reviewed By: shergin
    
    Differential Revision: D7327918
    
    fbshipit-source-id: 67a2a42b554782b37a032cc0470d794554cc1e5a
    fkgozali authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    e2462e9 View commit details
    Browse the repository at this point in the history
  7. Disable YogaNode cloning in Android

    Reviewed By: achen1
    
    Differential Revision: D7313239
    
    fbshipit-source-id: ecf905a22e04a2115ab968fd29f7582301f0f3c9
    mdvacca authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    0930fef View commit details
    Browse the repository at this point in the history
  8. Change cloning mechanism for mutableCopyWithNewChildren method

    Reviewed By: achen1
    
    Differential Revision: D7239873
    
    fbshipit-source-id: d931e753c3a0b26d439eb450d62af93a672641f4
    mdvacca authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    b43afcd View commit details
    Browse the repository at this point in the history
  9. Extend ReactShadowNode in order to have a reference to the ReactShado…

    …wNode that was used to clone a node
    
    Reviewed By: achen1
    
    Differential Revision: D7289345
    
    fbshipit-source-id: 34bfba8aca43299a3a8929a0e3eb85721f736dd0
    mdvacca authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    3f84a0a View commit details
    Browse the repository at this point in the history
  10. Implement Fabric Reconciler

    Reviewed By: achen1
    
    Differential Revision: D7240208
    
    fbshipit-source-id: 236b76146c50fb7f357190b08f8a5bfcef7f6645
    mdvacca authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    7d3de10 View commit details
    Browse the repository at this point in the history
  11. Add logging to debug Fabric diffing algorithm

    Reviewed By: achen1
    
    Differential Revision: D7319185
    
    fbshipit-source-id: fe47c21db5e1415aebe806f0d74b1f65f667a397
    mdvacca authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    cc3d45d View commit details
    Browse the repository at this point in the history
  12. Fix removal of ReactShadowNode

    Reviewed By: achen1
    
    Differential Revision: D7323294
    
    fbshipit-source-id: 411aa1bcd93cc4f9df78f64ceb0c0d8c127bc3b0
    mdvacca authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    5347ecf View commit details
    Browse the repository at this point in the history
  13. Upgrade to Flow v0.68.0

    Reviewed By: gabelevi
    
    Differential Revision: D7310349
    
    fbshipit-source-id: 70d29815dd7912704aec8a015c970be3fafeeba3
    samwgoldman authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    0d924dd View commit details
    Browse the repository at this point in the history
  14. Use native as the source of truth to decide if a test should use Fabric

    Reviewed By: fkgozali
    
    Differential Revision: D7304221
    
    fbshipit-source-id: cdd7053e6ce6522474df261db5710e2d9c013be6
    ayc1 authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    785c8f7 View commit details
    Browse the repository at this point in the history
  15. Add debug logs to FabricUIManager

    Reviewed By: mdvacca
    
    Differential Revision: D7310879
    
    fbshipit-source-id: 3c874fd4dbd75dd865f7d94e7e31f538ef67eb66
    ayc1 authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    c49afb1 View commit details
    Browse the repository at this point in the history
  16. Add test for FabricText

    Reviewed By: mdvacca
    
    Differential Revision: D7326562
    
    fbshipit-source-id: e1229f84496e9181475979d757066e3796a24a3f
    ayc1 authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    f136ae1 View commit details
    Browse the repository at this point in the history
  17. Fix TextRenderingTestCase

    Reviewed By: mdvacca
    
    Differential Revision: D7330681
    
    fbshipit-source-id: 5dd2a60382d01fb841f16851a9b2027e2b08e748
    ayc1 authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    af42829 View commit details
    Browse the repository at this point in the history
  18. Use map instead of array

    Reviewed By: dcaspi
    
    Differential Revision: D7327839
    
    fbshipit-source-id: e48d2b9f34e337d14f9519eac16b6a15fa56deb5
    cwdick authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    aabd5d1 View commit details
    Browse the repository at this point in the history
  19. Depend on local version of babel-plugin-react-transform

    Reviewed By: jeanlauliac
    
    Differential Revision: D7319513
    
    fbshipit-source-id: 4945ec753087206cd01eca4ba9464672d5fb05ba
    Peter van der Zee authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    fa7c322 View commit details
    Browse the repository at this point in the history
  20. feat: Remove platform check in requireNativeComponent to support addi…

    …tional platforms
    
    Summary:
    Using platform checks can make it difficult to incorporate changes for other platforms (e.g. Windows).
     Using a check for the underlying function accomplishes the same goal without relying on an Android-specific check.  This change allows this JS file to be re-used instead of copied and modified.
    
    [X] Run Jest tests
    [X] Test in RNTester on simulators
    [X] Test in Playground
    
    No related PR's found :)
    
    [GENERAL] [ENHANCEMENT] [Libraries/ReactNative/requireFabricComponent.js] - Simplified check against UIManager to support additional platforms, removing Android-specific check
    Closes #18381
    
    Differential Revision: D7336214
    
    Pulled By: hramos
    
    fbshipit-source-id: e936f1fdcf36556c528115ee3f79197883d7b7d4
    jhampton authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    f6bcd73 View commit details
    Browse the repository at this point in the history
  21. Revert D7319513: Depend on local version of babel-plugin-react-transform

    Differential Revision:
    D7319513
    
    Original commit changeset: 4945ec753087
    
    fbshipit-source-id: 98de6a0fda19732c02ad780953497f9d9b451dea
    Naor Matania authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    ad6938c View commit details
    Browse the repository at this point in the history
  22. Deprecate postProcessModules config param

    Reviewed By: mjesun
    
    Differential Revision: D7320671
    
    fbshipit-source-id: 979108f0931f9ee0dd820025782137d4c726d19f
    rafeca authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    6f339b6 View commit details
    Browse the repository at this point in the history
  23. Add getRunModuleStatement config param to configure the require() sta…

    …tements
    
    Reviewed By: cpojer
    
    Differential Revision: D7334078
    
    fbshipit-source-id: c19340567c634e3173ee707e92389eaaa4e724e9
    rafeca authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    15f0a7b View commit details
    Browse the repository at this point in the history
  24. Drop fb{android|objc} prefixed keys for oss builds

    Reviewed By: hramos
    
    Differential Revision: D7329425
    
    fbshipit-source-id: 8a2e5936991f99b0d5112a6940856e8ee1d32a55
    Jonathan Kim authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    ddfcaf9 View commit details
    Browse the repository at this point in the history
  25. While linking plugin ask for params only once

    Summary:
    Resolve #18333
    
    CLI should ask users for params only once and waiting for response while linking plugin
    
    Ran the `link` commands for iOS and Android and confirmed that params requested only once.
    
    [CLI][FEATURE][local-cli/link/link.js] - Requesting link params only once for all platforms
    Closes #18349
    
    Differential Revision: D7342181
    
    Pulled By: hramos
    
    fbshipit-source-id: a10f0f7f2170f067d78b30e5a5221634b77da577
    Artem Egorov authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    ea92f47 View commit details
    Browse the repository at this point in the history
  26. moved ReactFabricInternals outside of shims

    Summary: Simply moving it out of shims to not confuse React project
    
    Reviewed By: bvaughn
    
    Differential Revision: D7341846
    
    fbshipit-source-id: b1a0cdb0caca977de744699521f42556699993a7
    fkgozali authored and facebook-github-bot committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    38fe8c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2018

  1. React sync for revisions ced176e...9d484ed

    Reviewed By: bvaughn
    
    Differential Revision: D7338640
    
    fbshipit-source-id: e2d75d2f1795fb3c37f193d15216951c707711d9
    hramos authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    3b36a6b View commit details
    Browse the repository at this point in the history
  2. Move TypeForStyleKey from StyleSheetTypes to StyleSheet

    Reviewed By: yungsters
    
    Differential Revision: D7281362
    
    fbshipit-source-id: 936d198e83dfbfc62449e82b5559a30bd57621c4
    elicwhite authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    f68e041 View commit details
    Browse the repository at this point in the history
  3. Move ViewStyle, TextStyle, ImageStyle from StyleSheetTypes to StyleSheet

    Reviewed By: yungsters
    
    Differential Revision: D7282491
    
    fbshipit-source-id: d6b54d0a2e1fe1816b6a856b1b0b1245a655320a
    elicwhite authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    a0388f4 View commit details
    Browse the repository at this point in the history
  4. Bump metro@0.31.0

    Reviewed By: mjesun
    
    Differential Revision: D7336904
    
    fbshipit-source-id: 2132c77d07e52a91f09b6f905bee4806aaf7d23e
    rafeca authored and facebook-github-bot committed Mar 21, 2018
    1 Configuration menu
    Copy the full SHA
    a3f1ca8 View commit details
    Browse the repository at this point in the history
  5. Add more debug logs to FabricReconciler

    Reviewed By: mdvacca
    
    Differential Revision: D7338946
    
    fbshipit-source-id: 839de31ca26a8e45d3bb3271d3ab5a4f53f639b0
    ayc1 authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    657c1a4 View commit details
    Browse the repository at this point in the history
  6. Depend on local version of babel-plugin-react-transform

    Reviewed By: arcanis
    
    Differential Revision: D7337432
    
    fbshipit-source-id: 3729359da0ccfd3161546ab3ea9331ad30fb6e8d
    Peter van der Zee authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    b961ac3 View commit details
    Browse the repository at this point in the history
  7. Removed unnecessary intrinsicContentSize implementation from `RCTSu…

    …rfaceHostingProxyRootView`
    
    Summary:
    The base class already implements `intrinsicContentSize` (and it's a bit more complicated that that).
    (Not sure if this change anything visible.)
    
    Reviewed By: fkgozali
    
    Differential Revision: D7343567
    
    fbshipit-source-id: 86f86715b0dacc3c2230289a13926f0520540089
    shergin authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    0594a10 View commit details
    Browse the repository at this point in the history
  8. Fixed race condition in RCTUIManager's mounting process

    Summary:
    See the comment in code.
    This picture also illustrates the problem: https://cl.ly/250z0D1B0c17.
    https://pxl.cl/ckBq
    
    Reviewed By: fkgozali
    
    Differential Revision: D7343566
    
    fbshipit-source-id: e45a691add5e43434dea8708be4b76ff18e52131
    shergin authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    909861f View commit details
    Browse the repository at this point in the history
  9. Fixed performance regression in ShadowViews layout process

    Summary:
    This fixes perf regression which was introduced by recent refactoring of the layout process.
    That is how it used to be:
    https://github.com/facebook/react-native/blob/114c258045ccca3a4433de206c7983b42d14c03b/React/Views/RCTShadowView.m#L160-L166
    Note: We have to resert this flag in indication that we already applied those changes and we don't need to traverse this subtree until it is changed again.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7343564
    
    fbshipit-source-id: ba7e00bc5fe4992d777eed20ba0d959fd8f6c037
    shergin authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    c194c18 View commit details
    Browse the repository at this point in the history
  10. Moving remaining Style types from StyleSheetTypes to StyleSheet

    Reviewed By: yungsters
    
    Differential Revision: D7282831
    
    fbshipit-source-id: ced44d79ad30b7abdda77a25b72493899c2108e4
    elicwhite authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    d50cefb View commit details
    Browse the repository at this point in the history
  11. Updates Yoga to handle being in a Xcode framework project

    Summary:
    Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726
    
    (Which should also get merged too please ❤️ )
    
    Set it manually in my own project and tested 👍
    
    Only facebook/yoga#726
    
    [IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.
    Closes #18492
    
    Differential Revision: D7355907
    
    Pulled By: hramos
    
    fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
    orta authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    cf036db View commit details
    Browse the repository at this point in the history
  12. Fix removal of virtual nodes in FabricReconciler

    Reviewed By: mdvacca
    
    Differential Revision: D7338949
    
    fbshipit-source-id: 31263c138689f9b3f59deb26851132df04b8a823
    ayc1 authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    c0d27de View commit details
    Browse the repository at this point in the history
  13. Pass-by-reference in YGNode::setStyle() ::setChildren() ::setLayout()

    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D7291096
    
    fbshipit-source-id: 7a4025831811d622050adbb5f86608855b94d68e
    Jonathan Dann authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    0b085a8 View commit details
    Browse the repository at this point in the history
  14. Pass some constructor argumetns by const-reference

    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D7291363
    
    fbshipit-source-id: 22e606d0b3fa1133d7e0334c8cf9f5f1f32fe64b
    Jonathan Dann authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    ed0ba1b View commit details
    Browse the repository at this point in the history
  15. Mark more member functions as const

    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D7291364
    
    fbshipit-source-id: 2e7d96cfe0345692ffa411bb21a80eb7a859880b
    Jonathan Dann authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    cb3103c View commit details
    Browse the repository at this point in the history
  16. fixed debug string formatting for structure

    Summary:
    Fixed minor issue:
    * use double spaces instead of a tab character for indentation
    * depth should increase by 1, not 2
    
    Reviewed By: shergin
    
    Differential Revision: D7332803
    
    fbshipit-source-id: 74fda2c7a4be4f509270d3074a7d71a3d4d32fe4
    fkgozali authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    f015900 View commit details
    Browse the repository at this point in the history
  17. Added sample iOS unit test setup for fabric/debug target

    Summary: basic setup for unit testing Fabric impl
    
    Reviewed By: hramos
    
    Differential Revision: D7359239
    
    fbshipit-source-id: ccaf36e775036f2fad4d8c882bce86bbbe06dd28
    fkgozali authored and facebook-github-bot committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    6ae38fe View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2018

  1. Fix OSS Android test failure

    Reviewed By: fkgozali, hramos
    
    Differential Revision: D7358801
    
    fbshipit-source-id: 6f7979489fd7f5c9f7d9e1d7461121b7ff9f3ab0
    Jonathan Kim authored and facebook-github-bot committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    96daf67 View commit details
    Browse the repository at this point in the history
  2. Set measure function after YogaNode has been copied

    Reviewed By: mdvacca
    
    Differential Revision: D7338948
    
    fbshipit-source-id: e805169e162a47d0c7c775a3decbe9013c27c0e4
    ayc1 authored and facebook-github-bot committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    47910f0 View commit details
    Browse the repository at this point in the history
  3. Update fresco to v1.8.1

    Summary:
    <!--
      Required: Write your motivation here.
      If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
    -->
    The current version of fresco in use is [v1.3.0](https://github.com/facebook/fresco/releases/tag/v1.3.0) from April 2017. There has been a lot of [improvements](https://github.com/facebook/fresco/releases) since then.
    
    Fresco also depends on OkHttp 3.8.0 and soloader 0.3.0 so I have updated these too. Let me know if there's any reason either of these shouldn't be updated, however this will prevent Fresco from being updated.
    
    The latest version of OkHttp is 3.10.0, but I have kept it as low as possible to allow developers to choose the version.
    
    <!--
      Required: Write your test plan here. If you changed any code, please provide us with
      clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
    -->
    Test with local build.
    Check CI passes.
    
    <!--
      Does this PR require a documentation change?
      Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
    -->
    
    <!--
      Required.
      Help reviewers and the release process by writing your own release notes. See below for an example.
    -->
    
    [ANDROID] [ENHANCEMENT] [Fresco/OkHttp/SoLoader] - Updates Fresco to 1.8.1, OkHttp to 3.8.0, & SoLoader to 0.3.0
    
    cc foghina
    
    <!--
      **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
        CATEGORY
      [----------]      TYPE
      [ CLI      ] [-------------]    LOCATION
      [ DOCS     ] [ BREAKING    ] [-------------]
      [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
      [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
      [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
      [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
      [----------] [-------------] [-------------]   |-----------|
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #18496
    
    Differential Revision: D7361161
    
    Pulled By: foghina
    
    fbshipit-source-id: 6d2c5afb94ce5ff8e621188c2ac60f1ca4b787a6
    AndrewJack authored and facebook-github-bot committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    8e065ba View commit details
    Browse the repository at this point in the history
  4. Add fresco proguard rules

    Summary:
    <!--
      Required: Write your motivation here.
      If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
    -->
    Adds proguard rules, which I missed off from the #18496 PR.
    
    I've added the proguard rules as suggested in http://frescolib.org/docs/shipping.html, with the duplicates & unused libraries removed.
    
    <!--
      Required: Write your test plan here. If you changed any code, please provide us with
      clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
    -->
    CI passes.
    Build example project with proguard turned on.
    
    <!--
      Does this PR require a documentation change?
      Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
    -->
    
    <!--
      Required.
      Help reviewers and the release process by writing your own release notes. See below for an example.
    -->
    
    [ANDROID] [BREAKING] [proguard] - Update Proguard config in template. If upgrading make sure you update your project's proguard file.
    
    <!--
      **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
        CATEGORY
      [----------]      TYPE
      [ CLI      ] [-------------]    LOCATION
      [ DOCS     ] [ BREAKING    ] [-------------]
      [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
      [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
      [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
      [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
      [----------] [-------------] [-------------]   |-----------|
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    
    cc foghina & hramos
    Closes #18499
    
    Differential Revision: D7366113
    
    Pulled By: foghina
    
    fbshipit-source-id: 20864c34976bc3930d9fdcc9428f40f7a8d7a9b8
    AndrewJack authored and facebook-github-bot committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    ff1444e View commit details
    Browse the repository at this point in the history
  5. fixed contacts for the test target

    Reviewed By: mdvacca
    
    Differential Revision: D7366977
    
    fbshipit-source-id: 93341f8964da71a7e23049fc5d2324a0da376746
    fkgozali authored and facebook-github-bot committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    10c95a2 View commit details
    Browse the repository at this point in the history
  6. fix ReadableNativeMap.toHashMap() for nested maps and arrays

    Summary:
    <!--
      Required: Write your motivation here.
      If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
    -->
    
    Commit 7891805 broke the previous behavior of `ReadableNativeMap.toHashMap()` for nested maps and arrays. Previously, all nested `ReadableNativeMap`s and `ReadableNativeArray`s were recursively converted to `HashMap`s and `ArrayList`s, but this is lost when only `getLocalMap()` is returned.
    
    <!--
      Required: Write your test plan here. If you changed any code, please provide us with
      clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
    -->
    
    Call `ReadableNativeMap.toHashMap()` on a map with values of type `ReadableNativeMap` and `ReadableNativeArray`. Verify the returned hash map has these converted to `HashMap` and `ArrayList`, respectively.
    
    <!--
      Does this PR require a documentation change?
      Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
    -->
    
    <!--
      Required.
      Help reviewers and the release process by writing your own release notes. See below for an example.
    -->
    
    [ANDROID] [BUGFIX] [ReadableNativeMap] - Fix toHashMap() for nested maps and arrays
    
    <!--
      **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
        CATEGORY
      [----------]      TYPE
      [ CLI      ] [-------------]    LOCATION
      [ DOCS     ] [ BREAKING    ] [-------------]
      [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
      [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
      [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
      [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
      [----------] [-------------] [-------------]   |-----------|
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #18455
    
    Reviewed By: kathryngray
    
    Differential Revision: D7347344
    
    Pulled By: mdvacca
    
    fbshipit-source-id: af2bca9dec6c0cb8a7da099b6757434fcc3ac785
    esamelson authored and facebook-github-bot committed Mar 22, 2018
    5 Configuration menu
    Copy the full SHA
    15fa225 View commit details
    Browse the repository at this point in the history
  7. Mark global variable as extern "C"

    Reviewed By: mnovakovic
    
    Differential Revision: D7369214
    
    fbshipit-source-id: 710d817b4bf74b5ca0621645dd5c005b778d7171
    smeenai authored and facebook-github-bot committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    cf642c9 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2018

  1. Revert D7343566: [RN] Fixed race condition in RCTUIManager's mounting…

    … process
    
    Differential Revision:
    D7343566
    
    Original commit changeset: e45a691add5e
    
    fbshipit-source-id: 08ec04538c07dc3cd630240da8bb42a932a23b6f
    shergin authored and facebook-github-bot committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    0376baf View commit details
    Browse the repository at this point in the history
  2. Assert root node isn't null in createView

    Reviewed By: mdvacca
    
    Differential Revision: D7374406
    
    fbshipit-source-id: 534e58e7867a9fa8e395abd587e2c808c9c7843d
    ayc1 authored and facebook-github-bot committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    046d4ce View commit details
    Browse the repository at this point in the history
  3. Pass fabric flag from native to JS

    Reviewed By: mdvacca
    
    Differential Revision: D7373722
    
    fbshipit-source-id: 3cd051f38677900693f3da797effa11f9161df37
    ayc1 authored and facebook-github-bot committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    cbb7c7c View commit details
    Browse the repository at this point in the history
  4. Pass invertStickyHeaders to ScrollView

    Summary:
    invertStickyHeaders was being set to "this.props.inverted" -- it should just inherit from the props of VirtualizedList instead, per discussion in #18471
    
    Fixes #18471
    
    Pass "invertStickyHeaders: false" to a SectionList (or FlatList), and expect that your sticky headers stick to the bottom of the ScrollView, instead of the top.
    
    none
    
    [ANDROID] [BUGFIX] [SectionList] - invertStickyHeaders can now be set from SectionList or FlatList.
    Closes #18524
    
    Differential Revision: D7386163
    
    Pulled By: hramos
    
    fbshipit-source-id: 3b66dfca280e657303f69f98c5a8bc0df033f9f7
    dannycochran authored and facebook-github-bot committed Mar 23, 2018
    Configuration menu
    Copy the full SHA
    dd479a9 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2018

  1. iOS: added fabric/core primitives tests

    Summary: basic tests for fabric core primitives
    
    Reviewed By: shergin
    
    Differential Revision: D7373952
    
    fbshipit-source-id: e2d9b3c15716c16b1aab698883817e670dcb7a57
    fkgozali authored and facebook-github-bot committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    8c0070c View commit details
    Browse the repository at this point in the history
  2. iOS: added fabric/core ShadowNode tests

    Summary: basic tests for shadow nodes and props for fabric
    
    Reviewed By: shergin
    
    Differential Revision: D7377867
    
    fbshipit-source-id: dc8e5bb369aeb32b4790fd8b56f333376bc1578c
    fkgozali authored and facebook-github-bot committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    e254474 View commit details
    Browse the repository at this point in the history
  3. iOS: added fabric/core ComponentDescriptor tests

    Summary: Basic test for ComponentDescriptor mechanism.
    
    Reviewed By: shergin
    
    Differential Revision: D7388297
    
    fbshipit-source-id: 3b0c625656e31df03d71a2e036388621a5e2e21d
    fkgozali authored and facebook-github-bot committed Mar 24, 2018
    Configuration menu
    Copy the full SHA
    408a5f2 View commit details
    Browse the repository at this point in the history
  4. iOS: added placeholder test setup for fabric graphics/uimanager/view …

    …targets
    
    Reviewed By: shergin
    
    Differential Revision: D7390366
    
    fbshipit-source-id: d49fcc335fc03d52402676341f1da24177c6084b
    fkgozali authored and facebook-github-bot committed Mar 24, 2018
    4 Configuration menu
    Copy the full SHA
    1acef45 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2018

  1. use correct delegate queue in RCTRSWebSocket

    Summary:
    This commit makes the websocket's delegate dispatch queue use `RCTWebSocketModule`'s method queue.
    
    This fixes a bug where didReceiveMessage was called on the wrong queue, which is especially harmful if the websocket has a contentHandler expects to be running on the RCTWebSocketModule's method queue.
    
    This also fixes the race condition where `_contentHandlers` and `_sockets` can be mutated from the main dispatch queue (the default in `RCTRSWebSocket`) and `RCTWebSocketModule`'s method queue.
    
    Websockets still work, and hopefully crash less now.
    
    - [iOS][BUGFIX][WebSocket] fix crashes caused by a race condition in websocket delegates.
    Closes #18530
    
    Differential Revision: D7394298
    
    Pulled By: hramos
    
    fbshipit-source-id: 230466ccb47ea532ced15cd7603256a19077b32b
    jhgg authored and facebook-github-bot committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    228f5c8 View commit details
    Browse the repository at this point in the history
  2. Add YGNodeSetChildren(), YGNodeTraversePreOrder()

    Reviewed By: Woody17
    
    Differential Revision: D7360203
    
    fbshipit-source-id: 32df8e1213ead03bc0a026ec4bf453bc799bb9ce
    Jonathan Dann authored and facebook-github-bot committed Mar 25, 2018
    Configuration menu
    Copy the full SHA
    2cc75f7 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2018

  1. Correct AnimatedValueXY URL

    Summary:
    Correct URL
    Closes #18556
    
    Differential Revision: D7396357
    
    Pulled By: mdvacca
    
    fbshipit-source-id: f8ff6c9b037fe733cf3be8d1b889d1dcd9c94afb
    gusgard authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    8b9b3f6 View commit details
    Browse the repository at this point in the history
  2. Prevents android crash due to unsupported ellipsize mode

    Summary:
    Fixes #18474
    
    This allows use clip as ellipsize mode for truncated text on android
    
    Added a test to RNTester, so it can be tested from there:
    1. Run RNTester project
    2. Navigate to `<Text>` tests
    3. Scroll down to "Ellipsize mode" examples
    4. Check the default behavior being applied when the value is set to "clip"
    
    <!--
      Required.
      Help reviewers and the release process by writing your own release notes. See below for an example.
    -->
    
    [ANDROID] [BUGFIX] [Text] - Prevents android crash due to unsupported "clip" ellipsize mode
    
    <!--
      **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
        CATEGORY
      [----------]      TYPE
      [ CLI      ] [-------------]    LOCATION
      [ DOCS     ] [ BREAKING    ] [-------------]
      [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
      [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
      [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
      [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
      [----------] [-------------] [-------------]   |-----------|
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    Closes #18540
    
    Differential Revision: D7396379
    
    Pulled By: mdvacca
    
    fbshipit-source-id: 6c4b223731143c5081b3d12a3c740d1e375bd586
    t4deu authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    85e33aa View commit details
    Browse the repository at this point in the history
  3. Android: include error types in getCurrentPosition error

    Summary:
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    Help us understand your motivation by explaining why you decided to make this change.
    
    Include geolocation error types in error, and provide feature parity with iOS.
    
    If error occurs when you call getCurrentPosition, then error object includes PERMISSION_DENIED, POSITION_UNAVAILABLE, TIMEOUT keys with error codes. It should be used to compare with error.code value.
    
    This is minor fix that provides feature parity with iOS.
    Closes #18533
    
    Differential Revision: D7396586
    
    Pulled By: mdvacca
    
    fbshipit-source-id: bd698b80a3d075456738a3d4e48b572ae819ee3d
    dulmandakh authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    226bff3 View commit details
    Browse the repository at this point in the history
  4. Use afterEvaluate to make gradle bundle task work with configureondemand

    Summary:
    The js bundle task does not run when `org.gradle.configureondemand` is set to true. This uses `afterEvaluate` instead of `gradle.projectsEvaluated` which is executed properly.
    
    Add `org.gradle.configureondemand=true`, run RNTester in release mode and make sure the bundle task is run.
    
    [ANDROID] [BUGFIX] [LOCATION] - Fix release bundle task when org.gradle.configureondemand=true
    Closes #18557
    
    Differential Revision: D7396744
    
    Pulled By: mdvacca
    
    fbshipit-source-id: 9ea134cb49e8a087cec16f82b990cd19af76785a
    janicduplessis authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    ca20fcd View commit details
    Browse the repository at this point in the history
  5. Fabric: Source shadow node is now stored as a weak pointer

    Summary:
    We use shource nodes only in the diffing alogorithm. It implies that we have strong pointers to those nodes in trees we compare against.
    Using weak_ptr's allows to avoid memory leaks.
    
    Reviewed By: mdvacca
    
    Differential Revision: D7376348
    
    fbshipit-source-id: 34e5f58f18a00475f6bcdfbea3996b41c84dff62
    shergin authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    53782ea View commit details
    Browse the repository at this point in the history
  6. Fabric: Removed unused copy constructor YogaLayoutableShadowNode()

    Summary: Trivial. We don't use it, and it shouldn't be exist by desing.
    
    Reviewed By: mdvacca
    
    Differential Revision: D7376351
    
    fbshipit-source-id: 22f03af2b3596c274a22bab1fab6d8af854a7374
    shergin authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    1bb6db3 View commit details
    Browse the repository at this point in the history
  7. Fabric: Fixed lost YogaNode's context in YogaLayoutableShadowNode

    Summary: We replace yogaNode with newly creaded (by Yoga) one. So, we have to set up context.
    
    Reviewed By: mdvacca
    
    Differential Revision: D7376345
    
    fbshipit-source-id: 7926a10e3f057fc385e7731c354827aeb8245760
    shergin authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    8f9212b View commit details
    Browse the repository at this point in the history
  8. Fabric: Implementing cloneAndReplaceChild() for ViewShadowNode

    Summary:
    First, LayoutableShadowNode::cloneAndReplaceChild() is now pure virtual. The default implementation was useless and confusing.
    Second, cloneAndReplaceChild() is now fully implemented for ViewShadowNode, so fancy Yoga Concurrent layout *should* work now.
    
    Reviewed By: mdvacca
    
    Differential Revision: D7376352
    
    fbshipit-source-id: 1199a37e64535c8592a2a5480e60139f61d02006
    shergin authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    ee0cc6b View commit details
    Browse the repository at this point in the history
  9. Fabric: Detailed looging in FabricUIManager

    Summary: Apparently, we need this.
    
    Reviewed By: mdvacca
    
    Differential Revision: D7376350
    
    fbshipit-source-id: 11d8ad54c7439e6c19a739ae1ac31af90d37166a
    shergin authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    5642514 View commit details
    Browse the repository at this point in the history
  10. Fabric: Fixed bug in node management in FabricUIManager

    Summary: Suddenly, `{}` means `{nullptr}`, not `empty list`.
    
    Reviewed By: mdvacca
    
    Differential Revision: D7376347
    
    fbshipit-source-id: 76f81eebe046ae592f0a42be7bcaa0587732c2a9
    shergin authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    53dfbcc View commit details
    Browse the repository at this point in the history
  11. Fabric: Introducing TreeMutationInstruction

    Summary: The Great Diffing algorithm is coming.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7376528
    
    fbshipit-source-id: bdfef69551980136cfd1717a11ae376d5eef126b
    shergin authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    6f17e3b View commit details
    Browse the repository at this point in the history
  12. Fabric: Deleted virtual default destructor from Props

    Summary: Trivial. We don't need this because we already have another virtual method.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7388964
    
    fbshipit-source-id: 5ea6eb33ece72796d8cde2cc4b12c1240447d22a
    shergin authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    cb7a7f3 View commit details
    Browse the repository at this point in the history
  13. Fabric: Collecting and printing ShadowNode's revision/generation

    Summary: It drastically simplifies reading logs.
    
    Reviewed By: fkgozali
    
    Differential Revision: D7388963
    
    fbshipit-source-id: 7849c803f295719918c20ddf8c082e5a5780116f
    shergin authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    99e9c6e View commit details
    Browse the repository at this point in the history
  14. Replace android_library with fb_android_library.

    Reviewed By: adamjernst
    
    Differential Revision: D7393004
    
    fbshipit-source-id: 99060333267dd6e81a41e9da52002e05152e7ccb
    ttsugriy authored and facebook-github-bot committed Mar 26, 2018
    Configuration menu
    Copy the full SHA
    2ff8b70 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2018

  1. Cache apt dependencies in test_android

    Summary: Closes #18576
    
    Differential Revision: D7415216
    
    Pulled By: hramos
    
    fbshipit-source-id: 9b7199fe5fb91a26ba0881e426a85395b2923f26
    hramos authored and facebook-github-bot committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    de1040f View commit details
    Browse the repository at this point in the history
  2. Fix blob response parsing for empty body on iOS

    Summary:
    We currently handle empty body poorly in the iOS blob implementation, this happens because of an early return that cause the blob response to not be processed by the blob module, resulting in an empty string as the body instead of a blob object. We also need to make sure to create an empty blob object when data is nil (empty body) as per the XMLHttpRequest spec. The Android implementation was already handling this properly.
    
    Fixes #18223
    
    Send a HEAD request
    
    ```js
    fetch('https://apipre.monkimun.com/whoami', {
      body: null,
      method: 'HEAD',
      headers: {
        Accept: 'application/json',
        'Content-Type': 'application/json',
      },
    })
    ```
    
    [IOS][BUGFIX][Blob] - Fix blob response parsing for empty body
    Closes #18547
    
    Differential Revision: D7415950
    
    Pulled By: hramos
    
    fbshipit-source-id: 56860532c6171255869f02a0960f55d155184a46
    janicduplessis authored and facebook-github-bot committed Mar 27, 2018
    4 Configuration menu
    Copy the full SHA
    f5207ba View commit details
    Browse the repository at this point in the history
  3. Add nativeLoggingHook to JSIExecutor

    Reviewed By: danzimm
    
    Differential Revision: D7203114
    
    fbshipit-source-id: 2f4640d19267dc4d75f6d6c8a7876c92abc22276
    dulinriley authored and facebook-github-bot committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    0150a0c View commit details
    Browse the repository at this point in the history
  4. Support multiple Fabric ReactRootView running at the same time

    Reviewed By: achen1
    
    Differential Revision: D7409472
    
    fbshipit-source-id: 9525e610f3bce49cae8d3c5e4427f99a48c32091
    mdvacca authored and facebook-github-bot committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    45abbf3 View commit details
    Browse the repository at this point in the history
  5. RN: Fix rounded Image Background (Android)

    Reviewed By: achen1
    
    Differential Revision: D7384113
    
    fbshipit-source-id: 348bdbc54a3e5923e012cb4cbc32da83145f04b4
    himabindugadupudi authored and facebook-github-bot committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    56971bb View commit details
    Browse the repository at this point in the history
  6. Upgrade Jest to 23.0.0-alpha.4

    Reviewed By: cpojer
    
    Differential Revision: D7397960
    
    fbshipit-source-id: 40984ff1ebfccdcba58f898abf8c52e2ed337221
    Miguel Jimenez Esun authored and facebook-github-bot committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    2ebd55f View commit details
    Browse the repository at this point in the history
  7. Cache C++ downloads

    Summary: Closes #18595
    
    Differential Revision: D7419532
    
    Pulled By: hramos
    
    fbshipit-source-id: 0b64763f91efea8300c4cde4703e8496dbda8c49
    hramos authored and facebook-github-bot committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    15b25d8 View commit details
    Browse the repository at this point in the history
  8. Native Animated - Support border radius

    Summary:
    Border radius already works properly with native animated but was not in the whitelisted props.
    
    Tested in an app that animating border radius with native animated actually works.
    
    [GENERAL] [ENHANCEMENT] [NativeAnimated] - Support border radius
    Closes #18574
    
    Differential Revision: D7415956
    
    Pulled By: hramos
    
    fbshipit-source-id: 6dd46bcdcb10c6a1956dd1f526212f33a4f44425
    janicduplessis authored and facebook-github-bot committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    e3941a1 View commit details
    Browse the repository at this point in the history
  9. Build yoga in OSS

    Differential Revision: D7417644
    
    fbshipit-source-id: 2641c1abc1083db83cbb304f8dcc7b781e329041
    hramos authored and facebook-github-bot committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    979c01e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. Bridged FBPullToRefresh to JS

    Reviewed By: shergin
    
    Differential Revision: D6875099
    
    fbshipit-source-id: 00bbad7569ff047a77f198ad2bf4d77fccbaa2e9
    Peter Argany authored and facebook-github-bot committed Mar 28, 2018
    6 Configuration menu
    Copy the full SHA
    f96d7ae View commit details
    Browse the repository at this point in the history
  2. Add custom RefreshControl support to VirtualizedList

    Reviewed By: TheSavior, mmmulani
    
    Differential Revision: D7388137
    
    fbshipit-source-id: 8a1448e5fc526b45773fe4a4f123a179d4a8bee9
    Peter Argany authored and facebook-github-bot committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    fd4bc72 View commit details
    Browse the repository at this point in the history
  3. Refactor RootShadowNodeRegistry to make it ThreadSafe

    Reviewed By: achen1
    
    Differential Revision: D7417965
    
    fbshipit-source-id: 90fa007242d2f00a315a4db25d2b6a0949e4b0d3
    mdvacca authored and facebook-github-bot committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    9c80506 View commit details
    Browse the repository at this point in the history
  4. Increase timeouts to 15, 10

    Reviewed By: javache
    
    Differential Revision: D7415558
    
    fbshipit-source-id: 76912d22b8e330845fcca3fa27aab6ed28256a94
    Miguel Jimenez Esun authored and facebook-github-bot committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    bd134ce View commit details
    Browse the repository at this point in the history
  5. Fix "function statements" in strict mode builds

    Reviewed By: davidaurelio
    
    Differential Revision: D7427473
    
    fbshipit-source-id: 130d0653c100c4a12b2a01aa3489b780febf6d8e
    Peter van der Zee authored and facebook-github-bot committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    88ba7eb View commit details
    Browse the repository at this point in the history
  6. Remove class-loading experiment for View Managers.

    Reviewed By: fkgozali
    
    Differential Revision: D7418876
    
    fbshipit-source-id: 52f8dce29a509233b9545a564c4f0d390fa81f13
    Dmitry Zakharov authored and facebook-github-bot committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    7cbb222 View commit details
    Browse the repository at this point in the history
  7. Collect unit test results in test_android job

    Summary:
    Explicitly generate a XML file with unit test results, and convert this file to JUnit format for display in Circle.
    
    Run in Circle: https://circleci.com/gh/hramos/react-native/1869
    
    ![screen shot 2018-03-28 at 12 07 15 pm](https://user-images.githubusercontent.com/165856/38050644-9712b6c6-3280-11e8-953c-a2eb722edf39.png)
    
    [INTERNAL] [MINOR] [.circleci] - Collect, process, and display Android unit test results on Circle
    Closes #18608
    
    Differential Revision: D7433151
    
    Pulled By: hramos
    
    fbshipit-source-id: 7c18b552d7790b238b4c2a720fb316dff8fd7ec3
    hramos authored and facebook-github-bot committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    b531612 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2018

  1. Refactor ReactShadowNode.SetRootNode() -> ReactShadowNode.setRootTag()

    Reviewed By: achen1
    
    Differential Revision: D7419566
    
    fbshipit-source-id: 6be790972e88b879fe690acd4f23d0caa27964a4
    mdvacca authored and facebook-github-bot committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    e88f128 View commit details
    Browse the repository at this point in the history
  2. Add JByteBuffer::rewind()

    Summary:
    Adds a `rewind()` method to `JByteBuffer`, which maps to `java.nio.Buffer#rewind()`.
    This is useful if a `ByteBuffer` is reused for calls between Java and C++.
    
    Differential Revision: D7435171
    
    fbshipit-source-id: 488131d6ad2d5abb1b86a5efabc2f39ba0ab16cd
    davidaurelio authored and facebook-github-bot committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    ff2260b View commit details
    Browse the repository at this point in the history
  3. Upgrade to Flow v0.69.0

    Reviewed By: panagosg7
    
    Differential Revision: D7437630
    
    fbshipit-source-id: db9627afed89049c07a121296fbd52e2bfbf39bf
    gabelevi authored and facebook-github-bot committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    f3ef227 View commit details
    Browse the repository at this point in the history
  4. Fix ByteBuffer.h

    Reviewed By: mjesun
    
    Differential Revision: D7443482
    
    fbshipit-source-id: aa765d54149fd81f785dbca7252342ed9b3c236d
    davidaurelio authored and facebook-github-bot committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    24b5721 View commit details
    Browse the repository at this point in the history
  5. Update okio

    Summary:
    Update okio dependency from 1.13.0 to 1.14.0.
    
    The interesting feature is `BufferedSource` extending `java.nio.ReadableByteChannel`, allowing to bridge with `java.nio` more easily and integrating with the latest fbjni additions.
    
    Reviewed By: emilsjolander
    
    Differential Revision: D7443269
    
    fbshipit-source-id: e397d7a0436e3fc59ade1f4357f30190ca7bbe35
    davidaurelio authored and facebook-github-bot committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    6be7b39 View commit details
    Browse the repository at this point in the history
  6. Update Android Docker images

    Summary:
    yarn docker-build-android-base
    yarn docker-build-android
    
    [INTERNAL] [MINOR] [ContainerShip] - Bump versions in Dockerfiles
    Closes #18597
    
    Differential Revision: D7433542
    
    Pulled By: hramos
    
    fbshipit-source-id: 5ec7496c84203a0ed20ef3875ac3d367914a0e80
    hramos authored and facebook-github-bot committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    9bdc310 View commit details
    Browse the repository at this point in the history
  7. Keep nativeIDs immutable in ReactFindViewUtil

    Reviewed By: mdvacca
    
    Differential Revision: D7430144
    
    fbshipit-source-id: c8e8242c1c3216258e4b8c27623160338e2578d8
    axe-fb authored and facebook-github-bot committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    ee0c69d View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2018

  1. OSS: add gradle wrapper helper to prepare offline gradle caches

    Summary:
    This is to help build offline module caches for gradle builds.
    
    allow-large-files
    
    Reviewed By: hramos
    
    Differential Revision: D7441450
    
    fbshipit-source-id: 37ceb070223f0de06720f5c104ecfce2ad6cedfd
    fkgozali authored and facebook-github-bot committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    1020ac9 View commit details
    Browse the repository at this point in the history
  2. Add JReadableByteChannel

    Summary:
    Adds `JReadableByteChannel`, which maps to `java.nio.ReadableByteChannel`.
    This class is useful to stream data from Java to C++ memory (in conjunction with `JByteBuffer`).
    
    Differential Revision: D7437312
    
    fbshipit-source-id: 4979706148f0e20228f0f52341fb340497c24a8b
    davidaurelio authored and facebook-github-bot committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    550339c View commit details
    Browse the repository at this point in the history
  3. Fabric: Proper Yoga node dirting in YogaLayoutableShadowNode

    Summary: Any change must be propagate upwards.
    
    Reviewed By: mdvacca
    
    Differential Revision: D7389058
    
    fbshipit-source-id: 09c74640d0e9607d2e17bdd31d7ce69df8565f72
    shergin authored and facebook-github-bot committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    1f27098 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2018

  1. Add an implementation of Animated.subtract

    Summary:
    Fixes #18451
    
    I've added another example to NativeAnimationsExample, which makes use of `Animated.substract()`, let me know if the example is not desired / doesn't add much value. Below two GIFs of the new method working on iOS and Android:
    
    <img width="320" src="https://user-images.githubusercontent.com/1437605/38154748-165cc5f8-3474-11e8-8b31-504444271896.gif" />
    <img width="320" src="https://user-images.githubusercontent.com/1437605/38154749-1679bff0-3474-11e8-80b1-b558d44e0494.gif" />
    
    <!--
      Required: Write your test plan here. If you changed any code, please provide us with
      clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
    -->
    
    facebook/react-native-website#276
    
    [GENERAL] [ENHANCEMENT] [Animated] - Implemented Animated.subtract
    Closes #18630
    
    Differential Revision: D7462867
    
    Pulled By: hramos
    
    fbshipit-source-id: 4cb0b8af08bb0c841e44ea2099889b8c02a22a4a
    avendiart authored and facebook-github-bot committed Mar 31, 2018
    Configuration menu
    Copy the full SHA
    4906f8d View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2018

  1. Avoid app crashing when a StackOverflowError is thrown when rendering…

    … deep RN view hierarcy
    
    Reviewed By: achen1
    
    Differential Revision: D7400906
    
    fbshipit-source-id: faaf701a88440f89390518f00e6a35f19e9203db
    mdvacca authored and facebook-github-bot committed Apr 1, 2018
    1 Configuration menu
    Copy the full SHA
    d58ba82 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2018

  1. Refactor cloning of YogaNode

    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D7339832
    
    fbshipit-source-id: 2de6f47ae7601ac083d3b9fbe10ffaf6307ae760
    mdvacca authored and facebook-github-bot committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    aff5a75 View commit details
    Browse the repository at this point in the history
  2. Rename YogaNode.parent -> YogaNode.owner

    Reviewed By: priteshrnandgaonkar
    
    Differential Revision: D7352778
    
    fbshipit-source-id: dcf1af5e72bfc3063b5c4bda197d7952a9194768
    mdvacca authored and facebook-github-bot committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    29ff30c View commit details
    Browse the repository at this point in the history
  3. Extend Yoga to be able clone Yoga Node with new children

    Reviewed By: emilsjolander
    
    Differential Revision: D7245421
    
    fbshipit-source-id: 72578c8261f29e4a12fc6c72a91f2f891cd58d48
    mdvacca authored and facebook-github-bot committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    5be4ff0 View commit details
    Browse the repository at this point in the history
  4. Re-enable Yoga cloning in React Shadow Node

    Reviewed By: achen1
    
    Differential Revision: D7435365
    
    fbshipit-source-id: 3e04b3252945112cf0c7206b0e6fb63535499eb9
    mdvacca authored and facebook-github-bot committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    8a99241 View commit details
    Browse the repository at this point in the history
  5. Add iOS 10 textContentType for TextInput

    Summary:
    Setting `textContentType` will provide the keyboard and system with semantic meaning for inputs. Should enable password/username autofill in apps running on iOS 11+ as demonstrated here: https://developer.apple.com/videos/play/wwdc2017/206/
    
    Also gives you the ability to disable autofill by setting `textContentType="none"`: https://stackoverflow.com/questions/48489479/react-native-disable-password-autofill-option-on-ios-keyboard
    
    Adding `textContentType` equal to `username` or `password`  should give you an autofill-bar over the keyboard which will let you fill in values from the device Keychain:
    
    ![image](https://user-images.githubusercontent.com/4932625/37848513-b2170490-2ed4-11e8-85bf-895823d4f98a.png)
    
    Setting the appropriate `textContentType` will fill in the correct value in the `TextInput`.
    I have only been able to get this to work on device, and not simulator.
    
    Usage:
    ```jsx
    <TextInput
        value={this.state.username}
        onChangeText={this.setUserName}
        textContentType="username"
    />
    ```
    
    ```jsx
    <TextInput
        value={this.state.password}
        onChangeText={this.setPassword}
        secureTextEntry={true}
        textContentType="password"
    />
    ```
    
    To disable:
    ```jsx
    <TextInput
        value={this.state.password}
        onChangeText={this.setPassword}
        secureTextEntry={true}
        textContentType="none"
    />
    ```
    
    This will set `textContentType` to an empty string: https://stackoverflow.com/a/46474180/5703116
    
    <!--
      Does this PR require a documentation change?
      Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
    -->
    
    Docs PR coming up.
    
    [IOS] [MINOR] [TextInput] - Added `textContentType` prop for iOS 10+. Will enable password autofill for iOS 11+.
    Closes #18526
    
    Differential Revision: D7469630
    
    Pulled By: hramos
    
    fbshipit-source-id: 852a9749be98d477ecd82154c0a65a7c084521c1
    cbrevik authored and facebook-github-bot committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    d4fb87b View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2018

  1. Fix tvOS build breakage in RCTAnimation Xcode project

    Summary:
    `RCTSubtractionAnimatedNode.m` was not added to the tvOS build of RCTAnimation... this PR fixes the issue.
    
    tvOS CI should succeed after this change.
    
    [TVOS] [BUGFIX] [RCTAnimation] Fix build breakage
    Closes #18663
    
    Differential Revision: D7483586
    
    Pulled By: hramos
    
    fbshipit-source-id: 521152d829b064b7002dc8651a0558373c5505f8
    douglowder authored and facebook-github-bot committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    201e74f View commit details
    Browse the repository at this point in the history
  2. Replace RN exception handling override with new version

    Reviewed By: Hypuk
    
    Differential Revision: D7385541
    
    fbshipit-source-id: 287d3f4d681046f740ed0552e00a2249c3803a0b
    pakoito authored and facebook-github-bot committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    976712a View commit details
    Browse the repository at this point in the history
  3. Remove the usage of YGUndefined for kYGValueAuto and fix setter and g…

    …etter of dimensions
    
    Reviewed By: emilsjolander
    
    Differential Revision: D7302453
    
    fbshipit-source-id: e002a1ddd75bfc6fe142a7275e7913c064972e16
    priteshrnandgaonkar authored and facebook-github-bot committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    e5a4d59 View commit details
    Browse the repository at this point in the history
  4. Change the type of aspect Ratio to YGFloatOptional

    Reviewed By: emilsjolander
    
    Differential Revision: D7302651
    
    fbshipit-source-id: 53e3b4c9627207a379f927b1f3485e36a9c70601
    priteshrnandgaonkar authored and facebook-github-bot committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    bcd12f1 View commit details
    Browse the repository at this point in the history
  5. Move equaltiy function from utils to an operator on YGFloatOptional

    Reviewed By: emilsjolander
    
    Differential Revision: D7303460
    
    fbshipit-source-id: 41ec0076ace621ec1a5bdbab00b72eea57780fff
    priteshrnandgaonkar authored and facebook-github-bot committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    63c073d View commit details
    Browse the repository at this point in the history
  6. Changed the return type of YGResolveValueMargin to YGFloatOptional

    Reviewed By: emilsjolander
    
    Differential Revision: D7304090
    
    fbshipit-source-id: cbec03a9367cf34976d083ad475d4da0b736e6d2
    priteshrnandgaonkar authored and facebook-github-bot committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    f84f4fd View commit details
    Browse the repository at this point in the history
  7. fix(RCTImageLoader): Adds requiresMainQueueSetup to fix v0.52

    Summary:
    <!--
    Thank you for sending the PR! We appreciate you spending the time to work on these changes.
    
    Help us understand your motivation by explaining why you decided to make this change.
    
    You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html
    
    Happy contributing!
    
    -->
    
    In react-native v0.52 this warning shows:
    ```
    "RCTImageLoader requires main queue setup
    since it overrides `init` but doesn't implement `requiresMainQueueSetup`".
    ```
    This removes the warning by implementing `requiresMainQueueSetup` on RCTImageLoader
    
    * Create new react-native project
    * Enable Remote JS Debugging
    * Should see no warning regarding RCTImageLoader requiring main queue setup
    
    <!--
    Help reviewers and the release process by writing your own release notes
    
    **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
    
      CATEGORY
    [----------]        TYPE
    [ CLI      ]   [-------------]      LOCATION
    [ DOCS     ]   [ BREAKING    ]   [-------------]
    [ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
    [ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
    [ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
    [ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
    [----------]   [-------------]   [-------------]   |-----------|
    
    [CATEGORY] [TYPE] [LOCATION] - MESSAGE
    
     EXAMPLES:
    
     [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
     [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
     [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
     [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
     [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
     [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
    -->
    [IOS] [BUGFIX] [Libraries/Image/RCTImageLoader.m] - Implements `requiresMainQueueSetup`
    Closes #17679
    
    Reviewed By: shergin
    
    Differential Revision: D7159601
    
    Pulled By: fkgozali
    
    fbshipit-source-id: e17bae67f4005d2c9ddd0d3701506521f3cac152
    iRoachie authored and facebook-github-bot committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    7469458 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2018

  1. Fix wrong root path in RNTester gradle config

    Summary:
    Currrent(0.54-stable) root path in RNTester gradle config would cause a failure when trying to compile a release version for RNTester:
    ```
    module.js:545
        throw err;
        ^
    
    Error: Cannot find module ’TheParentDirectoryOfCurrentRepo/local-cli/cli.js'
        at Function.Module._resolveFilename (module.js:543:15)
        at Function.Module._load (module.js:470:25)
        at Function.Module.runMain (module.js:690:10)
        at startup (bootstrap_node.js:194:16)
        at bootstrap_node.js:666:3
    :RNTester:android:app:bundleReleaseJsAndAssets FAILED
    ```
    
    [ANDROID] [INTERNAL] [RNTester] - Fix wrong root path in RNTester gradle config
    Closes #18553
    
    Differential Revision: D7488301
    
    Pulled By: mdvacca
    
    fbshipit-source-id: b49a01820957eb77daeca9c0949f662b668f2bd1
    sunnylqm authored and facebook-github-bot committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    cdfc346 View commit details
    Browse the repository at this point in the history
  2. Update ScrollView.js

    mistenkt committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    591fab1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e90226 View commit details
    Browse the repository at this point in the history