Context tracer for flask #3573
Closed
Context tracer for flask #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature is not GA, which makes system testing problematic. Development continues on the 'storage-requester_pays-feature' branch.
Note that the version number was bumped prematurely in PR 72e6e52.
(google-cloud-python-2)
$ flake8 tests
tests/system.py:178:32: F812 list comprehension redefines 'dataset' from line 170
tests/system.py:233:30: F812 list comprehension redefines 'table' from line 225
tests/system.py:841:9: F841 local variable 'dataset' is assigned to but never used
tests/unit/test_table.py:406:23: W291 trailing whitespace
tests/unit/test_table.py:1052:9: F841 local variable 'ROWS' is assigned to but never used
…_legacy_urlsafe (googleapis#3560) Also * add padding characters in `from_legacy_urlsafe` if needed * add an extra example in the unit tests that actually requires base64 padding
* Also add systest for user exception aborting transaction.
* Switched to google-resumable-media in BigQuery. * Upgrading google-resumable-media dependency to 0.2.1.
* Add future interface to bigquery Jobs. * Make QueryJob return QueryResults from result() * Deprecate QueryJob.results()
* Removing vendored in google.cloud.streaming. * Modifying setup.cfg so pytest errors are sane. This is **not** to be merged, just to debug the b0rken build: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2515
This reverts commit d0479d6.
Include NULL values in ARRAY<INT64>.
* Removing `get_credentials()` from `core`. In the process also: - Slight re-org on `nox.py` config (to pass posargs) for `core` and `datastore` - Getting rid of last usage of `_Monkey` in datastore This is part of `@jonparrott`'s effort to slim down / stabilize `core`. * Removing `google.cloud.credentials` module from docs.
Also bumping the version on the uber-package.
…s#3672) * Simplifying Client constructor's for Bigtable and Spanner. * Fixing Bigtable unit tests after Client re-factor. Also slightly changing the Client constructor so that it only called `with_scopes()` one time on the credentials (was previously calling with `SCOPE=None` and then again with the custom scope for the instance) * Fixing Spanner unit tests after Client re-factor. Also slightly changing the `copy()` method so that it just passes the same credentials instance. Also updating `nox` config to allow session `posargs`. * Removing unused imports after Bigtable/Spanner Client re-factor.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
googlebot
added
cla: no
|
This will be living in opencensus repository, closing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a context tracer for flask. It can automatically grab the trace_id from the request headers and generate a trace context. Sample usage as below: