Changes `sdk-server` to Patch instead of Update #3803

igooch · 2024-04-24T20:04:19Z

What type of PR is this?

/kind feature

What this PR does / Why we need it:

See #3767#update-vs-patch

Which issue(s) this PR fixes:

Completes part II of #3767

Special notes for your reviewer:

I did not change PlayerTracking as the feature will be deprecated.

agones-bot · 2024-04-24T20:17:17Z

Build Failed 😱

Build Id: 86bfdc40-16f8-4b7c-9f66-cf7812f23e98

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-24T22:28:31Z

Build Failed 😱

Build Id: b33662d3-a2bc-44ba-85ed-b7c3bd96199e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-29T16:08:48Z

Build Failed 😱

Build Id: 0bbdb825-9db9-4c47-8deb-dfbc6a540804

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-29T16:34:44Z

Build Failed 😱

Build Id: 6815d91e-df07-468a-922f-42c5d57d534e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-29T18:54:40Z

Build Failed 😱

Build Id: ffad0a56-986c-48b8-926c-e33bbe3b302a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-29T20:26:03Z

Build Failed 😱

Build Id: 0874d154-d557-4d95-8758-960a7224cf59

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-29T20:36:05Z

Build Failed 😱

Build Id: 9082097e-571a-4d84-bb83-1aa9f2e8cf1e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-29T23:45:11Z

Build Failed 😱

Build Id: b2d07549-18e8-46a9-a787-2428b249bbae

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-30T17:53:56Z

Build Failed 😱

Build Id: ef3b3b58-9825-4533-aeb9-18c573b9a9de

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-30T20:26:03Z

Build Succeeded 👏

Build Id: 13a4d9ab-7c88-4197-aeee-b32788db2b1b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://609791e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3803/head:pr_3803 && git checkout pr_3803
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-609791e-amd64

pkg/sdkserver/sdkserver_test.go

zmerlynn · 2024-04-30T21:55:45Z

cc @markmandel (but I'm happy to proceed with this, we have plenty of time to CI)

agones-bot · 2024-05-01T02:45:35Z

Build Succeeded 👏

Build Id: 90eaea65-b207-494b-a0b5-51b9b1f16805

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://c3d5f1e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3803/head:pr_3803 && git checkout pr_3803
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-c3d5f1e-amd64

pkg/sdkserver/sdkserver.go

agones-bot · 2024-05-02T21:48:02Z

Build Failed 😱

Build Id: c3525962-6b06-438f-998a-08d01ff10994

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

zmerlynn

Looks like you need to fix a conflict before merging but happy to approve so you can get it in queue after that.

agones-bot · 2024-05-03T16:42:57Z

Build Failed 😱

Build Id: 5deb4e5d-c004-4069-bc1e-96d3d206f2f0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-03T18:04:53Z

Build Failed 😱

Build Id: 331ab084-f45d-44cd-9948-53e75a935fe7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

…r not set

…n when the game server is reserved to when the test checks that the game server has been reserved from 1 second to 1.5 seconds

agones-bot · 2024-05-06T16:53:27Z

Build Failed 😱

Build Id: a4337993-958e-4f9c-a36d-adfa34651d7a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-06T18:04:00Z

Build Failed 😱

Build Id: b230f09c-a4ef-41c1-89fb-dbefca2f4ff3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2024-05-07T00:10:19Z

Checking different GKE versions, I'm seeing all kinds of weird e2e tests - something has gone unfortunately skewiff.

For example: https://console.cloud.google.com/cloud-build/builds/8456e5b8-41a1-4f9d-806a-5376be6f9570?project=258182270954

I see a bunch of counter issues:

VERBOSE: === RUN   TestCounters/IncrementCounter
VERBOSE: time="2024-05-06 18:13:00.950" level=info msg=IncrementCounter fields.msg="INCREMENT_COUNTER foo 10"
VERBOSE: time="2024-05-06 18:13:00.967" level=info msg="Sending GetCounterCount" fields.msg="GET_COUNTER_COUNT foo"
VERBOSE:     gameserver_test.go:1481: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserver_test.go:1481
VERBOSE:         	Error:      	Not equal: 
VERBOSE:         	            	expected: "COUNTER: 20\n"
VERBOSE:         	            	actual  : "COUNTER: 10\n"
VERBOSE:         	            	
VERBOSE:         	            	Diff:
VERBOSE:         	            	--- Expected
VERBOSE:         	            	+++ Actual
VERBOSE:         	            	@@ -1,2 +1,2 @@
VERBOSE:         	            	-COUNTER: 20
VERBOSE:         	            	+COUNTER: 10
VERBOSE:         	            	 
VERBOSE:         	Test:       	TestCounters/IncrementCounter
VERBOSE: --- FAIL: TestCounters/IncrementCounter (0.04s)
VERBOSE: --- FAIL: TestCounters (3.25s)

igooch · 2024-05-07T00:33:14Z

Checking different GKE versions, I'm seeing all kinds of weird e2e tests - something has gone unfortunately skewiff.

That's what I'm working on debugging now. From what logs I've been able to glean it looks like the patch is not going through due to the object resource version having changed (WAI). I'm attempting to figure out if it's failing because it's returning the original error before retry, failing after multiple retries, or something else. Having a hard time debugging since I don't have any easy way of getting the container logs during test since only about one out of twenty game servers fail and there's so much pod churn. I.e. kubectl logs -f -l agones.dev/role=gameserver -c agones-gameserver-sidecar -n 123456 will only get for the currently running pods, and won't watch / stream for newly created pods.

If you know how to create a kubectl command to watch and stream logs for newly created pods in a namespace, please let me know. I haven't been able to get kubectl get pods watch + xargs kubectl logs to work.

markmandel · 2024-05-07T00:47:25Z

If you can output to the test which GameServers fail, you should be able to use Cloud Console logging to see all the logs for that Pod and it's sidecars.

agones-bot · 2024-05-08T03:31:40Z

Build Succeeded 👏

Build Id: ae5dbc53-9735-4951-b4f3-3dae91c47164

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://630250c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3803/head:pr_3803 && git checkout pr_3803
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-630250c-amd64

markmandel

Looks great!

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.40.0` -> `1.41.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.41.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1410-2024-06-04) [Compare Source](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) **Implemented enhancements:** - Configure Allocator Status Code by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3782 - Graduate Counters and Lists to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3801 - Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3809 - CountsAndLists: Move to Beta Protobuf by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3806 - feat: support multiple port ranges by [@nrwiersma](https://github.com/nrwiersma) in [googleforgames/agones#3747 - Changes `sdk-server` to Patch instead of Update by [@igooch](https://github.com/igooch) in [googleforgames/agones#3803 - Generate grpc for nodejs from alpha to beta by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3825 - Update CountsAndLists from Alpha to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3824 - feat(gameserver): New DirectToGameServer PortPolicy allows direct traffic to a GameServer by [@daniellee](https://github.com/daniellee) in [googleforgames/agones#3807 - Passthrough autopilot - Adds mutating webhook by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3833 - Passthrough autopilot - added ports array case and updated unit tests by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3842 - Nodejs counters and lists by [@steven-supersolid](https://github.com/steven-supersolid) in [googleforgames/agones#3726 - Promote AutopilotPassthroughPort feature gate to Alpha by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3849 **Fixed bugs:** - Helm Param Update: Default to agones.controller if agones.extensions is Missing by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3773 - fix: rollout strategy issues by [@nrwiersma](https://github.com/nrwiersma) in [googleforgames/agones#3762 - Set Minimum Buffer Size to 1 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3749 - Pin ltsc2019 to older SHA by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3829 - TestGameServerAllocationDuringMultipleAllocationClients: Readdress flake by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3831 - Refactor finalizer name to include valid domain name and path by [@indexjoseph](https://github.com/indexjoseph) in [googleforgames/agones#3840 - agones-{extensions,allocator}: Be more defensive about draining by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3839 - agones-{extensions,allocator}: Pause after cancelling context by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3843 - Change the line to modify in Quickstart: Edit a Game Server by [@peterzhongyi](https://github.com/peterzhongyi) in [googleforgames/agones#3844 **Other:** - Prep for Release v1.41.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3800 - Update site documentation to reflect firewall prefix and default to Autopilot cluster creation for Agones by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3769 - Add a System Diagram and overview page by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3792 - Update Side Menu: Preserve and Restore Scroll Position by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3805 - fix: typo by [@skmpf](https://github.com/skmpf) in [googleforgames/agones#3808 - Helm Config: Add httpUnallocatedStatusCode in Allocator Service by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3802 - Update Docs: CountersAndLists to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3810 - Disable Dev feature FeatureAutopilotPassthroughPort by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3815 - Disable FeatureAutopilotPassthroughPort in features.go by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3816 - SDK proto compatibility guarantees and deprecation policies documentation by [@igooch](https://github.com/igooch) in [googleforgames/agones#3774 - Fix dangling "as of" by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3827 - Steps to Promote SDK Features from Alpha to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3814 - Adds comment for help troubleshooting issues with terraform tfstate by [@igooch](https://github.com/igooch) in [googleforgames/agones#3822 - docs: improve counter and list example comments by [@yonbh](https://github.com/yonbh) in [googleforgames/agones#3818 - Skip /tmp/ on yamllint by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3838 - TestAllocatorAfterDeleteReplica: More logging by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3837 - Instructions for upgrading golang version by [@gongmax](https://github.com/gongmax) in [googleforgames/agones#3819 - Remove unused function FindGameServerContainer by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3841 - Adds Unreal to the List of URL Links to Not Check by [@igooch](https://github.com/igooch) in [googleforgames/agones#3847 - docs: clarify virtualization setup for Windows versions by [@andresromerodev](https://github.com/andresromerodev) in [googleforgames/agones#3850 **New Contributors:** - [@skmpf](https://github.com/skmpf) made their first contribution in [googleforgames/agones#3808 - [@yonbh](https://github.com/yonbh) made their first contribution in [googleforgames/agones#3818 - [@peterzhongyi](https://github.com/peterzhongyi) made their first contribution in [googleforgames/agones#3844 - [@andresromerodev](https://github.com/andresromerodev) made their first contribution in [googleforgames/agones#3850 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

github-actions bot added kind/feature New features for Agones size/M labels Apr 24, 2024

igooch force-pushed the inPlaceUpgrades branch from 643f152 to 4c68627 Compare April 24, 2024 21:57

igooch force-pushed the inPlaceUpgrades branch from aa3b309 to 12f18ec Compare April 29, 2024 15:56

igooch force-pushed the inPlaceUpgrades branch from 12f18ec to 166d476 Compare April 29, 2024 16:24

github-actions bot added the size/L label Apr 29, 2024

igooch force-pushed the inPlaceUpgrades branch 2 times, most recently from 527291f to 70720cb Compare April 29, 2024 20:18

igooch force-pushed the inPlaceUpgrades branch from 70720cb to e361af3 Compare April 29, 2024 20:28

igooch force-pushed the inPlaceUpgrades branch from aeabdfd to 11c80d6 Compare April 29, 2024 22:12

igooch marked this pull request as ready for review April 30, 2024 18:52

igooch requested a review from zmerlynn April 30, 2024 20:28

zmerlynn changed the title ~~Changes UpdateLabels to Patch instead of Update~~ Changes sdk-server to Patch instead of Update Apr 30, 2024

zmerlynn approved these changes Apr 30, 2024

View reviewed changes

pkg/sdkserver/sdkserver_test.go Outdated Show resolved Hide resolved

markmandel reviewed May 1, 2024

View reviewed changes

pkg/sdkserver/sdkserver.go Outdated Show resolved Hide resolved

pkg/sdkserver/sdkserver.go Show resolved Hide resolved

igooch force-pushed the inPlaceUpgrades branch from 96e69e4 to 1a1b28e Compare May 2, 2024 19:54

zmerlynn approved these changes May 3, 2024

View reviewed changes

igooch force-pushed the inPlaceUpgrades branch from a8b20ed to bc1d31e Compare May 3, 2024 16:28

igooch added 13 commits May 6, 2024 16:08

Changes UpdateLabels to Patch instead of Update

4704795

SDK update Counters to use Patch instead of Update

8ae643d

SDK update Lists uses Patch instead of Update

9fa9f36

SDK update annotations and state uses Patch instead of Update

f3de6b8

Changes AssertEqual on a time for AssertWithinDuration of 1 second

ca342b0

Adds copy of game server to TestSDKServerReserveTimeout patch reactor

1c09e14

Pulls out game server patch into helper function

b2c80d4

Changes the SDK role binding permission from Update to Patch

bd5d105

SDK server update PlayerTracking to patch

d802346

Unexports helper function

5d3d8c8

Update game server Patch to fail if the resource version is changed o…

eaac362

…r not set

Adds e2e test for game server patch

5515ea2

Increases the SDKServerReserveTimeout tolerance for difference betwee…

6f68262

…n when the game server is reserved to when the test checks that the game server has been reserved from 1 second to 1.5 seconds

igooch force-pushed the inPlaceUpgrades branch from cf159a2 to 6f68262 Compare May 6, 2024 16:08

Updates beta variable to use b instead of the alpha a

9f0dc0d

igooch force-pushed the inPlaceUpgrades branch from 85f0b88 to 9f0dc0d Compare May 6, 2024 17:05

Caches updated version of game server in the SDK

630250c

markmandel approved these changes May 8, 2024

View reviewed changes

markmandel merged commit ae030c9 into googleforgames:main May 8, 2024
4 checks passed

daniellee mentioned this pull request Aug 27, 2024

Incorrect error logging caused by ResourceVersion conflict on SDK Patch call #3967

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes `sdk-server` to Patch instead of Update #3803

Changes `sdk-server` to Patch instead of Update #3803

igooch commented Apr 24, 2024 •

edited

Loading

agones-bot commented Apr 24, 2024

agones-bot commented Apr 24, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 30, 2024

agones-bot commented Apr 30, 2024

zmerlynn commented Apr 30, 2024

agones-bot commented May 1, 2024

agones-bot commented May 2, 2024

zmerlynn left a comment

agones-bot commented May 3, 2024

agones-bot commented May 3, 2024

agones-bot commented May 6, 2024

agones-bot commented May 6, 2024

markmandel commented May 7, 2024

igooch commented May 7, 2024

markmandel commented May 7, 2024

agones-bot commented May 8, 2024

markmandel left a comment

Changes sdk-server to Patch instead of Update #3803

Changes sdk-server to Patch instead of Update #3803

Conversation

igooch commented Apr 24, 2024 • edited Loading

agones-bot commented Apr 24, 2024

agones-bot commented Apr 24, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented Apr 30, 2024

agones-bot commented Apr 30, 2024

zmerlynn commented Apr 30, 2024

agones-bot commented May 1, 2024

agones-bot commented May 2, 2024

zmerlynn left a comment

Choose a reason for hiding this comment

agones-bot commented May 3, 2024

agones-bot commented May 3, 2024

agones-bot commented May 6, 2024

agones-bot commented May 6, 2024

markmandel commented May 7, 2024

igooch commented May 7, 2024

markmandel commented May 7, 2024

agones-bot commented May 8, 2024

markmandel left a comment

Choose a reason for hiding this comment

Changes `sdk-server` to Patch instead of Update #3803

Changes `sdk-server` to Patch instead of Update #3803

igooch commented Apr 24, 2024 •

edited

Loading