Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label #3809

vicentefb · 2024-04-29T21:01:32Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
These changes are the first two steps towards #3721
-Adds an AutopilotPassthroughPort Feature Gate
-Adds a new label, e.g. agones.dev/port: "autopilot-passthrough"

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:
none

agones-bot · 2024-04-29T22:12:06Z

Build Succeeded 👏

Build Id: ce333538-268b-492f-a741-7857ecc52c10

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://0a93454-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3809/head:pr_3809 && git checkout pr_3809
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-0a93454-amd64

pkg/gameservers/controller.go

pkg/gameservers/controller_test.go

pkg/util/runtime/features.go

agones-bot · 2024-04-30T19:27:42Z

Build Succeeded 👏

Build Id: a7f42a4b-efc8-4d4e-be57-0ed9198967c4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://3f537cb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3809/head:pr_3809 && git checkout pr_3809
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-3f537cb-amd64

zmerlynn

LGTM modulo a couple of nits

pkg/cloudproduct/gke/gke.go

pkg/gameservers/controller.go

pkg/cloudproduct/gke/gke_test.go

agones-bot · 2024-05-01T04:24:36Z

Build Failed 😱

Build Id: 44695950-17ae-4a37-b1ea-591027536a7c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-01T05:26:57Z

Build Succeeded 👏

Build Id: a66cb13a-373a-419a-9727-140c20415862

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://3b014d9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3809/head:pr_3809 && git checkout pr_3809
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-3b014d9-amd64

…sters, added feature flag in yaml and moved it to dev

nit

nit nit

agones-bot · 2024-05-01T21:33:07Z

Build Succeeded 👏

Build Id: 5f7171f8-451f-4a44-a2ee-13bebfde06e4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://3b14d24-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3809/head:pr_3809 && git checkout pr_3809
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-3b14d24-amd64

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.40.0` -> `1.41.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.41.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1410-2024-06-04) [Compare Source](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) **Implemented enhancements:** - Configure Allocator Status Code by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3782 - Graduate Counters and Lists to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3801 - Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3809 - CountsAndLists: Move to Beta Protobuf by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3806 - feat: support multiple port ranges by [@nrwiersma](https://github.com/nrwiersma) in [googleforgames/agones#3747 - Changes `sdk-server` to Patch instead of Update by [@igooch](https://github.com/igooch) in [googleforgames/agones#3803 - Generate grpc for nodejs from alpha to beta by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3825 - Update CountsAndLists from Alpha to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3824 - feat(gameserver): New DirectToGameServer PortPolicy allows direct traffic to a GameServer by [@daniellee](https://github.com/daniellee) in [googleforgames/agones#3807 - Passthrough autopilot - Adds mutating webhook by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3833 - Passthrough autopilot - added ports array case and updated unit tests by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3842 - Nodejs counters and lists by [@steven-supersolid](https://github.com/steven-supersolid) in [googleforgames/agones#3726 - Promote AutopilotPassthroughPort feature gate to Alpha by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3849 **Fixed bugs:** - Helm Param Update: Default to agones.controller if agones.extensions is Missing by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3773 - fix: rollout strategy issues by [@nrwiersma](https://github.com/nrwiersma) in [googleforgames/agones#3762 - Set Minimum Buffer Size to 1 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3749 - Pin ltsc2019 to older SHA by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3829 - TestGameServerAllocationDuringMultipleAllocationClients: Readdress flake by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3831 - Refactor finalizer name to include valid domain name and path by [@indexjoseph](https://github.com/indexjoseph) in [googleforgames/agones#3840 - agones-{extensions,allocator}: Be more defensive about draining by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3839 - agones-{extensions,allocator}: Pause after cancelling context by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3843 - Change the line to modify in Quickstart: Edit a Game Server by [@peterzhongyi](https://github.com/peterzhongyi) in [googleforgames/agones#3844 **Other:** - Prep for Release v1.41.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3800 - Update site documentation to reflect firewall prefix and default to Autopilot cluster creation for Agones by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3769 - Add a System Diagram and overview page by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3792 - Update Side Menu: Preserve and Restore Scroll Position by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3805 - fix: typo by [@skmpf](https://github.com/skmpf) in [googleforgames/agones#3808 - Helm Config: Add httpUnallocatedStatusCode in Allocator Service by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3802 - Update Docs: CountersAndLists to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3810 - Disable Dev feature FeatureAutopilotPassthroughPort by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3815 - Disable FeatureAutopilotPassthroughPort in features.go by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3816 - SDK proto compatibility guarantees and deprecation policies documentation by [@igooch](https://github.com/igooch) in [googleforgames/agones#3774 - Fix dangling "as of" by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3827 - Steps to Promote SDK Features from Alpha to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3814 - Adds comment for help troubleshooting issues with terraform tfstate by [@igooch](https://github.com/igooch) in [googleforgames/agones#3822 - docs: improve counter and list example comments by [@yonbh](https://github.com/yonbh) in [googleforgames/agones#3818 - Skip /tmp/ on yamllint by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3838 - TestAllocatorAfterDeleteReplica: More logging by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3837 - Instructions for upgrading golang version by [@gongmax](https://github.com/gongmax) in [googleforgames/agones#3819 - Remove unused function FindGameServerContainer by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3841 - Adds Unreal to the List of URL Links to Not Check by [@igooch](https://github.com/igooch) in [googleforgames/agones#3847 - docs: clarify virtualization setup for Windows versions by [@andresromerodev](https://github.com/andresromerodev) in [googleforgames/agones#3850 **New Contributors:** - [@skmpf](https://github.com/skmpf) made their first contribution in [googleforgames/agones#3808 - [@yonbh](https://github.com/yonbh) made their first contribution in [googleforgames/agones#3818 - [@peterzhongyi](https://github.com/peterzhongyi) made their first contribution in [googleforgames/agones#3844 - [@andresromerodev](https://github.com/andresromerodev) made their first contribution in [googleforgames/agones#3850 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

github-actions bot added kind/feature New features for Agones size/S labels Apr 29, 2024

zmerlynn requested changes Apr 30, 2024

View reviewed changes

pkg/gameservers/controller.go Outdated Show resolved Hide resolved

pkg/gameservers/controller.go Outdated Show resolved Hide resolved

pkg/gameservers/controller_test.go Outdated Show resolved Hide resolved

pkg/util/runtime/features.go Outdated Show resolved Hide resolved

vicentefb requested a review from zmerlynn April 30, 2024 18:09

vicentefb force-pushed the Passthrough_Autopilot branch from 42b22b6 to 3f537cb Compare April 30, 2024 18:30

zmerlynn reviewed Apr 30, 2024

View reviewed changes

pkg/cloudproduct/gke/gke.go Outdated Show resolved Hide resolved

pkg/gameservers/controller.go Outdated Show resolved Hide resolved

pkg/cloudproduct/gke/gke_test.go Show resolved Hide resolved

github-actions bot added the size/M label May 1, 2024

vicentefb requested a review from zmerlynn May 1, 2024 04:15

vicentefb force-pushed the Passthrough_Autopilot branch 2 times, most recently from e2bf06c to 3b014d9 Compare May 1, 2024 04:29

vicentefb added 5 commits May 1, 2024 20:31

changes to feature and added a lable to gameserver spec with test

9f23394

added const and update unit test and controller

6ff205e

moved implementation to cloudproduct gke to account for autopilot clu…

fc7e8e6

…sters, added feature flag in yaml and moved it to dev

added test inside gke for passthrough label

43b7d45

nit

nit and added negative tests

3b14d24

nit nit

vicentefb force-pushed the Passthrough_Autopilot branch from 3b014d9 to 3b14d24 Compare May 1, 2024 20:31

zmerlynn approved these changes May 1, 2024

View reviewed changes

zmerlynn merged commit ef2d0b5 into googleforgames:main May 1, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label #3809

Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label #3809

vicentefb commented Apr 29, 2024 •

edited

Loading

agones-bot commented Apr 29, 2024

agones-bot commented Apr 30, 2024

zmerlynn left a comment

agones-bot commented May 1, 2024

agones-bot commented May 1, 2024

agones-bot commented May 1, 2024

Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label #3809

Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label #3809

Conversation

vicentefb commented Apr 29, 2024 • edited Loading

agones-bot commented Apr 29, 2024

agones-bot commented Apr 30, 2024

zmerlynn left a comment

Choose a reason for hiding this comment

agones-bot commented May 1, 2024

agones-bot commented May 1, 2024

agones-bot commented May 1, 2024

vicentefb commented Apr 29, 2024 •

edited

Loading