Steps to Promote SDK Features from Alpha to Beta #3814

Kalaiselvi84 · 2024-05-08T23:14:27Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

pkg/util/runtime/features.go

agones-bot · 2024-05-09T00:21:47Z

Build Succeeded 👏

Build Id: c8118487-0a58-4293-a034-37ded6501cd8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://b81eb78-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3814/head:pr_3814 && git checkout pr_3814
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-b81eb78-amd64

agones-bot · 2024-05-09T02:45:01Z

Build Failed 😱

Build Id: c7aae1e4-71f1-456d-860f-897fc42101a9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/util/runtime/features.go

…into cl-aTOb-doc

pkg/util/runtime/features.go

agones-bot · 2024-05-10T18:53:08Z

Build Succeeded 👏

Build Id: e6e3bbc4-2045-4171-8d80-89ddc20f6da1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://da3d117-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3814/head:pr_3814 && git checkout pr_3814
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-da3d117-amd64

igooch

Are these suggestions closer to the intent?

pkg/util/runtime/features.go

Kalaiselvi84 · 2024-05-13T20:32:21Z

@igooch, I have updated the steps as per your suggestion.

igooch

One last suggestion, then LGTM.

pkg/util/runtime/features.go

agones-bot · 2024-05-13T21:06:46Z

Build Failed 😱

Build Id: cade7a49-b111-45e4-a26a-590ed095e69a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-13T21:41:12Z

Build Failed 😱

Build Id: f1bdec1a-9de7-4b9a-b432-d1d41937efa1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-13T22:40:32Z

Build Failed 😱

Build Id: db5e1629-8992-48f5-a376-ba789ad24e42

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

LGTM!

Any extra thoughts @igooch ?

markmandel

Ah! Already approved! In which case, double approved!

agones-bot · 2024-05-14T01:06:18Z

Build Failed 😱

Build Id: c5a97503-cabe-4cae-bcf7-f96e32cefa33

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-14T02:21:45Z

Build Failed 😱

Build Id: 59bf6033-1f95-4f04-8ce3-023852f76de5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-14T17:58:35Z

Build Failed 😱

Build Id: 5795610c-81c9-4bba-b572-640a1d7e047a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-14T18:12:42Z

Build Failed 😱

Build Id: 8cababde-2c13-4ccd-8c64-80717283e48e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

…into cl-aTOb-doc

agones-bot · 2024-05-14T19:21:32Z

Build Failed 😱

Build Id: 22b83230-f06c-49eb-ace6-8a2f45d5b756

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-15T18:29:45Z

Build Succeeded 👏

Build Id: 1833a6dc-d22c-4e74-bd8d-c9b37b35a3e8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://06f7312-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3814/head:pr_3814 && git checkout pr_3814
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-06f7312-amd64

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.40.0` -> `1.41.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.41.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1410-2024-06-04) [Compare Source](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) **Implemented enhancements:** - Configure Allocator Status Code by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3782 - Graduate Counters and Lists to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3801 - Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3809 - CountsAndLists: Move to Beta Protobuf by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3806 - feat: support multiple port ranges by [@nrwiersma](https://github.com/nrwiersma) in [googleforgames/agones#3747 - Changes `sdk-server` to Patch instead of Update by [@igooch](https://github.com/igooch) in [googleforgames/agones#3803 - Generate grpc for nodejs from alpha to beta by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3825 - Update CountsAndLists from Alpha to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3824 - feat(gameserver): New DirectToGameServer PortPolicy allows direct traffic to a GameServer by [@daniellee](https://github.com/daniellee) in [googleforgames/agones#3807 - Passthrough autopilot - Adds mutating webhook by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3833 - Passthrough autopilot - added ports array case and updated unit tests by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3842 - Nodejs counters and lists by [@steven-supersolid](https://github.com/steven-supersolid) in [googleforgames/agones#3726 - Promote AutopilotPassthroughPort feature gate to Alpha by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3849 **Fixed bugs:** - Helm Param Update: Default to agones.controller if agones.extensions is Missing by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3773 - fix: rollout strategy issues by [@nrwiersma](https://github.com/nrwiersma) in [googleforgames/agones#3762 - Set Minimum Buffer Size to 1 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3749 - Pin ltsc2019 to older SHA by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3829 - TestGameServerAllocationDuringMultipleAllocationClients: Readdress flake by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3831 - Refactor finalizer name to include valid domain name and path by [@indexjoseph](https://github.com/indexjoseph) in [googleforgames/agones#3840 - agones-{extensions,allocator}: Be more defensive about draining by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3839 - agones-{extensions,allocator}: Pause after cancelling context by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3843 - Change the line to modify in Quickstart: Edit a Game Server by [@peterzhongyi](https://github.com/peterzhongyi) in [googleforgames/agones#3844 **Other:** - Prep for Release v1.41.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3800 - Update site documentation to reflect firewall prefix and default to Autopilot cluster creation for Agones by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3769 - Add a System Diagram and overview page by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3792 - Update Side Menu: Preserve and Restore Scroll Position by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3805 - fix: typo by [@skmpf](https://github.com/skmpf) in [googleforgames/agones#3808 - Helm Config: Add httpUnallocatedStatusCode in Allocator Service by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3802 - Update Docs: CountersAndLists to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3810 - Disable Dev feature FeatureAutopilotPassthroughPort by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3815 - Disable FeatureAutopilotPassthroughPort in features.go by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3816 - SDK proto compatibility guarantees and deprecation policies documentation by [@igooch](https://github.com/igooch) in [googleforgames/agones#3774 - Fix dangling "as of" by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3827 - Steps to Promote SDK Features from Alpha to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3814 - Adds comment for help troubleshooting issues with terraform tfstate by [@igooch](https://github.com/igooch) in [googleforgames/agones#3822 - docs: improve counter and list example comments by [@yonbh](https://github.com/yonbh) in [googleforgames/agones#3818 - Skip /tmp/ on yamllint by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3838 - TestAllocatorAfterDeleteReplica: More logging by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3837 - Instructions for upgrading golang version by [@gongmax](https://github.com/gongmax) in [googleforgames/agones#3819 - Remove unused function FindGameServerContainer by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3841 - Adds Unreal to the List of URL Links to Not Check by [@igooch](https://github.com/igooch) in [googleforgames/agones#3847 - docs: clarify virtualization setup for Windows versions by [@andresromerodev](https://github.com/andresromerodev) in [googleforgames/agones#3850 **New Contributors:** - [@skmpf](https://github.com/skmpf) made their first contribution in [googleforgames/agones#3808 - [@yonbh](https://github.com/yonbh) made their first contribution in [googleforgames/agones#3818 - [@peterzhongyi](https://github.com/peterzhongyi) made their first contribution in [googleforgames/agones#3844 - [@andresromerodev](https://github.com/andresromerodev) made their first contribution in [googleforgames/agones#3850 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Steps to Promote SDK Features from Alpha to Beta

b81eb78

Kalaiselvi84 requested review from markmandel and igooch May 8, 2024 23:14

github-actions bot added kind/other size/S labels May 8, 2024

markmandel reviewed May 9, 2024

View reviewed changes

pkg/util/runtime/features.go Outdated Show resolved Hide resolved

pkg/util/runtime/features.go Outdated Show resolved Hide resolved

make more generic

a5cadd1

github-actions bot added the size/XS label May 9, 2024

Merge branch 'main' into cl-aTOb-doc

2baa9c7

igooch reviewed May 9, 2024

View reviewed changes

pkg/util/runtime/features.go Outdated Show resolved Hide resolved

Kalaiselvi84 added 2 commits May 10, 2024 16:57

modify steps

36ae0e0

Merge branch 'cl-aTOb-doc' of https://github.com/Kalaiselvi84/agones …

da3d117

…into cl-aTOb-doc

igooch reviewed May 10, 2024

View reviewed changes

pkg/util/runtime/features.go Outdated Show resolved Hide resolved

igooch reviewed May 13, 2024

View reviewed changes

Kalaiselvi84 added 2 commits May 13, 2024 20:31

Review changes

947f2d4

Merge branch 'main' into cl-aTOb-doc

1b69427

igooch approved these changes May 13, 2024

View reviewed changes

pkg/util/runtime/features.go Outdated Show resolved Hide resolved

review change

2304c31

igooch enabled auto-merge (squash) May 13, 2024 20:57

markmandel reviewed May 13, 2024

View reviewed changes

markmandel approved these changes May 13, 2024

View reviewed changes

Merge branch 'main' into cl-aTOb-doc

d595403

Kalaiselvi84 added 2 commits May 14, 2024 19:07

review change

04fbaa7

Merge branch 'cl-aTOb-doc' of https://github.com/Kalaiselvi84/agones …

a977d0c

…into cl-aTOb-doc

Merge branch 'main' into cl-aTOb-doc

06f7312

igooch merged commit 7d168a4 into googleforgames:main May 15, 2024
4 checks passed

Kalaiselvi84 added kind/documentation Documentation for Agones and removed kind/other labels Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Steps to Promote SDK Features from Alpha to Beta #3814

Steps to Promote SDK Features from Alpha to Beta #3814

Kalaiselvi84 commented May 8, 2024

agones-bot commented May 9, 2024

agones-bot commented May 9, 2024

agones-bot commented May 10, 2024

igooch left a comment

Kalaiselvi84 commented May 13, 2024

igooch left a comment

agones-bot commented May 13, 2024

agones-bot commented May 13, 2024

agones-bot commented May 13, 2024

markmandel left a comment

markmandel left a comment

agones-bot commented May 14, 2024

agones-bot commented May 14, 2024

agones-bot commented May 14, 2024

agones-bot commented May 14, 2024

agones-bot commented May 14, 2024

agones-bot commented May 15, 2024

Steps to Promote SDK Features from Alpha to Beta #3814

Steps to Promote SDK Features from Alpha to Beta #3814

Conversation

Kalaiselvi84 commented May 8, 2024

agones-bot commented May 9, 2024

agones-bot commented May 9, 2024

agones-bot commented May 10, 2024

igooch left a comment

Choose a reason for hiding this comment

Kalaiselvi84 commented May 13, 2024

igooch left a comment

Choose a reason for hiding this comment

agones-bot commented May 13, 2024

agones-bot commented May 13, 2024

agones-bot commented May 13, 2024

markmandel left a comment

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented May 14, 2024

agones-bot commented May 14, 2024

agones-bot commented May 14, 2024

agones-bot commented May 14, 2024

agones-bot commented May 14, 2024

agones-bot commented May 15, 2024