CountsAndLists: Move to Beta Protobuf #3806

Kalaiselvi84 · 2024-04-25T22:34:19Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Work on #3775

Special notes for your reviewer:
This PR moves all the Counterss & Lists functions from Alpha to Beta protobuf and updates the relevant files accordingly.

agones-bot · 2024-04-25T22:38:15Z

Build Failed 😱

Build Id: 640cac2f-ffa9-44a1-adcf-a9788175c20d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-26T00:07:08Z

Build Failed 😱

Build Id: f08bc5be-9e32-4f30-85e6-95646559ec44

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-04-26T19:01:47Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-04-26T19:09:18Z

Build Failed 😱

Build Id: 93751a5f-07b2-4894-a3c6-27485c905fb3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-04-26T20:48:44Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-04-26T20:56:35Z

Build Failed 😱

Build Id: 55a07fe2-c82f-424e-8f7f-0c97f17f224f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-04-29T19:21:23Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-04-29T19:27:20Z

Build Failed 😱

Build Id: a991d1e6-0f1b-43b0-aa98-819a6204f421

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-04-29T19:27:38Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2024-04-29T19:29:10Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-04-29T19:35:16Z

Build Failed 😱

Build Id: 89743056-63db-43a0-b2bc-0c86c068ab75

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

…ing function

github-actions · 2024-04-29T19:47:38Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2024-04-29T19:53:27Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-04-29T19:53:42Z

Build Failed 😱

Build Id: 543b08cc-ffcb-4c0b-b60c-5ff4e2c5a19d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-01T03:35:26Z

Build Failed 😱

Build Id: e52b4a9c-cbf8-414b-9bca-618a53ea1e73

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2024-05-01T04:40:30Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-05-01T06:01:03Z

Build Failed 😱

Build Id: a380570f-664b-42f2-ab3d-1645aab5a2a2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-05-01T16:49:28Z

Build Failed 😱

Build Id: 6d2c3dfc-72d7-49f6-b717-2ba9968400d9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Kalaiselvi84 · 2024-05-01T17:02:39Z

I will push a new tag for simple-game-server to the registry.

github-actions · 2024-05-01T18:39:33Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-05-01T19:44:09Z

Build Succeeded 👏

Build Id: 8e3b6175-a420-41a9-b881-759b8e8b5025

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://53092ca-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3806/head:pr_3806 && git checkout pr_3806
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-53092ca-amd64

igooch

LGTM. @markmandel did you want to take a last look?

We still need to update documentation, which can be done as part of a different PR.

github-actions · 2024-05-01T23:35:23Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-05-02T00:37:54Z

Build Succeeded 👏

Build Id: c511495e-d89f-4391-8c33-93500cb6f916

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://65941e8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3806/head:pr_3806 && git checkout pr_3806
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-65941e8-amd64

github-actions · 2024-05-02T04:20:24Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-05-02T05:58:03Z

Build Succeeded 👏

Build Id: 72f356ef-4c4e-4d55-9819-098338d14c06

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://c881e22-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3806/head:pr_3806 && git checkout pr_3806
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-c881e22-amd64

github-actions · 2024-05-02T16:45:12Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-05-02T19:15:12Z

Build Succeeded 👏

Build Id: 2f29c3bd-cd6b-4bf8-96f8-8c3b8f744116

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://72373ed-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3806/head:pr_3806 && git checkout pr_3806
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-72373ed-amd64

github-actions · 2024-05-02T20:31:34Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-05-02T22:36:29Z

Build Succeeded 👏

Build Id: 24bc4229-768a-4e5e-930a-9401ef3e4b12

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://9a3c66b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3806/head:pr_3806 && git checkout pr_3806
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.41.0-dev-9a3c66b-amd64

zmerlynn · 2024-05-03T12:46:19Z

I'm going to go ahead and merge this since it's so wide - @markmandel if you wsnt to follow up we still have the rest of the release. :)

Great job, @Kalaiselvi84 and @igooch !

steven-supersolid · 2024-05-13T08:35:18Z

sdks/nodejs/lib/alpha/alpha_grpc_pb.js

Just for posterity but this removed functions from the file and there is no corresponding addition to a beta_grpc_pb.js - in fact that file is not generated yet

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.40.0` -> `1.41.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.41.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1410-2024-06-04) [Compare Source](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.40.0...v1.41.0) **Implemented enhancements:** - Configure Allocator Status Code by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3782 - Graduate Counters and Lists to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3801 - Passthrough autopilot - Adds an AutopilotPassthroughPort Feature Gate and new pod label by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3809 - CountsAndLists: Move to Beta Protobuf by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3806 - feat: support multiple port ranges by [@nrwiersma](https://github.com/nrwiersma) in [googleforgames/agones#3747 - Changes `sdk-server` to Patch instead of Update by [@igooch](https://github.com/igooch) in [googleforgames/agones#3803 - Generate grpc for nodejs from alpha to beta by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3825 - Update CountsAndLists from Alpha to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3824 - feat(gameserver): New DirectToGameServer PortPolicy allows direct traffic to a GameServer by [@daniellee](https://github.com/daniellee) in [googleforgames/agones#3807 - Passthrough autopilot - Adds mutating webhook by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3833 - Passthrough autopilot - added ports array case and updated unit tests by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3842 - Nodejs counters and lists by [@steven-supersolid](https://github.com/steven-supersolid) in [googleforgames/agones#3726 - Promote AutopilotPassthroughPort feature gate to Alpha by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3849 **Fixed bugs:** - Helm Param Update: Default to agones.controller if agones.extensions is Missing by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3773 - fix: rollout strategy issues by [@nrwiersma](https://github.com/nrwiersma) in [googleforgames/agones#3762 - Set Minimum Buffer Size to 1 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3749 - Pin ltsc2019 to older SHA by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3829 - TestGameServerAllocationDuringMultipleAllocationClients: Readdress flake by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3831 - Refactor finalizer name to include valid domain name and path by [@indexjoseph](https://github.com/indexjoseph) in [googleforgames/agones#3840 - agones-{extensions,allocator}: Be more defensive about draining by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3839 - agones-{extensions,allocator}: Pause after cancelling context by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3843 - Change the line to modify in Quickstart: Edit a Game Server by [@peterzhongyi](https://github.com/peterzhongyi) in [googleforgames/agones#3844 **Other:** - Prep for Release v1.41.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3800 - Update site documentation to reflect firewall prefix and default to Autopilot cluster creation for Agones by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3769 - Add a System Diagram and overview page by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3792 - Update Side Menu: Preserve and Restore Scroll Position by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3805 - fix: typo by [@skmpf](https://github.com/skmpf) in [googleforgames/agones#3808 - Helm Config: Add httpUnallocatedStatusCode in Allocator Service by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3802 - Update Docs: CountersAndLists to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3810 - Disable Dev feature FeatureAutopilotPassthroughPort by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3815 - Disable FeatureAutopilotPassthroughPort in features.go by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3816 - SDK proto compatibility guarantees and deprecation policies documentation by [@igooch](https://github.com/igooch) in [googleforgames/agones#3774 - Fix dangling "as of" by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3827 - Steps to Promote SDK Features from Alpha to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3814 - Adds comment for help troubleshooting issues with terraform tfstate by [@igooch](https://github.com/igooch) in [googleforgames/agones#3822 - docs: improve counter and list example comments by [@yonbh](https://github.com/yonbh) in [googleforgames/agones#3818 - Skip /tmp/ on yamllint by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3838 - TestAllocatorAfterDeleteReplica: More logging by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3837 - Instructions for upgrading golang version by [@gongmax](https://github.com/gongmax) in [googleforgames/agones#3819 - Remove unused function FindGameServerContainer by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3841 - Adds Unreal to the List of URL Links to Not Check by [@igooch](https://github.com/igooch) in [googleforgames/agones#3847 - docs: clarify virtualization setup for Windows versions by [@andresromerodev](https://github.com/andresromerodev) in [googleforgames/agones#3850 **New Contributors:** - [@skmpf](https://github.com/skmpf) made their first contribution in [googleforgames/agones#3808 - [@yonbh](https://github.com/yonbh) made their first contribution in [googleforgames/agones#3818 - [@peterzhongyi](https://github.com/peterzhongyi) made their first contribution in [googleforgames/agones#3844 - [@andresromerodev](https://github.com/andresromerodev) made their first contribution in [googleforgames/agones#3850 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

CountsAndLists: Move to Beta Protobuf

5eb1314

Kalaiselvi84 requested review from markmandel and zmerlynn April 25, 2024 22:34

github-actions bot added kind/other size/M labels Apr 25, 2024

import client.proto

32635ac

make gen-all-sdk-grpc

7da41c5

github-actions bot added the size/XL label Apr 26, 2024

include beta files, replace alpha to beta, and remove alpha files

8c2c09e

Split alpha and beta functions and make necessary adjustments

4af6dd7

revert sdk/csharp,rust,swagger changes

1a3d81d

Kalaiselvi84 requested a review from igooch April 29, 2024 19:27

Merge branch 'main' into cl-beta-proto

a6dbc6a

Kalaiselvi84 marked this pull request as ready for review April 29, 2024 19:29

no alpha change in sdkserver.go and sdkserver_test.go for playerTrack…

f976ad9

…ing function

include sdkalpha

d7b2861

Beta in sgs/main.go

444c3af

bump sgs image

53092ca

igooch approved these changes May 1, 2024

View reviewed changes

Merge branch 'main' into cl-beta-proto

65941e8

Merge branch 'main' into cl-beta-proto

c881e22

Merge branch 'main' into cl-beta-proto

72373ed

Merge branch 'main' into cl-beta-proto

9a3c66b

zmerlynn approved these changes May 3, 2024

View reviewed changes

zmerlynn merged commit e7789b0 into googleforgames:main May 3, 2024
4 checks passed

igooch mentioned this pull request May 9, 2024

Nodejs counters and lists #3726

Merged

steven-supersolid reviewed May 13, 2024

View reviewed changes

Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CountsAndLists: Move to Beta Protobuf #3806

CountsAndLists: Move to Beta Protobuf #3806

Kalaiselvi84 commented Apr 25, 2024 •

edited

Loading

agones-bot commented Apr 25, 2024

agones-bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

agones-bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

agones-bot commented Apr 26, 2024

github-actions bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented May 1, 2024

github-actions bot commented May 1, 2024

agones-bot commented May 1, 2024

agones-bot commented May 1, 2024

Kalaiselvi84 commented May 1, 2024

github-actions bot commented May 1, 2024

agones-bot commented May 1, 2024

igooch left a comment

github-actions bot commented May 1, 2024

agones-bot commented May 2, 2024

github-actions bot commented May 2, 2024

agones-bot commented May 2, 2024

github-actions bot commented May 2, 2024

agones-bot commented May 2, 2024

github-actions bot commented May 2, 2024

agones-bot commented May 2, 2024

zmerlynn commented May 3, 2024

steven-supersolid May 13, 2024

CountsAndLists: Move to Beta Protobuf #3806

CountsAndLists: Move to Beta Protobuf #3806

Conversation

Kalaiselvi84 commented Apr 25, 2024 • edited Loading

agones-bot commented Apr 25, 2024

agones-bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

agones-bot commented Apr 26, 2024

github-actions bot commented Apr 26, 2024

agones-bot commented Apr 26, 2024

github-actions bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024

agones-bot commented Apr 29, 2024

agones-bot commented May 1, 2024

github-actions bot commented May 1, 2024

agones-bot commented May 1, 2024

agones-bot commented May 1, 2024

Kalaiselvi84 commented May 1, 2024

github-actions bot commented May 1, 2024

agones-bot commented May 1, 2024

igooch left a comment

Choose a reason for hiding this comment

github-actions bot commented May 1, 2024

agones-bot commented May 2, 2024

github-actions bot commented May 2, 2024

agones-bot commented May 2, 2024

github-actions bot commented May 2, 2024

agones-bot commented May 2, 2024

github-actions bot commented May 2, 2024

agones-bot commented May 2, 2024

zmerlynn commented May 3, 2024

steven-supersolid May 13, 2024

Choose a reason for hiding this comment

Kalaiselvi84 commented Apr 25, 2024 •

edited

Loading