Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kueue might lose fields when admitting jobs #2269

Closed
alculquicondor opened this issue May 23, 2024 · 10 comments · Fixed by #2501 or #2553
Closed

Kueue might lose fields when admitting jobs #2269

alculquicondor opened this issue May 23, 2024 · 10 comments · Fixed by #2501 or #2553
Assignees
@mbobrovskyi
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@alculquicondor
Copy link
Contributor

What happened:

Whenever Kueue APIs are a version behind the latest version for a particular job type, there is the risk of dropping fields, because of the use of Update.

We should be using Patch instead.

What you expected to happen:

Kueue to be resilient to upgrades of Job CRDs.

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Kueue version (use git describe --tags --dirty --always):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@alculquicondor alculquicondor added the kind/bug Categorizes issue or PR as related to a bug. label May 23, 2024
@alculquicondor
Copy link
Contributor Author

/assign @PBundyra

@alculquicondor
Copy link
Contributor Author

As a hotfix for jobset integration, we need to bump the version of jobset in the release-0.6 branch.

We might have to do it manually #1984

@alculquicondor alculquicondor mentioned this issue May 23, 2024
Merged
@tenzen-y
Copy link
Member

intersting. Which job types did you observe this issue?

@alculquicondor
Copy link
Contributor Author

jobset

@tenzen-y
Copy link
Member

I see. It's only JobSet. Thanks.

@alculquicondor
Copy link
Contributor Author

It could be anything, but jobset is the only API that is changing quite fast.

@tenzen-y
Copy link
Member

It could be anything, but jobset is the only API that is changing quite fast.

That makes sense.

@alculquicondor
Copy link
Contributor Author

/assign @mbobrovskyi
/unassign @PBundyra

@k8s-ci-robot k8s-ci-robot assigned mbobrovskyi and unassigned PBundyra Jun 25, 2024
@mbobrovskyi mbobrovskyi mentioned this issue Jun 28, 2024
Merged
@mimowo
Copy link
Contributor

mimowo commented Jul 9, 2024

/reopen
Let's keep it open to keep track of the outstanding work in #2553 which is not just cleanup but also semantic change from non-strict to strict patches.

@k8s-ci-robot k8s-ci-robot reopened this Jul 9, 2024
@k8s-ci-robot
Copy link
Contributor

@mimowo: Reopened this issue.

In response to this:

/reopen
Let's keep it open to keep track of the outstanding work in #2553 which is not just cleanup but also semantic change from non-strict to strict patches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mbobrovskyi mbobrovskyi mentioned this issue Jul 9, 2024
Merged
@alculquicondor alculquicondor mentioned this issue Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbobrovskyi mbobrovskyi

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
6 participants
@alculquicondor @mimowo @mbobrovskyi @k8s-ci-robot @tenzen-y @PBundyra