Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zfspv): filter grpc logs to reduce the pollution #161

Merged
merged 5 commits into from
Jun 24, 2020

Conversation

vaniisgh
Copy link
Contributor

@vaniisgh vaniisgh commented Jun 24, 2020

Why is this PR required? What issue does it fix?:
Fixes #136 , removes the NodeGetCapabilities & NodeGetVolumeStats logs.

What this PR does?:
Adds a loop in the logGRPC function

Any additional information for your reviewer? :
Locally, some tests failed, I cant seem to locate them

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:

Signed-off-by: vaniisgh vanisingh@live.co.uk

Signed-off-by: vaniisgh <vanisingh@live.co.uk>
@vaniisgh vaniisgh changed the title - changes to reduce filter logs Enhancement(Local-PV): Filter logs for GRPC Jun 24, 2020
pkg/driver/grpc.go Outdated Show resolved Hide resolved
pkg/driver/grpc.go Outdated Show resolved Hide resolved
pkg/driver/grpc.go Outdated Show resolved Hide resolved
pkg/driver/grpc.go Outdated Show resolved Hide resolved
pkg/driver/grpc.go Outdated Show resolved Hide resolved
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
>
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   22.65%   22.65%           
=======================================
  Files          14       14           
  Lines         490      490           
=======================================
  Hits          111      111           
  Misses        378      378           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b13a04...9bac8a6. Read the comment docs.

pkg/driver/grpc.go Outdated Show resolved Hide resolved
pkg/driver/grpc.go Outdated Show resolved Hide resolved
pkg/driver/grpc.go Outdated Show resolved Hide resolved
pkg/driver/grpc.go Outdated Show resolved Hide resolved
pkg/driver/grpc.go Outdated Show resolved Hide resolved
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: vaniisgh <vanisingh@live.co.uk>
@vaniisgh
Copy link
Contributor Author

I've updated the change-log, I hope it looks ok ? :)

@@ -0,0 +1 @@
adds a filter for grpc logs to reduce pollution in zfs-node caused by filtering NodeGetVolumeStats & NodeGetCapabilities calls
Copy link
Contributor

@pawanpraka1 pawanpraka1 Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us just keep it : adds a filter for grpc logs to reduce the pollution

Copy link
Contributor Author

@vaniisgh vaniisgh Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, this seemed to verbose anyway :), I'm sorry I missed adding the newline again though, realized too late.

@pawanpraka1 pawanpraka1 changed the title Enhancement(Local-PV): Filter logs for GRPC Enhancement(zfspv): Filter logs for GRPC Jun 24, 2020
@pawanpraka1 pawanpraka1 changed the title Enhancement(zfspv): Filter logs for GRPC feat(zfspv): Filter logs for GRPC Jun 24, 2020
@pawanpraka1 pawanpraka1 changed the title feat(zfspv): Filter logs for GRPC feat(zfspv): filter grpc logs to reduce the pollution Jun 24, 2020
@pawanpraka1 pawanpraka1 added feature Need community involvement Needs community involvement on some action item. labels Jun 24, 2020
@pawanpraka1 pawanpraka1 added this to the v0.9 milestone Jun 24, 2020
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
@pawanpraka1 pawanpraka1 merged commit 13ec77c into openebs:master Jun 24, 2020
@pawanpraka1
Copy link
Contributor

@vaniisgh would you like to work on #135 also?

@vaniisgh
Copy link
Contributor Author

vaniisgh commented Jun 24, 2020

yes, :) but ... It might take me a few days to get to it if that's ok?

@pawanpraka1
Copy link
Contributor

Thanks @vaniisgh . No problem, whenever you get time.

@vaniisgh vaniisgh deleted the reduceLogPollution branch June 24, 2020 21:48
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need community involvement Needs community involvement on some action item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce the log noise for ZFS-LocalPV
3 participants