-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zfspv): filter grpc logs to reduce the pollution #161
Conversation
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Signed-off-by: vaniisgh <vanisingh@live.co.uk> >
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
=======================================
Coverage 22.65% 22.65%
=======================================
Files 14 14
Lines 490 490
=======================================
Hits 111 111
Misses 378 378
Partials 1 1 Continue to review full report at Codecov.
|
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. can you add a changelog in this PR https://github.com/openebs/zfs-localpv/blob/master/CONTRIBUTING.md#adding-a-changelog. See the example here :- https://github.com/openebs/zfs-localpv/blob/master/changelogs/unreleased/121-pawanpraka1
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
I've updated the change-log, I hope it looks ok ? :) |
changelogs/unreleased/161-vaniisgh
Outdated
@@ -0,0 +1 @@ | |||
adds a filter for grpc logs to reduce pollution in zfs-node caused by filtering NodeGetVolumeStats & NodeGetCapabilities calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let us just keep it : adds a filter for grpc logs to reduce the pollution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, this seemed to verbose anyway :), I'm sorry I missed adding the newline again though, realized too late.
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
yes, :) but ... It might take me a few days to get to it if that's ok? |
Thanks @vaniisgh . No problem, whenever you get time. |
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
Why is this PR required? What issue does it fix?:
Fixes #136 , removes the NodeGetCapabilities & NodeGetVolumeStats logs.
What this PR does?:
Adds a loop in the logGRPC function
Any additional information for your reviewer? :
Locally, some tests failed, I cant seem to locate them
Checklist:
<type>(<scope>): <subject>
Signed-off-by: vaniisgh vanisingh@live.co.uk