Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(btrfs): fixing duplicate UUID issue with btrfs #172

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Jul 2, 2020

fixes : #169

Continuation of the PR #170

Signed-off-by: Pawan pawan@mayadata.io

Why is this PR required? What issue does it fix?:

btrfs, like xfs, needs to generate a new UUID for the
cloned volumes. All the devices with the same UUID will be treated
same for btrfs.

What this PR does?:

generating the new UUID for the cloned volumes using btrfstune command.

Does this PR require any upgrade changes?:

no

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@pawanpraka1 pawanpraka1 added the bug Something isn't working. label Jul 2, 2020
@pawanpraka1 pawanpraka1 added this to the v0.9 milestone Jul 2, 2020
@pawanpraka1 pawanpraka1 requested a review from kmova July 2, 2020 05:33
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #172 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   22.65%   22.65%           
=======================================
  Files          14       14           
  Lines         490      490           
=======================================
  Hits          111      111           
  Misses        378      378           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051f26f...4abab26. Read the comment docs.

btrfs, like xfs, needs to generate a new UUID for the
cloned volumes. All the devices with the same UUID will be treated
same for btrfs, so here generating the new UUID for the cloned volumes
using btrfstune command.

Signed-off-by: Pawan <pawan@mayadata.io>
@kmova kmova merged commit 8b7ad5c into openebs:master Jul 3, 2020
@pawanpraka1 pawanpraka1 deleted the btrfs branch July 4, 2020 15:10
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 9, 2020
pawanpraka1 added a commit to pawanpraka1/zfs-localpv that referenced this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BTRFS support in fsType
4 participants