feat(zfspv) Add golint check to travis #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
reviewed
Jul 4, 2020
pawanpraka1
reviewed
Jul 4, 2020
vaniisgh
force-pushed
the
fixLinting
branch
2 times, most recently
from
6f60615 to
b52e014
Compare
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 22.65% 22.88% +0.23%
==========================================
Files 14 14
Lines 490 485 -5
==========================================
Hits 111 111
+ Misses 378 373 -5
Partials 1 1
Continue to review full report at Codecov.
|
pawanpraka1
added
enhancement
pawanpraka1
reviewed
Jul 6, 2020
|
I think it should be better now :) but I cant till if the |
vaniisgh
force-pushed
the
fixLinting
branch
5 times, most recently
from
deb5f9d to
43d7286
Compare
pawanpraka1
reviewed
Jul 7, 2020
pawanpraka1
reviewed
Jul 7, 2020
pawanpraka1
reviewed
Jul 7, 2020
pawanpraka1
reviewed
Jul 7, 2020
pawanpraka1
reviewed
Jul 7, 2020
pawanpraka1
reviewed
Jul 7, 2020
pawanpraka1
reviewed
Jul 7, 2020
pawanpraka1
reviewed
Jul 7, 2020
|
@pawanpraka1 yes just making these changes, I think changelog is updated in the PR already. Should I change it ? so updated everything else, hope it looks ok :) |
Signed-off-by: vaniisgh <vanisingh@live.co.uk> - update typos & names Signed-off-by: vaniisgh <vanisingh@live.co.uk>
pawanpraka1
reviewed
Jul 7, 2020
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
Signed-off-by: vaniisgh <vanisingh@live.co.uk>
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 9, 2020
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
7 tasks
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 9, 2020
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 13, 2020
Following PR added for changelog - openebs#166 - openebs#171 - openebs#172 - openebs#164 - openebs#160 - openebs#167 - openebs#170 - openebs#161 - openebs#174 - openebs#175 Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 21, 2020
Instead of checking for the finalizer, checking for the volume state to be ready is more intuitive before mounting it. Also removed duplicate if statement for btrfs which was added while resolveing the merge conflict in openebs#175. Signed-off-by: Pawan <pawan@mayadata.io>
7 tasks
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Jul 21, 2020
Instead of checking for the finalizer, checking for the volume state to be ready is more intuitive before mounting it. Also removed duplicate if statement for btrfs which was added while resolveing the merge conflict in openebs#175. Signed-off-by: Pawan <pawan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Jul 22, 2020
Instead of checking for the finalizer, checking for the volume state to be ready is more intuitive before mounting it. Also removed duplicate if statement for btrfs which was added while resolveing the merge conflict in #175. Signed-off-by: Pawan <pawan@mayadata.io>
pawanpraka1
added a commit
to pawanpraka1/zfs-localpv
that referenced
this pull request
Aug 10, 2020
Instead of checking for the finalizer, checking for the volume state to be ready is more intuitive before mounting it. Also removed duplicate if statement for btrfs which was added while resolveing the merge conflict in openebs#175. Signed-off-by: Pawan <pawan@mayadata.io>
kmova
pushed a commit
that referenced
this pull request
Aug 10, 2020
Instead of checking for the finalizer, checking for the volume state to be ready is more intuitive before mounting it. Also removed duplicate if statement for btrfs which was added while resolveing the merge conflict in #175. Signed-off-by: Pawan <pawan@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaniisgh vanisingh@live.co.uk
Why is this PR required? What issue does it fix?:
Fixes #168
What this PR does?:
Fixes all golint warnings and adds make golint target to travis
Any additional information for your reviewer? :
There's this linting issue that happens golang/lint#210
I fixed it bu just exporting the names
I think there could be a better way to do it ... please review :)
Checklist:
<type>(<scope>): <subject>