forked from binary-com/deriv-app
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate svg to bvi dvl #88
Merged
shaheer-deriv
merged 39 commits into
fixes_for_svg_migration
from
migrate_svg_to_bvi_dvl
Oct 27, 2023
Merged
Migrate svg to bvi dvl #88
shaheer-deriv
merged 39 commits into
fixes_for_svg_migration
from
migrate_svg_to_bvi_dvl
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: set form values * fix: common formating function * fix: add id * fix: aa * fix: account signup * fix: revert unrelated file change * fix: test case * fix: revert eslint fix on unrelated files * fix: revert eslint fix on unrelated files * fix: revert eslint fix on unrelated files * fix: merge master * fix: function to common * fix: mobile * fix: validation * fix: add optional parameter * fix: eslint * chore: merge master
Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* chore: update proper type and cleanup * chore: cleanup * chore: add more proper types * chore: add url routing for external platform * chore: update links to mt5 and derivx
…erification pages (binary-com#10952) * fix: withdrawal verification pages ui inconsistencies * fix: withdrawal verification pages ui inconsistencies * fix: withdrawal verification pages ui inconsistencies * fix: changed description format * fix: wrapped text in wallet text component * fix: applied comment * fix: wallets action screen description conditional rendering * fix: description in withdrawal request
* chore: backup * feat: added trade modal for derived variant * chore: reverted test changes * chore: reverted test changes * chore: incorporated code reviews * chore: incorporated review changes * chore: incorporated review changes
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* chore: real flow without password * chore: remove variable * chore: updated the flow as per new real flow design * chore: added new label in the real flow * chore: success message not matching with Figma CFDS-1237 * chore: remove the CT prefic from login id * chore: remove the hardcoded logic and added in config * chore: update the arrow function and removed variable declaration * chore: update web terminal link for QA testing * chore: added account id in trade modal and traders hub * chore: added ctrader in Notes section of cashier * chore: updated the ctrader url * chore: updated the production url for cTrdaer * chore: updated the function to pick url * chore: removing duplicate function from shared
…ty) (binary-com#10965) * style: 💄 add height transition with opacity * fix: fixed the height issue for desktop wallets-cashier-content (#41) --------- Co-authored-by: Aum Bhatt <125039206+aum-deriv@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…for-dark-mode Utkarsha/migration banner for dark mode
fix: 🐞 fixes for svg migration bugs
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* chore: update proper type and cleanup * chore: cleanup * chore: add more proper types * chore: realign the width to follow production
* chore: non-refactored non-available trade types processing * chore: temporary ts-expect-error * refactor: cleaned non_available contracts processor * refactor: filtering types in contract-type-widget.tsx * test: updated tests * feat: added unavailable trade types info banner * chore: improved styles for banner * test: packages/trader/src/Modules/Trading/Containers/__tests__/contract-type.spec.jsx * test: updated tests + hiding info banner when all filtered categories available * test: contract-type-menu.spec.tsx * docs: added a comment * build: trigger circle-ci * fix: types * fix: add clean up for contract categories * refactor: getCleanedUpCategories * fix: styles + add wrapper * fix: styles
…#10893) * feat: `TransactionStatus` * refactor: better styles * refactor: better appearance * refactor: `CancelTransactionModal` * refactor: minor changes everywhere * refactor: apply suggestions * Update packages/wallets/src/features/cashier/modules/TransactionStatus/components/CancelTransactionModal/CancelTransactionModal.tsx Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> * refactor: apply suggestions * refactor: `React.FC` convention * refactor: add comment, remove `size=md` * refactor: add comment and empty line * feat: cancel transaction * refactor: css bem * refactor: fill the gaps in functionality * refactor: add css classes prefix * refactor: align with binary-com#10697 * refactor: fix mutation in `CancelTransactionModal` * refactor: `wallets-` prefix in css * Merge branch 'master' into rostislav/wall-560/crypto-deposit-transaction-status * refactor: apply suggestions * refactor: `Divider` * refactor: divider appearance fix * refactor: join mappers in ./utils into one * refactor: css bem * fix: sonarcloud * refactor: move logic from mapper to css * refactor: remove unused css * refactor: further simplify mapper --------- Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com>
…#11006) * feat: modify loader component * fix: updated css
* chore: added test case for route-prompt-dialog * chore: updated test case * chore: updated to using getByRole instead of getByText * chore: removed isMobile
* fix: added step index on bot and disabled it for quick strategy * chore: using common config for disabled submarket and symbol
* feat: setup cro virtual signup tracking flow * fix: update analytics package on core * fix: types on trader package * chore: updaete package-lock * chore: update analytics package * chore: update track calls * chore: migrate rudderstack track to analytics * chore: update types for analytics * chore: update track calls * chore: update analytics package * fix: type errors on contract type * chore: add analytics initialization * chore: update package version * fix: type error on trade-store * fix: failing coverall pipeline * chore: update package version * chore: use identify event for identity tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.