This repository has been archived by the owner on Mar 31, 2024. It is now read-only.
Fix tests for leadfoot element wrapper #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [discover] implement k7Breadcrumbs * [docViewer] Add breadcrumb for doc viewer * [docViewer] nest doc viewer under discover * [discover] include index/id of doc in context/doc viewer
## Summary This PR updates the security management routes to provide k7Breadcrumbs used by the new header navigation. See elastic#25884 for general information about the integration with the router and elastic#25689 for the breadcrumb taxonomy  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
* Added asset picker to image upload arg form * Added button to create image element in asset manager * Added hover style * Extracted image upload forms into separate components * Fixed new image element with no assets bug * Fixed import * Removed unused styles * Fixed import order * Scrolls to selected asset * Fixed asset selector * Extracts workpad loader from list of trays
* Adding in browser info to the report-info drawer * Conditionalizes the browser-type panel prints + constantizes jobTypes * Fixing config feedback lost in force push
* [graph] implement k7Breadcrumbs * [graph] implement real k7Breadcrumbs * hide workspace title in local nav in k7design
* Plugin test readme’s * clarify * Update scripts/README.md Co-Authored-By: Stacey-Gammon <gammon@elastic.co>
* [devTools] set k7Breadcrumbs * [errors] add k7Breadcrumbs to error routes * revert changes to error templates for style * fix br tags
* Added clear function that returns null context * Added return type to clear function
* [APM] fixes elastic#23560 by separating frame headers from code preview and only displaying code preview when stackframe has source code context * [APM] fixes elastic#26239 by checking for valid line number before displaying it * [APM] Converted CodePreview and Stacktace to typescript and consolidated Stackframe types * [APM] pull out components and util functions into own files and added tests
* [spaces/management] implement k7Breadcrumbs * [spaces/management] avoid relying directly on breadcrumbs in ManageSpacePage
## Summary Closes elastic#25896 Adds K7 breadcrumbs to Canvas, particularly for the "home" and "workpad" sections of the app. It also adds a simple redux middle to keep the workpad name in the breadcrumb in sync with the input in the interface. 
* [@elastic/datemath] add .npmignore file * bump @elastic/datemath versions
* Translate ui -> query_bar * Fix id names * Update snapshots * Fix tests * Add intl to props interface * Fix test * Fix tests * Fix tests * Fix test * Fix tests
…tic#26011) * translate login/logout visualization component * Update login/logout component - change injecti18n name to injectI18n * Update login/logout component - make needed changes * update one snapshot * update login translation * update one snapshot * Fix * Fix unit test * Localize logout tooltip
…t-element-wrapper
|
Cherry-picked 42d6c25 into elastic#26406 in elastic@2120096 |
spalger
pushed a commit
that referenced
this pull request
Apr 15, 2019
* [Maps] expand/collapse Layer TOC * Design edits (#30) * fix jest test snapshots * make default isLayerTOCOpen a constant * use newly release EUI menuLeft and menuRight icons instead of arrow icon
spalger
pushed a commit
that referenced
this pull request
Apr 15, 2019
* [Maps] expand/collapse Layer TOC * Design edits (#30) * fix jest test snapshots * make default isLayerTOCOpen a constant * use newly release EUI menuLeft and menuRight icons instead of arrow icon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix unstable tests for Leadfoot element wrapper
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately