Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.5] Backports for 0.5.0-rc4 #18276

Merged
merged 48 commits into from
Sep 8, 2016
Merged

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Aug 29, 2016

will probably be the last RC

@nanosoldier runbenchmarks(ALL, vs = ":release-0.5")

Ehsan Totoni and others added 26 commits August 29, 2016 02:41
Complex int is GNU extension that Intel compiler does not
support currently. #17145
(cherry picked from commit b94da94)
…non-Pair return type

(cherry picked from commit eb95919)
ref #17968
this works to avoid having `Expr(:invoke)` creating
unintentional copies of LambdaInfo objects when they show
up in the system image

fix #18184

(cherry picked from commit b0e692a)
ref #18191
…_list

many types are easy to compute during deserialization,
and don't need the full complexity of the flagref list to handle them
some of these are easy to detect ahead-of-time,
saving a small amount of deserialization effort

(cherry picked from commit 649ce88)
ref #18191
Fixes a crash while loading ASTInterpreter

(cherry picked from commit 2a8e892)
ref #18191
* improve string docs to define String etc

* tweak

(cherry picked from commit 3ab4d76)
this gives the caller more control over when an how errors get printed

(cherry picked from commit 5abccb6)
ref #18150
…pile caches

this ensures that we only recompile a dependency if either:
it can be loaded into the current session, or
the user explicitly requests it (via reload)

thereby reducing the occurrences and improving the accuracy
of the "uuid didn't match" error message :)

(cherry picked from commit 0df6e61)
ref #18150
…#17873)

This makes it possible to solve problems with semidefinite B via explicit
shift.
(cherry picked from commit f95b8b1)
The permissions specified in MapViewOfFile specify the maximum permissions
the file can ever have, which means that even permissions bypass by the
debugger is not allowed to write it. Instead, set the maximum permissions
to RWX and VirtualProtect down to the permissions we need. This is the same
behavior as we use on Mac/Linux.

(cherry picked from commit 4f1ba0c)
ref #18083
* Preserve meta node and line number info during dead code elimination
* Insert `:push_loc` and `:pop_loc` in pairs during lowering

Fix #16578

(cherry picked from commit b929c56)
ref #18180
Also clean up `julia_const_to_llvm` to avoid boxing due to `getfield`.

Fix #18236

(cherry picked from commit c4093ba)
ref #18238
Closes #18231.
(cherry picked from commit 2961c4d)
(cherry picked from commit 8a70e13)
ref #18269
@ufechner7
Copy link

Is it known, why the Travis CI build failed?

@davidanthoff
Copy link
Contributor

Is there some way that others can help to get RC4 out? Also, might it make sense to just release RC4 as is, and if more problems show up, just do a RC5? We've been going with RC3 for two weeks now, and essentially that means that a lot of potential testers are not testing the latest bits.

@tkelman
Copy link
Contributor Author

tkelman commented Sep 5, 2016

Help determine what's causing the regressions identified by packageevaluator. I'm not tagging an RC with known regressions, so will revert the precompilation changes if that's the necessary fix.

@bicycle1885
Copy link
Member

The problem of Cairo.jl seems to have nothing to do with this change. In a clean environment on my OS X of this branch, I saw the same error as JuliaGraphics/Cairo.jl#148. I believe this is a problem of BinDeps.jl. The problem happens on v0.5-RC3, too.

@bicycle1885
Copy link
Member

I couldn't reproduce the test failure of Complementarity.jl. It seems to be under active development and there are two minor releases after the Package evaluator (https://github.com/chkwon/Complementarity.jl/releases). So, I guess the problem is not in Julia but in the tests of Complementarity.jl.

@lobingera
Copy link

lobingera commented Sep 6, 2016

@bicycle1885 Could you clarify which Cairo failure you see here? If i look into this #18276 (comment) i get the impression that runtest.jl fails with a signal(11) - and not the BinDeps problem you mention. I had a similar failure trying to build some PR for Cairo and indentified this as a memory management / GC problem, which is mostlikely a Cairo internal problem and was hidden by some 'other' gc behaviour.

ViralBShah and others added 7 commits September 6, 2016 10:52
(cherry picked from commit 83b0589)
ref #18301

Update OpenBLAS to v0.2.19 for Power8.

(cherry picked from commit 857469d)
* Avoid aliasing in in UniformScaling*AbstractMatrix

...and remove unnecessary UniformScaling*SparseMatrixCSC methods

* Broaden the tests for non-commutative multiplication

* Add Quaternion test case for q*[q] and clean up the Quaternion test type

(cherry picked from commit cd94c99)
* Fix #18189 (Add deprecation of  etc. to NEWS)

* Remove mentioning of @static, add as a note

* Added reference to Handling Operating System Variation section in manual

* Changed reference numbers

* Change PR number

(cherry picked from commit 1af52d0)
(cherry picked from commit 00cb3f7)
ref #18345
* Removed confusing array of types in readcsv

* Restored brackets to `T` in readcsv doc and added clarifying text

* genstdlib rst output for docstring change.

(cherry picked from commit 22cc7a5)
errors when running test/math.jl and test/misc.jl on the same worker

(cherry picked from commit b3d2f30)
ref #18373
@tkelman
Copy link
Contributor Author

tkelman commented Sep 6, 2016

Am hoping that #18366 will fix the issue. Once that PR has addressed its review I'll backport it in here and run pkgeval again, fingers crossed.

(cherry picked from commit f50dd6a)
@tkelman
Copy link
Contributor Author

tkelman commented Sep 6, 2016

@ufechner7

Is it known, why the Travis CI build failed?

I can't recall having seen this error before, but it looks intermittent. Not sure what it is or whether it also would occur on master.

    From worker 9:       * spawn                       [stdio passthrough ok]
    From worker 8:       * sorting               in  85.87 seconds, maxrss  625.10 MB
    From worker 9:  Test Failed
    From worker 9:    Expression: desc == "Pipe(open => active, 0 bytes waiting)"
    From worker 9:     Evaluated: "Pipe(open => active, 9 bytes waiting)" == "Pipe(open => active, 0 bytes waiting)"

@vtjnash
Copy link
Member

vtjnash commented Sep 6, 2016

looks like there's a race in that test

@tkelman
Copy link
Contributor Author

tkelman commented Sep 7, 2016

Yes. If we see it again, should open an issue for it.

My pkgeval run last night froze on several packages doing Pkg.build on Cairo, but it happened for both rc3 and rc4 so it's not a regression, just a nasty bug that needs fixing. Running again, hopefully won't freeze this time.

vtjnash and others added 2 commits September 7, 2016 16:14
also add plenty of helpful debugging information enabled by the environment variable:
JULIA_DEBUG_LOADING

this bug would cause compilation to become confused
and likely tardy at recompiling files when it should
that would up with longer dependency chains where one
of the files had been updated

this is a fix for #18150
(cherry picked from commit 718bd3e)
@tkelman
Copy link
Contributor Author

tkelman commented Sep 8, 2016

A fair amount going on here, but does look like the precompilation issue is mostly gone - https://gist.github.com/6715eba41378cb57642b79255d86a723

  • AmplNLWriter has a bunch of huge C++ test dependencies and most likely ran out of time and got terminated
  • Unexpected HTTP status code: 500 network failures during clone for Anasol, ApproxFun, GeneralizedSampling, GeneticAlgorithms, and OpenGL (Anasol was the only one of these that wasn't already failing on rc3)
  • BlsData is flaky and gets a Request to BLS failed with message 'REQUEST_NOT_PROCESSED' failure intermittently, not a Julia problem
  • Cairo failed with Error in /home/vagrant/julia/bin/julia': double free or corruption (!prev): 0x00000000028464c0 ***\n\nsignal (6): Aborted\nwhile loading /home/vagrant/.julia/v0.5/Cairo/samples/sample_imagepattern.jl, in expression starting on line 29` which is most likely a problem in the package itself, should be looked at but I don't think it's a Julia regression
  • ImageQuilting failed with a real error that I can reproduce outside of pkgeval TypeError: Tuple: in non-final parameter, expected Type{T}, got Type{Vararg{ParserCombinator.Transform,N}}\n in _include_from_serialized(::String) at ./loading.jl:150\n in _require_from_serialized(::Int64, ::Symbol, ::String, ::Bool) at ./loading.jl:187\n in _require_search_from_serialized(::Int64, ::Symbol, ::String, ::Bool) at ./loading.jl:217 but I think it's the only one
  • NEOS is flaky and gets a LoadError: XML-RPC failed\n in _send(::NEOS.NEOSServer, ::String) at /home/vagrant/.julia/v0.5/NEOS/src/NEOSServer.jl:46 intermittently, not a Julia problem

@lobingera
Copy link

@tkelman I agree with your decision that the orignal problem is in the memory management of Cairo.jl (and libcairo). My assumption (without any background on details) is, work on GC has corrected something and now a hidden Cairo.jl problem surfaces. I can not currently spend time on debugging this.

@tkelman tkelman merged commit e1d2965 into release-0.5 Sep 8, 2016
@tkelman tkelman deleted the tk/backports-0.5.0-rc4 branch September 8, 2016 05:47
@tkelman
Copy link
Contributor Author

tkelman commented Sep 8, 2016

@staticfloat took the Linux buildbots down to rebuild gcc for dmlc/MXNet.jl#138. Not the best timing, that should've waited until after this RC. Can't build binaries until they're back up.

@tkelman
Copy link
Contributor Author

tkelman commented Sep 9, 2016

buildbots came back and the post-gcc-upgrade binaries look okay (thanks @staticfloat), so rc4 has been tagged and uploaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.