-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.5] Backports for 0.5.0-rc4 #18276
Conversation
(cherry picked from commit d14155b)
* improve string docs to define String etc * tweak (cherry picked from commit 3ab4d76)
…pile caches this ensures that we only recompile a dependency if either: it can be loaded into the current session, or the user explicitly requests it (via reload) thereby reducing the occurrences and improving the accuracy of the "uuid didn't match" error message :) (cherry picked from commit 0df6e61) ref #18150
(cherry picked from commit f3fe910)
(cherry picked from commit f58aaef)
The permissions specified in MapViewOfFile specify the maximum permissions the file can ever have, which means that even permissions bypass by the debugger is not allowed to write it. Instead, set the maximum permissions to RWX and VirtualProtect down to the permissions we need. This is the same behavior as we use on Mac/Linux. (cherry picked from commit 4f1ba0c) ref #18083
ref staticfloat/homebrew-julia@f57dcc2#diff-633fd9f8448015391714f35e04d39b5bL154 [av skip] (cherry picked from commit ad73afa)
Is it known, why the Travis CI build failed? |
Is there some way that others can help to get RC4 out? Also, might it make sense to just release RC4 as is, and if more problems show up, just do a RC5? We've been going with RC3 for two weeks now, and essentially that means that a lot of potential testers are not testing the latest bits. |
Help determine what's causing the regressions identified by packageevaluator. I'm not tagging an RC with known regressions, so will revert the precompilation changes if that's the necessary fix. |
The problem of Cairo.jl seems to have nothing to do with this change. In a clean environment on my OS X of this branch, I saw the same error as JuliaGraphics/Cairo.jl#148. I believe this is a problem of BinDeps.jl. The problem happens on v0.5-RC3, too. |
I couldn't reproduce the test failure of Complementarity.jl. It seems to be under active development and there are two minor releases after the Package evaluator (https://github.com/chkwon/Complementarity.jl/releases). So, I guess the problem is not in Julia but in the tests of Complementarity.jl. |
@bicycle1885 Could you clarify which Cairo failure you see here? If i look into this #18276 (comment) i get the impression that runtest.jl fails with a signal(11) - and not the BinDeps problem you mention. I had a similar failure trying to build some PR for Cairo and indentified this as a memory management / GC problem, which is mostlikely a Cairo internal problem and was hidden by some 'other' gc behaviour. |
* Avoid aliasing in in UniformScaling*AbstractMatrix ...and remove unnecessary UniformScaling*SparseMatrixCSC methods * Broaden the tests for non-commutative multiplication * Add Quaternion test case for q*[q] and clean up the Quaternion test type (cherry picked from commit cd94c99)
* Removed confusing array of types in readcsv * Restored brackets to `T` in readcsv doc and added clarifying text * genstdlib rst output for docstring change. (cherry picked from commit 22cc7a5)
Am hoping that #18366 will fix the issue. Once that PR has addressed its review I'll backport it in here and run pkgeval again, fingers crossed. |
(cherry picked from commit f50dd6a)
I can't recall having seen this error before, but it looks intermittent. Not sure what it is or whether it also would occur on master.
|
looks like there's a race in that test |
Yes. If we see it again, should open an issue for it. My pkgeval run last night froze on several packages doing Pkg.build on Cairo, but it happened for both rc3 and rc4 so it's not a regression, just a nasty bug that needs fixing. Running again, hopefully won't freeze this time. |
also add plenty of helpful debugging information enabled by the environment variable: JULIA_DEBUG_LOADING this bug would cause compilation to become confused and likely tardy at recompiling files when it should that would up with longer dependency chains where one of the files had been updated this is a fix for #18150 (cherry picked from commit 718bd3e)
A fair amount going on here, but does look like the precompilation issue is mostly gone - https://gist.github.com/6715eba41378cb57642b79255d86a723
|
@tkelman I agree with your decision that the orignal problem is in the memory management of Cairo.jl (and libcairo). My assumption (without any background on details) is, work on GC has corrected something and now a hidden Cairo.jl problem surfaces. I can not currently spend time on debugging this. |
@staticfloat took the Linux buildbots down to rebuild gcc for dmlc/MXNet.jl#138. Not the best timing, that should've waited until after this RC. Can't build binaries until they're back up. |
buildbots came back and the post-gcc-upgrade binaries look okay (thanks @staticfloat), so rc4 has been tagged and uploaded |
will probably be the last RC
@nanosoldier
runbenchmarks(ALL, vs = ":release-0.5")