Create vdbc_acura_ilx_2016_nidec.dbc #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file now follow the Vector dbc format. Byte order is now correctly set in the big endian format (motorola). IDs are now in decimal. Added the node list that was missing. Added the NEO node (which is follow some of the ADAS behavior). Mapped all signals to a receiver node.
|
Can you merge these into one pull request? What is the NEO node? Also, do these DBCs work with openpilot? If so, can we overwrite the ones in there? I like the idea of using the proper standard. |
|
I will merge everything in one pull. The NEO is the Comma NEO :) When the ADAS is no longer there, he's being promoted as the transmitter and receiver for some messages in place of the ADAS. So for some messages, you have two transmitters right now, but we could remove the ADAS since it's not supposed to be there when the NEO is installed. Those DBC won't probably work with the openpilot , since I made changes that could affect the behavior (mostly the byte ordering). I've put them in a separate directory for this reason. I could check the code and make the changes to make them work. I just didn't know if it was something you were already working on. Let me know if you want me to do it. Then we could get rid of the previous dbcs and use only these new files.Everything will then be with the proper standard as these dbc files can be used in wide variety of software as it's the most popular CAN database format. The editor, CANdb++, is free also . |
|
Would love to have openpilot read the standard, let me know if it doesn't for some reason and we'll fix that bug. |
|
I will work on it then! |
Chrispreilly
pushed a commit
to c-reilly/openpilot-2012camryhybrid
that referenced
this pull request
Nov 14, 2018
Update alca params for Honda for smoother lane change
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this pull request
Jun 30, 2019
Toyota Prius: bug fix in toyota_safety
pd0wm
pushed a commit
that referenced
this pull request
Apr 1, 2020
35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 35040fe
pd0wm
pushed a commit
that referenced
this pull request
Apr 2, 2020
35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 35040fe
pd0wm
pushed a commit
that referenced
this pull request
May 8, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 8, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 8, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 10, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 10, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 11, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
Thaixican
pushed a commit
to Thaixican/openpilot
that referenced
this pull request
May 15, 2020
65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (commaai#40) 35040fe Update service documentation (commaai#39) 8f13dfc Additional car params auto-detection in support of VW (commaai#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 65af436
weimou
pushed a commit
to SFtoLA/openpilot
that referenced
this pull request
May 6, 2021
* Add enum for installed location in car network * Add electric vehicle/direct drive to transmission enum * Better naming of direct-drive variant
carleeno
pushed a commit
to carleeno/openpilot
that referenced
this pull request
Aug 2, 2024
* ui: speedometer customizations * change param name * bruh * cereal: fix duplicate ordinals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file now follow the Vector dbc format.
Byte order is now correctly set in the big endian format (motorola).
IDs are now in decimal.
Added the node list that was missing.
Added the NEO node (which is follow some of the ADAS behavior).
Mapped all signals to a receiver node.