DBC modified to match the Vector format #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested the encode() function in dbc.py and it work with the modified DBC in BE. It give the same result as with the LE byte ordering. The code always treat the data as if it's encoded in BE and the byte encoding in the DBC file has no effect in this function. This also mean that the dbc.py encode() function lack the ability to treat the LE byte ordering correctly. This should be corrected. |
|
Internal tests pass. Yea, dbc should work with LE. Will do a drive later today, will merge if good. |
|
Drove, seems good! |
avolmensky
pushed a commit
to avolmensky/openpilot
that referenced
this pull request
Jun 10, 2019
Selected gear, 4 bit value
pd0wm
pushed a commit
that referenced
this pull request
Apr 6, 2020
e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: e370f79
pd0wm
pushed a commit
that referenced
this pull request
Apr 7, 2020
e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: e370f79
pd0wm
pushed a commit
that referenced
this pull request
Apr 8, 2020
e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: e370f79
pd0wm
pushed a commit
that referenced
this pull request
Apr 8, 2020
93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 93ccbcb
pd0wm
pushed a commit
that referenced
this pull request
Apr 9, 2020
93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 93ccbcb
pd0wm
pushed a commit
that referenced
this pull request
Apr 9, 2020
975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 975a633
pd0wm
pushed a commit
that referenced
this pull request
May 8, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 8, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 8, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 10, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 10, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
pd0wm
pushed a commit
that referenced
this pull request
May 11, 2020
12aad06 no more c capnp 0050e0a stockFcw event 2c325ed gasPressed event 8573a24 don't duplicate ordinals 3f384ef add carState.steerWarning and carState.steerError 8b347b0 add repeated warning2 3adb899 add sharpness metric 65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (#40) 35040fe Update service documentation (#39) 8f13dfc Additional car params auto-detection in support of VW (#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 12aad06
Thaixican
pushed a commit
to Thaixican/openpilot
that referenced
this pull request
May 15, 2020
65af436 Add relayMalfunction alert 442e914 add preview driver flag c8e5db8 Add comment to faulttype 975a633 Add all panda fault types to health 93ccbcb UiLayoutState: add mockEngaged for onboarding 9dbbb54 UiLayoutState: add 'none' app c820f83 Add offroadLayout service e370f79 Add the laneChangeBlocked Event (commaai#40) 35040fe Update service documentation (commaai#39) 8f13dfc Additional car params auto-detection in support of VW (commaai#38) 22986de add speedTooHigh alert f515e4d Add invalid lkas setting alert 5908762 gnustl_shared is only for android b0c746b solve by renaming event name instead of service df82a53 the service is called androidLogEntry git-subtree-dir: cereal git-subtree-split: 65af436
PNTABryan
pushed a commit
to PNTABryan/openpilot
that referenced
this pull request
Sep 22, 2020
* Enable EngineRPM and steeringTorque for GM * Update interface.py
weimou
pushed a commit
to SFtoLA/openpilot
that referenced
this pull request
May 6, 2021
If there is something in the way. Create alert for User to know why it can not lane change currently
carleeno
pushed a commit
to carleeno/openpilot
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.