Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(2/N) Pre-release data QC #417

Closed
wants to merge 178 commits into from
Closed

(2/N) Pre-release data QC #417

wants to merge 178 commits into from

Conversation

zzgeng
Copy link

@zzgeng zzgeng commented Jul 14, 2023

Purpose/implementation Section

What scientific question is your analysis addressing?

quality control of v13 data

What was your approach?

Methylation-related data is downloaded following the code change in this PR (#415).
Delete snv_dgd related code and run analyses/data-pre-release-qc module

What GitHub issue does your pull request address?

#395

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

analyses/data-pre-release-qc/results
01-data-harmonization-qc.Rmd

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

Table

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@zzgeng zzgeng requested a review from jharenza July 14, 2023 15:37
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have some samples which are not in histologies and need to be removed from these merge matrices. In the meantime, could you stack this PR on #413 and update the one bit for sourcing data from /data

analyses/data-pre-release-qc/01-data-harmonization-qc.Rmd Outdated Show resolved Hide resolved
@jharenza jharenza changed the base branch from dev to download_script July 14, 2023 19:00
Copy link
Member

@jharenza jharenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzgeng for line 9, can you use Sys.Date() here so that the date of the run prints out in the HTML file. Also can you go through and fix the few "histologies" typos ("histolgies") and revert back to using the data folder?

zzgeng and others added 27 commits November 27, 2023 13:15
Analysis update: Add CRANIO subtyping workflow to README
Analysis update: add DMG, EGFR to methyl mol subtype
Analysis Update: Add EWS subtyping workflow to README
Update analysis: Update age cutoff for CRANIO, PAP
Analysis update: Add workflow for HGG molecular subtyping
Analysis update: Add NBL workflow to README
Analysis update: Add EPN workflow to README
Analysis update: Add MB workflow
Analysis update: Add embryonal workflow to README
@jharenza
Copy link
Member

jharenza commented Dec 5, 2023

@zzgeng maybe we should close this and open a new one stacked on the v13 release pr so it's cleaner

@zzgeng zzgeng closed this Dec 6, 2023
@zzgeng zzgeng deleted the pre-release_QC branch December 6, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants