-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(2/N) Pre-release data QC #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have some samples which are not in histologies and need to be removed from these merge matrices. In the meantime, could you stack this PR on #413 and update the one bit for sourcing data from /data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zzgeng for line 9, can you use Sys.Date()
here so that the date of the run prints out in the HTML file. Also can you go through and fix the few "histologies" typos ("histolgies") and revert back to using the data folder?
Analysis update: Add CRANIO subtyping workflow to README
Analysis update: add DMG, EGFR to methyl mol subtype
Analysis Update: Add EWS subtyping workflow to README
Update analysis: Update age cutoff for CRANIO, PAP
Analysis update: Add workflow for HGG molecular subtyping
Analysis update: Add NBL workflow to README
Analysis update: Add EPN workflow to README
Analysis update: Add MB workflow
Add workflow to LGG README
Analysis update: Add embryonal workflow to README
update cancer group
add PXA to molecular subtype
@zzgeng maybe we should close this and open a new one stacked on the v13 release pr so it's cleaner |
Purpose/implementation Section
What scientific question is your analysis addressing?
quality control of v13 data
What was your approach?
Methylation-related data is downloaded following the code change in this PR (#415).
Delete snv_dgd related code and run
analyses/data-pre-release-qc
moduleWhat GitHub issue does your pull request address?
#395
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
analyses/data-pre-release-qc/results
01-data-harmonization-qc.Rmd
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
Table
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.