Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(ast_tools): do not use ref in matches #6674

Merged
merged 1 commit into from
Oct 19, 2024
Merged

style(ast_tools): do not use ref in matches #6674

merged 1 commit into from
Oct 19, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 19, 2024 •
edited
Loading

Style nit.

@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Oct 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite Graphite

This was referenced Oct 19, 2024
Merged
Merged
Merged
@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 19, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 19, 2024 08:46
@overlookmotel
Copy link
Contributor Author

@ottomated FYI: Of course there's nothing wrong with using ref in matches, it's just not our "house style".

@overlookmotel
Copy link
Contributor Author

Trivial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 19, 2024
@overlookmotel overlookmotel force-pushed the 10-19-style_ast_tools_fix_formatting branch from 2423655 to a47b38f Compare October 19, 2024 08:50
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Oct 19, 2024 •
edited
Loading

Merge activity

  • Oct 19, 4:51 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 19, 4:51 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 19, 5:01 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 10-19-style_ast_tools_do_not_use_ref_in_matches branch from a2611e1 to 33d2557 Compare October 19, 2024 08:53
@overlookmotel overlookmotel mentioned this pull request Oct 19, 2024
Merged
Base automatically changed from 10-19-style_ast_tools_fix_formatting to main October 19, 2024 08:56
@overlookmotel overlookmotel force-pushed the 10-19-style_ast_tools_do_not_use_ref_in_matches branch from 33d2557 to 002289b Compare October 19, 2024 08:57
@graphite-app graphite-app bot merged commit 002289b into main Oct 19, 2024
15 checks passed
@graphite-app graphite-app bot deleted the 10-19-style_ast_tools_do_not_use_ref_in_matches branch October 19, 2024 09:01
This was referenced Oct 19, 2024
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel