Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): use spaces not tabs in TS type defs #6682

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 19, 2024

Follow-on after #6404. Use spaces instead of tabs in TS type defs, to match the code style wasm_bindgen uses for the types it generates.

Copy link

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_use_double_quotes_in_ts_type_defs branch from 6205d3a to 9ca8f75 Compare October 19, 2024 09:33
@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools labels Oct 19, 2024
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_use_spaces_not_tabs_in_ts_type_defs branch from e1c7f40 to af4c74e Compare October 19, 2024 09:34
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 19, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 19, 2024 09:38
Copy link

codspeed-hq bot commented Oct 19, 2024

CodSpeed Performance Report

Merging #6682 will not alter performance

Comparing 10-19-refactor_ast_tools_use_spaces_not_tabs_in_ts_type_defs (e4e1deb) with 10-19-refactor_ast_tools_use_double_quotes_in_ts_type_defs (01b9e83)

Summary

✅ 30 untouched benchmarks

Copy link
Contributor

@ottomated ottomated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, do we care about matching wasm-bindgen's style? When this is being rendered as a text file directly it'll have a formatting step run on it so this seems unnecessary

@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_use_double_quotes_in_ts_type_defs branch from 9ca8f75 to 01b9e83 Compare October 19, 2024 20:08
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_use_spaces_not_tabs_in_ts_type_defs branch from af4c74e to e4e1deb Compare October 19, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants