Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast_tools): ability to generate text files #6686

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 19, 2024

This was originally in #6404 but I pulled it out to reduce that PR's diff.

Add ability (currently unused) to output arbitrary text files from oxc_ast_tools generators.

Copy link

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor

@ottomated ottomated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed Raw to Text

@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_give_generatoroutput_named_fields branch from 6939e4e to fc46118 Compare October 20, 2024 20:51
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_ability_to_generate_text_files branch from b45d850 to d3eb2ac Compare October 20, 2024 20:53
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 20, 2024
Copy link
Contributor Author

overlookmotel commented Oct 20, 2024

Merge activity

  • Oct 20, 4:55 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 20, 5:26 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 20, 5:36 PM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_give_generatoroutput_named_fields branch from fc46118 to 2de2a1e Compare October 20, 2024 21:18
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_ability_to_generate_text_files branch from d3eb2ac to b3dd45f Compare October 20, 2024 21:18
This was originally in #6404 but I pulled it out to reduce that PR's diff.

Add ability (currently unused) to output arbitrary text files from `oxc_ast_tools` generators.
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_give_generatoroutput_named_fields branch from 2de2a1e to 136029e Compare October 20, 2024 21:29
@overlookmotel overlookmotel force-pushed the 10-19-feat_ast_tools_ability_to_generate_text_files branch from b3dd45f to 902a3d0 Compare October 20, 2024 21:29
Base automatically changed from 10-19-refactor_ast_tools_give_generatoroutput_named_fields to main October 20, 2024 21:34
@graphite-app graphite-app bot merged commit 902a3d0 into main Oct 20, 2024
16 checks passed
@graphite-app graphite-app bot deleted the 10-19-feat_ast_tools_ability_to_generate_text_files branch October 20, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants