-
-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wasm): remove type defs for ArrayExpressionElement
and Elision
#6683
fix(wasm): remove type defs for ArrayExpressionElement
and Elision
#6683
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on Graphite |
e1c7f40
to
af4c74e
Compare
8938d54
to
a798ae6
Compare
ArrayExpressionElement
ArrayExpressionElement
and Elision
a798ae6
to
13f22eb
Compare
@ottomated This is the most substantial change in this stack of PRs. The change is correct, but implementation is maybe a bit hacky. You may see a better way to achieve this. |
CodSpeed Performance ReportMerging #6683 will not alter performanceComparing Summary
|
af4c74e
to
e4e1deb
Compare
13f22eb
to
e865bb8
Compare
e865bb8
to
0234904
Compare
0234904
to
ca8b12c
Compare
#6683) Follow-on after #6404. `ArrayExpressionElement` and `Elision` are not used in the TS types, because `ArrayExpression` has an override for the field it uses. https://github.com/oxc-project/oxc/blob/002289b4b1b0d6fac080c4b12f4939c8f455272f/crates/oxc_ast/src/ast/js.rs#L293-L302 Prevent these TS type defs being emitted by introducing a new `#[estree(custom_ts_def)]` attr, to go with `#[estree(custom_serialize)]`.
ca8b12c
to
53049fe
Compare
Merge activity
|
Follow-on after #6404.
ArrayExpressionElement
andElision
are not used in the TS types, becauseArrayExpression
has an override for the field it uses.oxc/crates/oxc_ast/src/ast/js.rs
Lines 293 to 302 in 002289b
Prevent these TS type defs being emitted by introducing a new
#[estree(custom_ts_def)]
attr, to go with#[estree(custom_serialize)]
.