Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): move #[allow] attrs to top of generated files #6679

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 19, 2024

Follow-on after #6404. Shorten generated code for impl Serialize by moving #[allow] attrs to top of file.

Copy link

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 19, 2024
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_move_allow_attrs_to_top_of_generated_files branch from 467ebec to cb29f0d Compare October 19, 2024 09:33
@overlookmotel overlookmotel marked this pull request as ready for review October 19, 2024 09:42
Copy link

codspeed-hq bot commented Oct 19, 2024

CodSpeed Performance Report

Merging #6679 will not alter performance

Comparing 10-19-refactor_ast_tools_move_allow_attrs_to_top_of_generated_files (9ba2b0e) with main (2eb984a)

Summary

✅ 30 untouched benchmarks

Copy link
Contributor

@ottomated ottomated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering if this was possible, thanks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 19, 2024
Copy link

graphite-app bot commented Oct 19, 2024

Merge activity

…6679)

Follow-on after #6404. Shorten generated code for `impl Serialize` by moving `#[allow]` attrs to top of file.
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_shorten_code branch from 66ed87a to f0dd19a Compare October 19, 2024 19:51
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_move_allow_attrs_to_top_of_generated_files branch from cb29f0d to 9ba2b0e Compare October 19, 2024 19:52
Base automatically changed from 10-19-refactor_ast_tools_shorten_code to main October 19, 2024 20:02
@graphite-app graphite-app bot merged commit 9ba2b0e into main Oct 19, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 10-19-refactor_ast_tools_move_allow_attrs_to_top_of_generated_files branch October 19, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants