Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): shorten generated code by avoiding ref in matches #6675

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Oct 19, 2024

Follow-on after #6404.

Shorten generated code for deriving ESTree by avoiding ref in matches.

Copy link

graphite-app bot commented Oct 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 19, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 19, 2024 08:47
@overlookmotel overlookmotel force-pushed the 10-19-style_ast_tools_do_not_use_ref_in_matches branch from a2611e1 to 33d2557 Compare October 19, 2024 08:53
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches branch from 7779992 to 5f35384 Compare October 19, 2024 08:53
@overlookmotel overlookmotel force-pushed the 10-19-style_ast_tools_do_not_use_ref_in_matches branch from 33d2557 to 002289b Compare October 19, 2024 08:57
Base automatically changed from 10-19-style_ast_tools_do_not_use_ref_in_matches to main October 19, 2024 09:01
Copy link

codspeed-hq bot commented Oct 19, 2024

CodSpeed Performance Report

Merging #6675 will not alter performance

Comparing 10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches (11458a5) with main (2eb984a)

Summary

✅ 30 untouched benchmarks

Copy link
Contributor

@ottomated ottomated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, it's fine with me—this existed to match serde's output as close as possible

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 19, 2024 — with Graphite App
Copy link

graphite-app bot commented Oct 19, 2024

Merge activity

…hes (#6675)

Follow-on after #6404.

Shorten generated code for deriving `ESTree` by avoiding `ref` in matches.
@overlookmotel overlookmotel force-pushed the 10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches branch from 6e356e9 to 11458a5 Compare October 19, 2024 19:50
@graphite-app graphite-app bot merged commit 11458a5 into main Oct 19, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 10-19-refactor_ast_tools_shorten_generated_code_by_avoiding_ref_in_matches branch October 19, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants