refactor(ast_tools): give GeneratorOutput and SideEffect named fields
#6685
+33
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-ast-tools
overlookmotel
changed the title
GeneratorOutput named fieldsGeneratorOutput and SideEffect named fields
This was referenced Oct 19, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
This was referenced Oct 19, 2024
ottomated
approved these changes
Oct 19, 2024
overlookmotel
force-pushed
the
10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_
branch
from
13f22eb to
e865bb8
Compare
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_give_generatoroutput_named_fields
branch
from
8281e5d to
6939e4e
Compare
rzvxa
approved these changes
Oct 20, 2024
overlookmotel
force-pushed
the
10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_
branch
from
e865bb8 to
0234904
Compare
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_give_generatoroutput_named_fields
branch
from
6939e4e to
fc46118
Compare
overlookmotel
added
the
0-merge
Graphite App
Merge activity
|
overlookmotel
force-pushed
the
10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_
branch
from
0234904 to
ca8b12c
Compare
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_give_generatoroutput_named_fields
branch
from
fc46118 to
2de2a1e
Compare
overlookmotel
force-pushed
the
10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_
branch
from
ca8b12c to
53049fe
Compare
Base automatically changed from
10-19-fix_wasm_remove_type_def_for_arrayexpressionelement_
to
main
October 20, 2024 21:28
…elds (#6685) Pure refactor. Named fields are clearer.
overlookmotel
force-pushed
the
10-19-refactor_ast_tools_give_generatoroutput_named_fields
branch
from
2de2a1e to
136029e
Compare
graphite-app
bot
deleted the
10-19-refactor_ast_tools_give_generatoroutput_named_fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Named fields are clearer.