Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dnae adas/intraprocess manager support for serialized message #1076

Open
wants to merge 122 commits into
base: rolling
Choose a base branch
from
Open

Dnae adas/intraprocess manager support for serialized message #1076

wants to merge 122 commits into from
+458 −103

Commits on Apr 22, 2020

  1. * updated interface to SubscriptionIntraProcessBase 

    * implemented interface to deserialize a given serialized message to ros message

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    9d88f0e View commit details
    Browse the repository at this point in the history

  2. added support for SerializedMessage in Intraprocessmanger, so: 

     * serialized publisher uses correct method to forward content to subscriber
 * non-serialized publisher can serialize message for serialized subscriber

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    1dad3ad View commit details
    Browse the repository at this point in the history

  3. updated unit test for intraprocess manager to match new interface 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    c552c0b View commit details
    Browse the repository at this point in the history

  4. updated is_serialized_message_class traits 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    2513cc2 View commit details
    Browse the repository at this point in the history

  5. renamed provide_serialized_intra_process_message to provide_intra_pro… 

    …cess_message

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    fd6a20e View commit details
    Browse the repository at this point in the history

  6. fixed Serialization class for non-supported type (yes this is actuall… 

    …y needed for the next PR)

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    f0c8dd3 View commit details
    Browse the repository at this point in the history

  7. updated to (de)seriaizle method 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    facb43d View commit details
    Browse the repository at this point in the history

  8. fix build regression (ros2#1078) 

    Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    @dirk-thomas
    dirk-thomas authored and Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    08a3251 View commit details
    Browse the repository at this point in the history

  9. Reflect changes in rclcpp API (ros2#1079) 

    * Reflect changes in rclcpp API

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Revert earlier fix made in rclcpp

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>
    Prajakta Gokhale authored and Joshua Hampp committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    0577f39 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. * added get_type_support_handle to rclcpp::Serialization 

    * removed specialization to rclcpp::Serialization

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    0bf988a View commit details
    Browse the repository at this point in the history

  2. extended subscription_intra_process(_base): 

     * allocate message
 * getter for serialization
 * provide untyped message

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    7a73179 View commit details
    Browse the repository at this point in the history

  3. update unit test for subscription_intra_process(_base) 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    167ae5f View commit details
    Browse the repository at this point in the history

  4. extended intra_process_manager for serialized messages: 

     * two extra subscription/publisher pairs (for serialized ones)
 * added methods for (de)serialization
 * added methods for messages without known allocator
 * splitted up publishing with same type and not matching message type

Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    372df2a View commit details
    Browse the repository at this point in the history

  5. simplified code 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    a771a22 View commit details
    Browse the repository at this point in the history

  6. fixed modifier 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    71bcd07 View commit details
    Browse the repository at this point in the history

  7. updated comments 

    Signed-off-by: Joshua Hampp <j.hampp@denso-adas.de>
    Joshua Hampp committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    4480d4e View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Generate node interfaces' getters and traits. (ros2#1069) 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Co-authored-by: Karsten Knese <karsten@openrobotics.org>
    @hidmic @Karsten1987
    2 people authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fd7c268 View commit details
    Browse the repository at this point in the history

  2. Fix rclcpp interface traits test (ros2#1086) 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    de69944 View commit details
    Browse the repository at this point in the history

  3. Integrate topic statistics (ros2#1072) 

    * Add SubscriberTopicStatistics class

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add SubscriberTopicStatistics Test

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Modify constructor to allow a node to create necessary components

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix docstring style

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove SetPublisherTimer method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Change naming style to match rclcpp

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address style issues

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Use rclcpp:Time

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove unnecessary check for null publisher timer
Move anonymous namespace function to private class method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update message dependency

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Initial integration of Subscriber Topic Statistics

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix nanoseconds used for Topic Stats

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add simple publishing test
Minor fixes

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add test utils header

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Integrate with Topic Statistics options
Fixes after rebasing with master

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update after rebasing

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address minor review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Move Topic Statistics instantiation to create_subscription

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix rebase issue
Fix topic statistics enable flag usage
Address minor formatting

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Move new timer creation method to relevant header

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Add timers interface to topic interface

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Use new create timer method

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    @dabonnie
    dabonnie authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e9d19a0 View commit details
    Browse the repository at this point in the history

  4. Use serialized message (ros2#1081) 

    * use serialized message in callback

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* introduce resize method for serialized message

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* introduce release for serialized message

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* address review comments

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* correct typo

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* fix interface traits test

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    801cb25 View commit details
    Browse the repository at this point in the history

  5. Remove unused test variable (ros2#1087) 

    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    @dabonnie
    dabonnie authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    90626d1 View commit details
    Browse the repository at this point in the history

  6. protect subscriber_statistics_collectors_ with a mutex (ros2#1084) 

    * subscriber_statistics_collectors_ should be protected with mutex.

Co-Authored-By: William Woodall <william+github@osrfoundation.org>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya @wjwwood
    2 people authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7bf74f9 View commit details
    Browse the repository at this point in the history

  7. adapt subscription traits to rclcpp::SerializedMessage (ros2#1092) 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    564e0e4 View commit details
    Browse the repository at this point in the history

  8. Ensure logging is initialized just once (ros2#998) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    3b892e2 View commit details
    Browse the repository at this point in the history

  9. export targets in a addition to include directories / libraries (ros2… 

    …#1088)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    @dirk-thomas
    dirk-thomas authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    c347232 View commit details
    Browse the repository at this point in the history

  10. deprecate redundant namespaces (ros2#1083) 

    * deprecate redundant namespaces, move classes to own files, rename some classes

Signed-off-by: William Woodall <william@osrfoundation.org>

* fixup

Signed-off-by: William Woodall <william@osrfoundation.org>

* address review comments

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix ups since rebase

Signed-off-by: William Woodall <william@osrfoundation.org>

* avoid deprecation warnings from deprecated functions

Signed-off-by: William Woodall <william@osrfoundation.org>

* more fixes

Signed-off-by: William Woodall <william@osrfoundation.org>

* another fixup, after another rebase

Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    56a7285 View commit details
    Browse the repository at this point in the history

  11. Add received message age metric to topic statistics (ros2#1080) 

    * Add received message age metric to topic statistics

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Add unit tests

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Add IMU messages in unit test

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Use system time instead of steady time
Test received message age stats values are greater than 0

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix test warnings

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Replace IMU messages with new dummy messages

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Remove outdated TODO and unused test variables

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Re-add message with header for unit testing

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Address message review feedback

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Remove extra newline

Signed-off-by: Prajakta Gokhale <prajaktg@amazon.com>

* Address more review feedback

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Fix Windows failure

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Only set append_library_dirs once

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    Prajakta Gokhale authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    2981fb8 View commit details
    Browse the repository at this point in the history

  12. Add serialized_message.hpp header (ros2#1095) 

    Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    5793c07 View commit details
    Browse the repository at this point in the history

  13. export targets in a addition to include directories / libraries (ros2… 

    …#1096)

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    @dirk-thomas
    dirk-thomas authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8f34d88 View commit details
    Browse the repository at this point in the history

  14. Enforce a precedence for wildcard matching in parameter overrides. (r… 

    …os2#1094)

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    64a2f14 View commit details
    Browse the repository at this point in the history

  15. Serialized message move constructor (ros2#1097) 

    * correct use of move semantics

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* more tests

Signed-off-by: Knese Karsten <karsten@openrobotics.org>

* make error message more exact

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* use std::exchange

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* fix typo

Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4e4a17c View commit details
    Browse the repository at this point in the history

  16. Added rclcpp_components Doxyfile (ros2#1091) 

    * Added rclcpp components Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a4a97de View commit details
    Browse the repository at this point in the history

  17. Increasing test coverage of rclcpp_action (ros2#1043) 

    * Increasing test coverage of rclcpp_action

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Increasing test coverage of rclcpp_action

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Fix warnings

Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1521181 View commit details
    Browse the repository at this point in the history

  18. 0.9.0

    @jacobperron
    jacobperron authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8f96a03 View commit details
    Browse the repository at this point in the history

  19. Update comment about return value in Executor::get_next_ready_executa… 

    …ble (ros2#1085)

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
    @christophebedard
    christophebedard authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    084afd6 View commit details
    Browse the repository at this point in the history

  20. Increasing test coverage of rclcpp_lifecycle (ros2#1045) 

    Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    481b2d2 View commit details
    Browse the repository at this point in the history

  21. Use RCL_RET_SERVICE_TAKE_FAILED and not RCL_RET_CLIENT_TAKE_FAILED wh… 

    …en checking a request take (ros2#1101)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    f59a8a6 View commit details
    Browse the repository at this point in the history

  22. Added Quality declaration: rclcpp, rclpp_action, rclcpp_components an… 

    …drclcpp_lifecycle (ros2#1100)

* Added Quality declaration: rclcpp, rclpp_action, rclcpp_components, rclcpp_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7abaa23 View commit details
    Browse the repository at this point in the history

  23. Added docblock in rclcpp (ros2#1103) 

    * Added docblock in rclcpp

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1337714 View commit details
    Browse the repository at this point in the history

  24. Fix tests that were not properly torn down (ros2#1073) 

    Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    @dabonnie
    dabonnie authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8fc0c37 View commit details
    Browse the repository at this point in the history

  25. Added rclcpp lifecycle Doxyfile (ros2#1089) 

    * Added rclcpp lifecycle Doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed doxyfile

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    3b7ba2e View commit details
    Browse the repository at this point in the history

  26. Changelog. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8b238e6 View commit details
    Browse the repository at this point in the history

  27. 0.9.1

    @clalancette
    clalancette authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    674cf40 View commit details
    Browse the repository at this point in the history

  28. avoid callback_group deprecation (ros2#1108) 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1404c23 View commit details
    Browse the repository at this point in the history

  29. Mark flaky test with xfail: TestMultiThreadedExecutor (ros2#1109) 

    Signed-off-by: Louise Poubel <louise@openrobotics.org>
    @chapulina
    chapulina authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    0ed3ad1 View commit details
    Browse the repository at this point in the history

  30. Make sure to include what you use. (ros2#1112) 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    3f4980c View commit details
    Browse the repository at this point in the history

  31. use rosidl_default_generators dependency in test (ros2#1114) 

    Signed-off-by: Karsten Knese <karsten@openrobotics.org>
    @Karsten1987
    Karsten1987 authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a0a727f View commit details
    Browse the repository at this point in the history

  32. Increasing test coverage of rclcpp_components (ros2#1044) 

    * Increasing test coverage of rclcpp_components

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* PR fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Fixup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Removing throws test for now

Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    767f542 View commit details
    Browse the repository at this point in the history

  33. Remove MANUAL_BY_NODE liveliness API (ros2#1107) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a568829 View commit details
    Browse the repository at this point in the history

  34. 1.0.0

    @jacobperron
    jacobperron authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    ea6024e View commit details
    Browse the repository at this point in the history

  35. Update QDs to reflect version 1.0 (ros2#1115) 

    Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    63e6d43 View commit details
    Browse the repository at this point in the history

  36. Added dockblock to ComponentManager class (ros2#1102) 

    * Added dockblock to ComponentManager class

Signed-off-by: ahcorde <ahcorde@gmail.com>

* added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    bdd88a3 View commit details
    Browse the repository at this point in the history

  37. [Quality Declaration] Fixed rep links and added more details to depen… 

    …dencies (ros2#1116)

* Fixed rep links and added more details to dependencies

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed rep link

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    73355da View commit details
    Browse the repository at this point in the history

  38. Make test multi threaded executor more reliable (ros2#1105) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4608485 View commit details
    Browse the repository at this point in the history

  39. Added features to rclcpp packages (ros2#1106) 

    * Added features to rclcpp packages

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback and improved lifecycle docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added ffedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixing error

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    efe2eab View commit details
    Browse the repository at this point in the history

  40. [rclcpp] API review March 2020 (ros2#1031) 

    * API review part 1

Signed-off-by: William Woodall <william@osrfoundation.org>

* update pre second meeting

Signed-off-by: William Woodall <william@osrfoundation.org>

* notes from 2020-03-23 meeting

Signed-off-by: William Woodall <william@osrfoundation.org>

* online review comments

Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    750754d View commit details
    Browse the repository at this point in the history

  41. Deprecate ClientGoalHandle::async_result() (ros2#1120) 

    Fixes ros2#955

There are currently two public APIs for users to get the result of a goal.
This change deprecates one of the APIs, which was considered to be unsafe as
it may result in a race with user-code and raise an exception.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    375de01 View commit details
    Browse the repository at this point in the history

  42. remove empty lines within method signatures (ros2#1128) 

    Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    @dirk-thomas
    dirk-thomas authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    90c71e6 View commit details
    Browse the repository at this point in the history

  43. [rclcpp_action] Action client holds weak pointers to goal handles (ro… 

    …s2#1122)

* [rclcpp_action] Action client holds weak pointers to goal handles

Fixes ros2#861

It is against the design of ROS actions to rely on the status topic for the core implementation,
instead it should just be used for introspection.

Rather than relying on the status topic to remove references to goal handles, the action client
instead holds weak pointers to the goal handles. This way as long as a user holds a reference to
the goal handle they can use it to interact with the action client.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Move cleanup logic to the end of the function

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Add TODO

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Log debug messages when dropping a weak references to goal handles

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Improve documentation

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    b1b525b View commit details
    Browse the repository at this point in the history

  44. Make sure rmw_publisher_options is initialized in to_rcl_publisher_op… 

    …tions. (ros2#1099)

Signed-off-by: ChenYing Kuo <evshary@gmail.com>
    @evshary
    evshary authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    55854a7 View commit details
    Browse the repository at this point in the history

  45. Fix thread safety issues related to logging (ros2#1125) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    db772b5 View commit details
    Browse the repository at this point in the history

  46. expose get_service_names_and_types_by_node from rcl in rclcpp (ros2#1131 

    )

* expose get_service_names_and_types_by_node from rcl in rclcpp

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* fix spelling

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* zero initialize

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* check return value and cleanup

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* use throw_from_rcl_error

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* cleanup error handling

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    @dirk-thomas
    dirk-thomas authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    11cb640 View commit details
    Browse the repository at this point in the history

  47. add add_on and remove_on 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    5077e1b View commit details
    Browse the repository at this point in the history

  48. add } 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    76518eb View commit details
    Browse the repository at this point in the history

  49. remove return from void fn 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7619d2c View commit details
    Browse the repository at this point in the history

  50. revert 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    13607a5 View commit details
    Browse the repository at this point in the history

  51. reduce line length 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    33d926f View commit details
    Browse the repository at this point in the history

  52. Deprecate set_on_parameters_set_callback (ros2#1123) 

    * add deprecate statement
* replace tests to use add_on_param fn
* deprecate set_on_pram fn in node_parameters
* deprecate in lifecycle_node and add replacement fn
* update documentation
* add warning suppression to test_node.cpp
* correct namespace in lifecycle_node.cpp
* remove whitespace fix line length in lifecycle_node
* move reset fn to below add_on
* deprecate set_on in test_lifecycle_node
* suppress deprecation warning in node.cpp
* suppress warning in lifecycle_node.cpp

Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4b3ef4c View commit details
    Browse the repository at this point in the history

  53. 1.1.0

    @jacobperron
    jacobperron authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8ea6b90 View commit details
    Browse the repository at this point in the history

  54. Fix potential Construction/Destruction order problem between global c… 

    …ontexts vector and Context of static lifetime (ros2#1132)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    88fa179 View commit details
    Browse the repository at this point in the history

  55. Fix test_lifecycle_node.cpp:check_parameters (ros2#1136) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e72a6a7 View commit details
    Browse the repository at this point in the history

  56. Fix lock-order-inversion (potential deadlock) (ros2#1135) 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8abba2c View commit details
    Browse the repository at this point in the history

  57. Improved rclcpp docblock (ros2#1127) 

    * Improved rclcpp docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Improved docblock

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Included feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    9730ca7 View commit details
    Browse the repository at this point in the history

  58. Make the rcl publisher handle a shared pointer. 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    dbd7c2c View commit details
    Browse the repository at this point in the history

  59. Hold onto the rcl_{subscription,publisher}_t shared_ptr. 

    This keeps it from going out of scope while the executor
is still dealing with QoSEvents.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7a6db00 View commit details
    Browse the repository at this point in the history

  60. Make sure the Waitable class has a virtual destructor. 

    Noticed while reviewing this issue.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    580892b View commit details
    Browse the repository at this point in the history

  61. SubscriptionBase::get_subscription_handle() const should return a s… 

    …hared pointer to const value (ros2#1140)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e7763e9 View commit details
    Browse the repository at this point in the history

  62. Pass shared pointer by value instead than by const & when possible (r… 

    …os2#1141)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    488732f View commit details
    Browse the repository at this point in the history

  63. Add missing header in logging_mutex.cpp (ros2#1145) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    535bac7 View commit details
    Browse the repository at this point in the history

  64. Add Security Vulnerability Policy pointing to REP-2006. (ros2#1130) 

    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    @clalancette
    clalancette authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    316faf1 View commit details
    Browse the repository at this point in the history

  65. Make test_rate more reliable on Windows and improve error output when… 

    … it fails (ros2#1146)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    743f643 View commit details
    Browse the repository at this point in the history

  66. Avoid multiple type topics in tests. (ros2#1150) 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1bce6fb View commit details
    Browse the repository at this point in the history

  67. Add missing virtual destructors (ros2#1149) 

    * Add -Wnon-virtual-dtor -Woverloaded-virtual compiler options

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

* Add missing virtual dtors

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

* please linter

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    6c807a6 View commit details
    Browse the repository at this point in the history

  68. changelogs 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1ddc23a View commit details
    Browse the repository at this point in the history

  69. 2.0.0

    @wjwwood
    wjwwood authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    50112e5 View commit details
    Browse the repository at this point in the history

  70. Increase rclcpp_action test coverage (ros2#1153) 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    f7bc020 View commit details
    Browse the repository at this point in the history

  71. Allow spin_until_future_complete to accept std::future (ros2#1113) 

    Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>
    @naiveHobo
    naiveHobo authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    0c8aca2 View commit details
    Browse the repository at this point in the history

  72. Revert "Allow spin_until_future_complete to accept std::future (ros2#… 

    …1113)" (ros2#1159)

This reverts commit 898a30e.
    @dirk-thomas
    dirk-thomas authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    037659c View commit details
    Browse the repository at this point in the history

  73. Fix reference to rclcpp in its QD (ros2#1161) 

    Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
    @christophebedard
    christophebedard authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    6205ecc View commit details
    Browse the repository at this point in the history

  74. Fixed doxygen warnings (ros2#1163) 

    Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7c616a1 View commit details
    Browse the repository at this point in the history

  75. Revert "Revert "Allow spin_until_future_complete to accept std::future ( 

    ros2#1113)" (ros2#1159)" (ros2#1160)

This reverts commit bba9dce.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7ef258f View commit details
    Browse the repository at this point in the history

  76. Fix spin_until_future_complete: check spinning value (ros2#1023) 

    Signed-off-by: Donghee Ye <donghee.ye@samsung.com>
    @DongheeYe
    DongheeYe authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    3afe623 View commit details
    Browse the repository at this point in the history

  77. Add check for invalid topic statistics publish period (ros2#1151) 

    * Add check for invalid topic statistics publish period

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update documentation

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address review comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Address doc formatting comments

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>

* Update doc spacing

Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
    @dabonnie
    dabonnie authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    f815d89 View commit details
    Browse the repository at this point in the history

  78. Check if context is valid when looping in spin_some (ros2#1167) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7b7e5e0 View commit details
    Browse the repository at this point in the history

  79. Reorganize test directory and split CMakeLists.txt (ros2#1173) 

    Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    b916f5d View commit details
    Browse the repository at this point in the history

  80. Add spin_all method to Executor (ros2#1156) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    e9adc3e View commit details
    Browse the repository at this point in the history

  81. add rcl_action_client_options when creating action client. (ros2#1133) 

    * add rcl_action_client_options for create_client.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

* Capitalize comments and keep the default rcl_action_client_options.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

* delete unnecessary default rcl_action_client_options_t.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    71ef44f View commit details
    Browse the repository at this point in the history

  82. Add message lost subscription event (ros2#1164) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a3f73dc View commit details
    Browse the repository at this point in the history

  83. Fix get_node_time_source_interface() docstring (ros2#988) 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    a508887 View commit details
    Browse the repository at this point in the history

  84. Check period duration in create_wall_timer (ros2#1178) 

    * Check period duration in create_wall_timer

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Adding comments

Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4f4b95d View commit details
    Browse the repository at this point in the history

  85. Changelogs 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    b8cb2fc View commit details
    Browse the repository at this point in the history

  86. 3.0.0

    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    456ffe7 View commit details
    Browse the repository at this point in the history

  87. Add create_publisher include to create_subscription (ros2#1180) 

    Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    7b53a2e View commit details
    Browse the repository at this point in the history

  88. Add unit tests for logging functionality (ros2#1184) 

    Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    98999c3 View commit details
    Browse the repository at this point in the history

  89. callback should be perfectly-forwarded. (ros2#1183) 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    2373ddf View commit details
    Browse the repository at this point in the history

  90. Unit tests for some header-only functions/classes (ros2#1181) 

    * Unit tests for header-only functions/classes

Adds coverage for:
  * any_service_callback.hpp
  * any_subscription_callback.hpp
  * create_subscription.hpp
  * create_timer.hpp

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address PR feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    88f15c7 View commit details
    Browse the repository at this point in the history

  91. Throw exception if rcl_timer_init fails (ros2#1179) 

    * Throw exception if rcl_timer_init fails

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Add bad-argument tests for GenericTimer

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Add comments

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    ec8e0d0 View commit details
    Browse the repository at this point in the history

  92. fix exception message on rcl_clock_init. (ros2#1182) 

    Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
    @fujitatomoya
    fujitatomoya authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8e7e2a2 View commit details
    Browse the repository at this point in the history

  93. Update tracetools' QL to 2 in rclcpp's QD (ros2#1187) 

    Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
    @christophebedard
    christophebedard authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    54fab8b View commit details
    Browse the repository at this point in the history

  94. Include original exception in ComponentManagerException (ros2#1157) 

    * Include original exception in ComponentManagerException

Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

* Update rclcpp_components/src/component_manager.cpp

Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
    @mbuijs @fujitatomoya
    2 people authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    76e6ee5 View commit details
    Browse the repository at this point in the history

  95. Fix pub/sub count API tests. (ros2#1203) 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    46e4a1f View commit details
    Browse the repository at this point in the history

  96. fix race in test_lifecycle_service_client (ros2#1204) 

    Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    @dirk-thomas
    dirk-thomas authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    bdcd873 View commit details
    Browse the repository at this point in the history

  97. Bump to QD to level 3 and fixed links (ros2#1158) 

    * Update quality level and links to doc

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed wording and links

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Bump QD to level 3 and fixed links

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added missing dependency rcpputils to rclcpp_components

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added missing dependency rmw to rclcpp_lifecycle

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback

Signed-off-by: ahcorde <ahcorde@gmail.com>

* changed ci_linux_coverage to nightly_linux_coverage

Signed-off-by: ahcorde <ahcorde@gmail.com>
    @ahcorde
    ahcorde authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    1f19f7c View commit details
    Browse the repository at this point in the history

  98. Fix implementation of NodeOptions::use_global_arguments() (ros2#1176) 

    `this->node_options_` might still be `nullptr` for a default initialized NodeOptions instance.
`use_global_arguments()` must return `this->use_global_arguments_`, in analogy to `NodeOptions::enable_rosout()`.

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
    @meyerj
    meyerj authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    dcb1a85 View commit details
    Browse the repository at this point in the history

  99. Fix conversion of negative durations to messages (ros2#1188) 

    * Fix conversion from negative Duration or Time to the respective message type and throw in Duration::to_rmw_time() if the duration is negative.
rmw_time_t cannot represent negative durations.

Constructors and assignment operators can be just defaulted.

Other changes are mainly cosmetical, to make conversions between signed
and unsigned types and between 32-bit and 64-bit types more explicit.

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>

* Add -Wconversion compiler option and fix implicit conversions that might alter the value

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>

* Fix usage of fixture class in some unit tests by using gtest macro TEST_F() instead of TEST().

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>

* Add compiler option -Wno-sign-conversion to fix build with Clang on macOS

Signed-off-by: Johannes Meyer <johannes@intermodalics.eu>
    @meyerj
    meyerj authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    0634cc2 View commit details
    Browse the repository at this point in the history

  100. remove deprecated set_on_parameters_set_callback function (ros2#1199) 

    Signed-off-by: claireyywang <22240514+claireyywang@users.noreply.github.com>
    @claireyywang
    claireyywang authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    42b6354 View commit details
    Browse the repository at this point in the history

  101. Remove usage of domain id in node options (ros2#1205) 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    fb3657b View commit details
    Browse the repository at this point in the history

  102. Unit tests for node interfaces (ros2#1202) 

    * Unit tests for node interfaces

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address PR Feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Address PR feedback

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Adjusting comment

Signed-off-by: Stephen Brawner <brawner@gmail.com>
    @brawner
    brawner authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    60cf113 View commit details
    Browse the repository at this point in the history

  103. link against thread library where necessary (ros2#1210) 

    Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    @dirk-thomas
    dirk-thomas authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    edd5941 View commit details
    Browse the repository at this point in the history

  104. Fix rclcpp::NodeOptions::operator= (ros2#1211) 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic authored and Joshua Hampp committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    6b41e9c View commit details
    Browse the repository at this point in the history

  105. Merge branch 'master' into dnae_adas/intraprocess_manager_support_for… 

    …_serialized_message
    @DensoADAS
    DensoADAS authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4b005c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Update rclcpp/include/rclcpp/experimental/intra_process_manager.hpp 

    Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
    @DensoADAS @Karsten1987
    DensoADAS and Karsten1987 authored Jul 27, 2020
    Configuration menu
    Copy the full SHA
    b858281 View commit details
    Browse the repository at this point in the history