Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid 1.14 updates #8

Merged
merged 20 commits into from
Jun 8, 2018
Merged

Prebid 1.14 updates #8

merged 20 commits into from
Jun 8, 2018

Commits on Jun 5, 2018

  1. GDPR consent management for madvertise bidder adapter (#2655)

    * New adapter madvertise
    
    * Update madvertiseBidAdapter.js
    
    remove aliases
    
    * Update madvertiseBidAdapter.js
    
    use parseSizesInput method
    
    * fix test parseSizesInput
    
    * fix lint parseSizesInput
    
    * remove seeanAd feature
    
    * remove console.log
    
    * Add gdpr consent management to madvertise module
    NLopezMad authored and jsnellbaker committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    646a971 View commit details
    Browse the repository at this point in the history
  2. Consistent targeting set (#2592)

    * Populate adUnitCode's even though there's no bid available
    
    * Add new targeting test for no bids, and upgrade old implicit getAdserverTargeting calls
    
    * Updated to a more simplex generation method
    ptomasroos authored and jaiminpanchal27 committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    6fbc404 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    36ea987 View commit details
    Browse the repository at this point in the history
  4. Added GDPR consent management to UnderdogMedia Bid Adapter (#2679)

    * updated underdogmedia adapter for prebid 1.0
    
    * updated with recommended changes
    
    * UnderdogMedia Adapter - Added GDPR Support
    Jacobkmiller authored and jaiminpanchal27 committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    60f9314 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2018

  1. Add user sync for brainyAdapter (#2666)

    brainymisio authored and jsnellbaker committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    4bdce35 View commit details
    Browse the repository at this point in the history
  2. Sonobi - suppress user sync error (#2686)

    * added vp param to trinity request
    
    * added lib_name and lib_v to trinity
    
    * return null from buildRequests if there is no keymakers
    
    * added test case for empty keymaker
    
    * only importing functions we need from utils
    
    * changed window.pbjs.version to use the gulp repalced macro .version$
    
    * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port
    
    * fixed lint issue
    
    * fixed issue where sonobi getUserSync was throwing an error on timeout
    
    * sonobi support referrer param
    
    * fixed unit test for testing the ref param on bid request
    
    * return null from buildRequests if there is no keymakers
    
    * fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port
    
    * Add gdpr support
    
    * no longer logging error when getUserSync fails to parse a serverResponse
    JonGoSonobi authored and jsnellbaker committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    6fd97d6 View commit details
    Browse the repository at this point in the history
  3. Native images bug fixed (#2681)

    * quantumBidAdapter initial commit
    
    * eslint errors fixed
    
    * updating quantumBidAdapter for reviews, fixed tests to work with native
    
    * set new prebid location for testing and some fixing
    
    * added supportedMediaTypes
    
    * Tests fixed
    
    * Fixed issues with image assets. Tested with the example provided
    
    * Size and tests fixed
    
    * Modify tests
    
    * hello world revert changes
    
    * package-lock reverted
    
    * hello world reverted CRLF/LF Conversion
    
    * hello world reverted LF/CRLF Conversion
    
    * hello world reverted
    
    * hello world reverted
    
    * hello world reverted
    
    * removed hardcoded bid sizes
    
    * GDPR integration
    
    * GDPR support - change quantx_gdpr to (0,1) values accepted
    
    * restored package-lock
    
    * GDPR tests
    
    * GDPR tests fixed
    
    * Send width/height with native assets
    
    * Fixed native images bug
    sami-elasticad authored and jsnellbaker committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    ee4074e View commit details
    Browse the repository at this point in the history
  4. Prebid 1.14.0 release

    jsnellbaker committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    86b848c View commit details
    Browse the repository at this point in the history
  5. increment prebid version

    jsnellbaker committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    1646c0b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. Refactoring Prebid Analytics by Roxot (#2688)

    * Refactoring Prebid Analytics by Roxot
    
    * remove adaptermanager from analytics adapter tests
    mikhail-roxot authored and snapwich committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    322ebfe View commit details
    Browse the repository at this point in the history
  2. Fix getTopWindowUrl (#2673)

    * Fix getTopWindowUrl
    
    getTopWindowUrl error, it should be exports.function not this.function
    
    * Update utils.js
    
    Fix to pass FB test
    
    * Update audienceNetworkBidAdapter_spec.js
    
    * Update utils.js
    
    * Update utils.js
    
    * Update utils.js
    Antoine Jacquemin (Rubicon) authored and jaiminpanchal27 committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    f7f0707 View commit details
    Browse the repository at this point in the history
  3. Playground XYZ - new adapter (#2606)

    * add playground adapters
    
    * clean up
    
    * update with upstream master
    
    * add test file clean up adapter by removing native referecnes
    
    * test file
    
    * replace appnexus with playground reference in error logs
    
    * remove commented code
    
    * change key in response object from appnexus to playgroundxyz
    
    * change tests so we test for ordering by cpm as well
    
    * dont drop other bids, just set cpm to 0 and send it through
    
    * clean up
    
    * restore glulp file
    
    * fix documentation
    
    * remove cpm logic from adapter
    
    * change application type to application\json for playground adapter
    
    * update adaptor to use openRtb
    
    * add device and site to bid
    
    * add extra space on error msg
    
    * remove package-lock
    
    * update pg details
    
    * Update playgroundxyzBidAdapter.md
    teranchristian authored and jaiminpanchal27 committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    af35a11 View commit details
    Browse the repository at this point in the history
  4. Rubicon able to read mediaTypes.size (#2607)

    * Rubicon able to read mediaTypes.size
    
    checkBidRequestSizes is normally present in adaptermanager.js to add the mediaTypes.banner.sizes to bid.sizes. However our adapter need to be able to read these fields in case the method is deprecated.
    Same for the Video.
    Antoine Jacquemin (Rubicon) authored and snapwich committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    d04127a View commit details
    Browse the repository at this point in the history
  5. Rubicon Bid Adapter - ordered auction query params (#2665)

    * ordered ae query params
    
    * updated tg_v and tg_i filter strings
    
    * linting fix
    
    * extracted ordering code to a function
    
    * fixed param names for lat long
    
    * Added unit test to check AE param ordering
    
    * changed test for tg_i and tg_v
    
    * fix removed duplicated 'rf' in order params function
    idettman authored and snapwich committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    1c53a2a View commit details
    Browse the repository at this point in the history
  6. nanointeractive - new optional bid parameter (#2694)

    * nanointeractive bid adapter
    
    * nanointeractive bid adapter
    
    * - using utils.getParameterByName instead of utils.getTopWindowLocation().href
    - bidderCode is removed
    - Default ALG changed to 'ihr'
    - added protocol to 'cors' param
    
    * markdown file
    
    * enabling localhost for bid requests
    
    * Bugfix interpretResponse - added body; Removed unnecessary parameters; Adjusted tests;
    
    * New feature - subId
    
    * Fixed lint errors
    
    * Nano Interactive Bid Adapter
       New Bid params:
         - categoryName
         - name
       Getting referrer information
    
    * Fixed documentation
    
    * Removed unnecessary parameter from documentation
    
    * Cleaning up documentation
    rade-popovic authored and snapwich committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    0885ae0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    043a372 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2018

  1. Adform adapter supports string type sizes (#2692)

    * Allow to compare strings too.
    
    * Fixed lint errors
    Pupis authored and jsnellbaker committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    12c6805 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    15b017b View commit details
    Browse the repository at this point in the history
  3. Media.net Adapter Improvements (#2634)

    * Media.net adapter: passing slot visibility to server
    
    * Media.net adapter: changed slot visibility logic and removed mocks on window properties
    
    * Media.net adapter: refactored slot-visibility tests to use beforeEach and afterEach hooks
    
    * create only one sandbox and restore for medianet
    vedantseta authored and snapwich committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    1d318f9 View commit details
    Browse the repository at this point in the history
  4. reupload package-lock.json file (#2701)

    * reupload package-lock.json file
    
    * commit to fix travis build
    
    * merge 'master' branch into 'upload_package-lock-json_file' branch
    jsnellbaker authored and jaiminpanchal27 committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    0a50366 View commit details
    Browse the repository at this point in the history