[FEAT] Configurable character limit on live chat #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The payload sent to the release service contains an invalid reference to the tag/version and wasn't working when building develop branch.
* Fix wrong method call on app installation * Update subscription check to take cancelled state into account
Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>
… does not restore the content into the composer (RocketChat#16332) Co-authored-by: Danish <danish@kitchen.mshome.net> Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
RocketChat#16088) Co-authored-by: Diego Sampaio <chinello@gmail.com>
…ons (RocketChat#17826) * return empty object if there is no callback * Improve department forward restrictions
…ocketChat#17857) * Delay reporting the import progress to the frontend so it doesn't overwhelm the connection * Increased time to 250ms
* Fix wrong method call on app installation * Update subscription check to take cancelled state into account
Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>
…ons (RocketChat#17826) * return empty object if there is no callback * Improve department forward restrictions
RocketChat#18213) Co-authored-by: Diego Sampaio <chinello@gmail.com>
Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com> Co-authored-by: Diego Sampaio <chinello@gmail.com>
…s removed (RocketChat#17049) Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
… to public (RocketChat#18316) Co-authored-by: Diego Sampaio <chinello@gmail.com>
dlassalle
reviewed
Jul 22, 2020
| @@ -12,6 +12,7 @@ Meteor.methods({ | |||
| const validSettings = [ | |||
| 'Livechat_title', | |||
| 'Livechat_title_color', | |||
| 'Livechat_title_character_limit', | |||
There was a problem hiding this comment.
Im having trouble getting this to save correctly. When I tried debugging the setting below...
settings.forEach((setting) => {
rcSettings.updateById(setting._id, setting.value);
console.log(`========DEBUG ${ setting._id } ${ setting.value }`.green)
console.log(rcSettings.get(setting._id))
});
i got
I20200722-11:58:45.627(-4)? ========DEBUG Livechat_title Rocket.Chat
I20200722-11:58:45.627(-4)? Rocket.Chat
I20200722-11:58:45.632(-4)? ========DEBUG Livechat_title_color #366bc4
I20200722-11:58:45.632(-4)? #366bc4
I20200722-11:58:45.635(-4)? ========DEBUG Livechat_title_character_limit 13
I20200722-11:58:45.636(-4)? undefined
I20200722-11:58:45.638(-4)? ========DEBUG Livechat_show_agent_info true
I20200722-11:58:45.638(-4)? true
I20200722-11:58:45.640(-4)? ========DEBUG Livechat_show_agent_email true
I20200722-11:58:45.640(-4)? true
I20200722-11:58:45.642(-4)? ========DEBUG Livechat_display_offline_form false
I20200722-11:58:45.642(-4)? false
| @@ -16,6 +16,10 @@ <h2>{{_ "Settings"}}</h2> | |||
| <label for="color">{{_ "Title_bar_color"}}</label> | |||
| <input type="color" class="preview-settings rc-input__element" name="color" id="color" value="{{color}}" /> | |||
| </div> | |||
| <div class="input-line"> | |||
| <label for="limitTextLength">{{_ "Characther Limit"}}</label> | |||
There was a problem hiding this comment.
Suggested change
| <label for="limitTextLength">{{_ "Characther Limit"}}</label> | |
| <label for="limitTextLength">{{_ "Character Limit"}}</label> |
* Only run the update check when opting to register the server. Doing it this way enables people to easily disable the update check just like they can sending data to Rocket.Chat services. * Add a new setting to enable/disable the update checker Co-authored-by: Aaron Ogle <geekgonecrazy@users.noreply.github.com>
* Added nickname field, hints for disabled fields * More missing nicknames
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
…ocketChat#18373) Co-authored-by: Diego Sampaio <chinello@gmail.com>
* Link push gateway setting to cloud register * Add migration to disable gateway and alert admins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implementing a new character limit field in the LiveChat Aparence.
Issue(s)
RocketChat#17451
How to test or reproduce
If you want test with Livechat, you will need this feature
Screenshots
Types of changes
Checklist
Changelog
additional setting in Admin panel for setting a character limit on livechat.
Further comments