Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

tracker: get some session variables from downtream #1032 #1070

Closed
wants to merge 51 commits into from

Conversation

lance6716
Copy link
Collaborator

manually cherry-pick #1032


What problem does this PR solve?

enable some test about altering PK, and reduce user config. close #1003

What is changed and how it works?

  • session variable:
    • if user specified, use it
    • else get sql_mode, tidb_skip_utf8_check from downstream
  • tracker (tidb) config:
    • set alter-primary-key true
  • max-allow-packet
    • always get from downstream (by feature of driver)

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has persistent data change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

csuzhangxc and others added 30 commits August 21, 2020 17:34
Co-authored-by: lance6716 <lance6716@gmail.com>
…#953)

Co-authored-by: lance6716 <lance6716@gmail.com>
Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com>
Co-authored-by: lance6716 <lance6716@gmail.com>
Co-authored-by: csuzhangxc <csuzhangxc@gmail.com>
Co-authored-by: gmhdbjd <gmhdbjd@gmail.com>
ti-srebot and others added 21 commits September 10, 2020 09:57
Co-authored-by: lance6716 <lance6716@gmail.com>
Co-authored-by: csuzhangxc <csuzhangxc@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ngcap#1028)

Co-authored-by: lance6716 <lance6716@gmail.com>
Co-authored-by: csuzhangxc <csuzhangxc@gmail.com>
Co-authored-by: xiang <xiang13225080@163.com>
… (pingcap#1041)

Co-authored-by: csuzhangxc <csuzhangxc@gmail.com>
Co-authored-by: lance6716 <lance6716@gmail.com>
…gcap#1027) (pingcap#1043)

* loader: don't print ERROR log, clean dump file when all finished (pingcap#1027)

* loader, test: fix bug of clean dump file and update checkpoint
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ csuzhangxc
✅ lance6716
❌ ti-srebot
You have signed the CLA already but the status is still pending? Let us recheck it.

@lance6716 lance6716 added type/cherry-pick This PR is just a cherry-pick (backport) priority/normal Minor change, requires approval from ≥1 primary reviewer type/feature New feature labels Sep 21, 2020
@lance6716 lance6716 closed this Sep 21, 2020
@lance6716 lance6716 deleted the cp1032 branch September 21, 2020 06:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer type/cherry-pick This PR is just a cherry-pick (backport) type/feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto discover more config, such as max-allowed-packet
4 participants