Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release v0.23.2 to main #3951

Merged
merged 76 commits into from
Dec 21, 2023
Merged

Merge release v0.23.2 to main #3951

merged 76 commits into from
Dec 21, 2023

Conversation

findtopher
Copy link
Member

See Release Notes for changes

This includes all known version and dependency bumps, so feel free to check those out and make sure they're what you're expecting.

kaixi-wang and others added 30 commits December 8, 2023 16:41
* use db client to get the dataset doc instead of mongoengine queryset cache

* use db client to get the dataset doc instead of mongoengine queryset cache
* more range check validation

* fix tagging

* remove log

* fix imavid regression

* upgrade dep versions

* add watermarking option in image generator

* fix frame one-off frame sync bug

* move dynamic groups spec to groups folder

* move dynamic groups spec to groups folder

* add more data-cy attributes

* differentiate grid and modal taggers

* add speed controller

* add toggleRenderFramesAsVideo

* rename vars

* add imavid tests

* add screenshots

* add data-cy to pathvalueentry

* add tagging tests

* remove unused vars

* add modal tagger pom

* add label count and sample count getters in siderbar

* reset popups before play/pause
Don't overwrite dataset metadata with empty values during imports
Invalidate builtin operators when there's nothing to do
* enable load dataset by id in execution context and remove redundant reloading

* fix merge

* move load_dataset to odm dir

* rvt preventing migration and logging

* refactor given previous changes

* apply requested changes

* only reload if dataset exists
* ensure line breaks in embeddings legend

* Update app/packages/embeddings/src/tracesToData.tsx

Co-authored-by: Benjamin Kane <ben@voxel51.com>

---------

Co-authored-by: Benjamin Kane <ben@voxel51.com>
Adds a toggle to show/hide fields in sample modal that have undefined…
Fixes user selection of Scalar fields so copy/paste of feilds and val…
* passing in active group slice as a parameter for similarity sort run

* Better similarity search UX experience for grouped dataset when not all slices have similarity computed

* attempt to reset similarity parameters

* update session slice during page change on similarity reset

* reset selection

---------

Co-authored-by: manivoxel51 <mani@voxel51.com>
Co-authored-by: Benjamin Kane <ben@voxel51.com>
* updates selection operators

* lint
Optimize reload docs when performing bulk writes
* more range check validation

* remove log

* add speed controller

* reset popups before play/pause

* show 'render as video' option when it is ordered dynamic group

* remove isImaVidAvailable and replace with isOrderedDynamicGroup

* rename nonNestedDynamicGroupsViewMode to nonNestedDynamicGroupsViewMode

* pass slice info if nested group

* stringify groupByFieldValue

* rename nonNestedDynamicGroupsViewMode to nonNestedDynamicGroupsViewMode in dynamicgroup

* set default mode to pagination

* differentiate groupMedia3dVisibleSetting and groupMediaIsCarouselVisible

* sync currentframenumber with dynamicgroupindex

* cleanup DynamicGroupsFlashlightWrapper

* fix visibility settings

* implement sync between pagination and video player

* partition by groupby value and not 'postersample'

* fix bug where aggregations query were misfiring

* update dep versions for e2e

* add check-flaky directions in readme

* fix check-flaky script

* make image-gen less verbose

* fix imavid key bug

* fix keyboard navigation

* fix e2e - use 'pagination' as default mode

* fix import

* wait for carousel to load in sparse test

* fix regressions

* render 3d below if main not visible

* linting

---------

Co-authored-by: Benjamin Kane <ben@voxel51.com>
@findtopher findtopher requested a review from a team December 21, 2023 15:06
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 467 lines in your changes are missing coverage. Please review.

Comparison is base (d069e30) 15.87% compared to head (aa1e5d6) 15.86%.
Report is 1 commits behind head on main.

Files Patch % Lines
...p/packages/core/src/components/Actions/Options.tsx 0.00% 62 Missing ⚠️
app/packages/core/src/components/Modal/Modal.tsx 0.00% 54 Missing ⚠️
app/packages/state/src/recoil/groups.ts 41.55% 45 Missing ⚠️
...pp/packages/core/src/components/Actions/Tagger.tsx 0.00% 35 Missing ⚠️
app/packages/state/src/hooks/useCreateLooker.ts 0.00% 30 Missing ⚠️
.../src/components/Sidebar/Entries/PathValueEntry.tsx 0.00% 27 Missing ⚠️
app/packages/embeddings/src/tracesToData.tsx 0.00% 23 Missing ⚠️
app/packages/looker/src/elements/imavid/index.ts 0.00% 23 Missing ⚠️
...mponents/Actions/GroupMediaVisibilityContainer.tsx 0.00% 18 Missing ⚠️
.../src/components/Modal/Group/DynamicGroup/index.tsx 0.00% 18 Missing ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3951      +/-   ##
==========================================
- Coverage   15.87%   15.86%   -0.01%     
==========================================
  Files         731      731              
  Lines       81557    81853     +296     
  Branches     1093     1093              
==========================================
+ Hits        12944    12987      +43     
- Misses      68613    68866     +253     
Flag Coverage Δ
app 15.86% <12.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@findtopher findtopher merged commit 7eaeee9 into main Dec 21, 2023
22 checks passed
@findtopher findtopher deleted the merge/v0.23.2-to-main branch December 21, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.