-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flag for includeSoftDeleted in scroll entities API #10831
add flag for includeSoftDeleted in scroll entities API #10831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
WalkthroughThe Changes
Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java (2 hunks)
Additional comments not posted (2)
metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java (2)
151-152
: Verify the integration of theincludeSoftDeleted
parameter.The
includeSoftDeleted
parameter is added to thegetEntities
method. Ensure that this parameter is correctly integrated and used.
180-181
: Verify the usage of theincludeSoftDeleted
parameter in thescrollAcrossEntities
method.The
includeSoftDeleted
parameter is used in thescrollAcrossEntities
method call. Ensure that this parameter is correctly utilized in the method.
Checklist
Summary by CodeRabbit
includeSoftDeleted
parameter to access this feature.