fix(manage-tokens): fix manage access token policy

[david-leifker]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• New Features
  • Enhanced authorization checks for generating personal access tokens, improving security and management of access tokens.
  • Introduced new permissions for managing access tokens, allowing for operations such as create, read, update, delete, and check existence under specific privileges.

[coderabbitai]

Walkthrough

The recent updates enhance the authorization framework in DataHub by incorporating an additional check for the canGeneratePersonalAccessToken function. This change ensures that only users with the MANAGE_ACCESS_TOKENS privilege, defined in the new PoliciesConfig settings, can generate personal access tokens, adding a layer of security and control.

Changes

File Path	Change Summary
datahub-graphql-core/.../authorization/AuthorizationUtils.java	Modified canGeneratePersonalAccessToken to include an additional authorization check using MANAGE_ACCESS_TOKENS.
metadata-utils/.../authorization/PoliciesConfig.java	Introduced permissions for ACCESS_TOKEN_ENTITY_NAME with CREATE, READ, UPDATE, DELETE, and EXISTS operations linked to MANAGE_ACCESS_TOKENS.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GraphQLServer
    participant AuthorizationUtils
    participant PoliciesConfig
    
    User->>GraphQLServer: Request to generate personal access token
    GraphQLServer->>AuthorizationUtils: canGeneratePersonalAccessToken(user)
    AuthorizationUtils->>PoliciesConfig: Check MANAGE_ACCESS_TOKENS permission
    PoliciesConfig-->>AuthorizationUtils: Return permission status
    AuthorizationUtils-->>GraphQLServer: Return authorization result
    GraphQLServer-->>User: Response based on authorization result

Loading

Poem

From fields of code where data blooms,
Permissions grow within the rooms.
Manage tokens, access secure,
Policies ensure it's pure.
Code and logic intertwined,
Authorization redefined. 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 74a543d and e67d8ac.

Files selected for processing (2)

• datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/authorization/AuthorizationUtils.java (2 hunks)
• metadata-utils/src/main/java/com/linkedin/metadata/authorization/PoliciesConfig.java (1 hunks)

Additional comments not posted (2)

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/authorization/AuthorizationUtils.java (1)

56-60: LGTM! The additional authorization check enhances security.

The inclusion of the MANAGE_ACCESS_TOKENS privilege ensures stricter control over the generation of personal access tokens.

metadata-utils/src/main/java/com/linkedin/metadata/authorization/PoliciesConfig.java (1)

974-1005: LGTM! The new permissions and privileges enhance the security and management capabilities.

The introduction of permissions for ACCESS_TOKEN_ENTITY_NAME and the association with the MANAGE_ACCESS_TOKENS privilege provide a more granular and comprehensive permission structure for managing access tokens.