Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test-assert to use node:test #54585

Closed
wants to merge 3 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 27, 2024

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 27, 2024

This comment was marked as outdated.

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 27, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 29, 2024

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2024
@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 29, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/54585
✔  Done loading data for nodejs/node/pull/54585
----------------------------------- PR info ------------------------------------
Title      test: update test-assert to use node:test (#54585)
Author     James M Snell <jasnell@gmail.com> (@jasnell)
Branch     jasnell:use-test-for-test-assert -> nodejs:main
Labels     test, author ready, needs-ci
Commits    3
 - test: update test-assert to use node:test
 - test: update test-assert-typedarray-deepequal to use node:test
 - test: update multiple assert tests to use node:test
Committers 1
 - James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 27 Aug 2024 05:10:26 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54585#pullrequestreview-2263248081
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/54585#pullrequestreview-2266164379
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-08-29T05:55:07Z: https://ci.nodejs.org/job/node-test-pull-request/61636/
- Querying data for job/node-test-pull-request/61636/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 54585
From https://github.com/nodejs/node
 * branch                  refs/pull/54585/merge -> FETCH_HEAD
✔  Fetched commits as beabcec41ca4..23adad3410af
--------------------------------------------------------------------------------
[main 4aeb86ca38] test: update test-assert to use node:test
 Author: James M Snell <jasnell@gmail.com>
 Date: Mon Aug 26 21:05:07 2024 -0700
 2 files changed, 912 insertions(+), 930 deletions(-)
 delete mode 100644 test/parallel/test-assert-strict-exists.js
[main cd0b7c648d] test: update test-assert-typedarray-deepequal to use node:test
 Author: James M Snell <jasnell@gmail.com>
 Date: Mon Aug 26 21:15:20 2024 -0700
 1 file changed, 87 insertions(+), 74 deletions(-)
[main 6b4ce531e1] test: update multiple assert tests to use node:test
 Author: James M Snell <jasnell@gmail.com>
 Date: Mon Aug 26 22:08:07 2024 -0700
 6 files changed, 1000 insertions(+), 973 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: update test-assert to use node:test

PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

[detached HEAD ccd5210bd5] test: update test-assert to use node:test
Author: James M Snell <jasnell@gmail.com>
Date: Mon Aug 26 21:05:07 2024 -0700
2 files changed, 912 insertions(+), 930 deletions(-)
delete mode 100644 test/parallel/test-assert-strict-exists.js
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: update test-assert-typedarray-deepequal to use node:test

PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

[detached HEAD f86339c706] test: update test-assert-typedarray-deepequal to use node:test
Author: James M Snell <jasnell@gmail.com>
Date: Mon Aug 26 21:15:20 2024 -0700
1 file changed, 87 insertions(+), 74 deletions(-)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: update multiple assert tests to use node:test

PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

[detached HEAD 1a97b77ea1] test: update multiple assert tests to use node:test
Author: James M Snell <jasnell@gmail.com>
Date: Mon Aug 26 22:08:07 2024 -0700
6 files changed, 1000 insertions(+), 973 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/10619066403

jasnell added a commit that referenced this pull request Aug 29, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell added a commit that referenced this pull request Aug 29, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell added a commit that referenced this pull request Aug 29, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Aug 29, 2024

Landed in fc02b88...9cbef48

@jasnell jasnell closed this Aug 29, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
PR-URL: nodejs#54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
PR-URL: nodejs#54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
PR-URL: nodejs#54585
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@RafaelGSS RafaelGSS added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Sep 1, 2024
@RafaelGSS
Copy link
Member

Unfortunately, this commit didn't land cleanly on v22.x-staging. I tried to fix the conflicts but tests started to fail. Can you create a manual backport?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants