stream: treat null asyncIterator as undefined #55119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
KhafraDev
previously requested changes
Sep 25, 2024
There was a problem hiding this comment.
According to the spec, getIterator should normalize incoming method to
undefined if it is either undefined or null.
Where is this? The tc39 link in the PR specifically does not mentioned null?
Let method be ? [GetMethod](https://tc39.es/ecma262/#sec-getmethod)(obj, [%Symbol.asyncIterator%](https://tc39.es/ecma262/#sec-well-known-symbols)).
b. If method is undefined, then
i. Let syncMethod be ? [GetMethod](https://tc39.es/ecma262/#sec-getmethod)(obj, [%Symbol.iterator%](https://tc39.es/ecma262/#sec-well-known-symbols)).
ii. If syncMethod is undefined, throw a TypeError exception.
edit: it's in GetMethod:
If func is either undefined or null, return undefined.
RedYetiDev
reviewed
Sep 25, 2024
|
It is in the getMethod
|
aduh95
approved these changes
Sep 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55119 +/- ##
==========================================
- Coverage 88.25% 88.24% -0.01%
==========================================
Files 651 651
Lines 183856 183858 +2
Branches 35850 35854 +4
==========================================
- Hits 162259 162248 -11
- Misses 14888 14893 +5
- Partials 6709 6717 +8
|
KhafraDev
approved these changes
Sep 25, 2024
According to the spec, getIterator should normalize incoming method to undefined if it is either undefined or null. This PR enforces that spec compliance with passed WPT.
jazelly
force-pushed
the
fix-stream-iterator
branch
from
cf44066
to
0a4ffe8
Compare
KhafraDev
added
author ready
github-actions
bot
removed
the
request-ci
MattiasBuelens
approved these changes
Sep 26, 2024
KhafraDev
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 87a79cd |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
According to the spec, getIterator should normalize incoming method to undefined if it is either undefined or null. This PR enforces that spec compliance with passed WPT. PR-URL: #55119 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
According to the spec, getIterator should normalize incoming method to undefined if it is either undefined or null. This PR enforces that spec compliance with passed WPT. PR-URL: #55119 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec, getIterator should normalize incoming method to
undefined if it is either undefined or null. This PR enforces that spec
compliance with passed WPT.