doc: fix the require resolve algorithm in modules.md #55117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix, the pseudocode means an infinite loop.
|
Review requested:
|
nodejs-github-bot
added
doc
aduh95
approved these changes
Sep 25, 2024
aduh95
added
the
author ready
atlowChemi
approved these changes
Sep 25, 2024
aymen94
approved these changes
Sep 26, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55117 ✔ Done loading data for nodejs/node/pull/55117 ----------------------------------- PR info ------------------------------------ Title doc: fix the require resolve algorithm in modules.md (#55117) Author chirsz <chirsz@foxmail.com> (@chirsz-ever, first-time contributor) Branch chirsz-ever:patch-1 -> nodejs:main Labels doc, module, author ready Commits 1 - doc: fix the require resolve algorithm in modules.md Committers 1 - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/55117 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55117 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 25 Sep 2024 12:29:49 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/55117#pullrequestreview-2328588399 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/55117#pullrequestreview-2329181319 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient ⚠ PR author is a new contributor: @chirsz-ever(chirsz@foxmail.com) ⚠ - commit 53fcdca8accf is authored by chirsz-ever@outlook.com -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11070706831 |
|
Landed in fd787c9 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
Before the fix, the pseudocode was describing an infinite loop. PR-URL: #55117 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
Before the fix, the pseudocode was describing an infinite loop. PR-URL: #55117 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix, the pseudocode means an infinite loop.