Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: move Symbol[Async]Dispose polyfills to internal/util #54853

Merged
merged 1 commit into from
Sep 10, 2024
Merged

lib: move Symbol[Async]Dispose polyfills to internal/util #54853

merged 1 commit into from
Sep 10, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 8, 2024

We can use it from primordials when the ad-hoc V8 flag will have been removed upstream:

node/deps/v8/src/flags/flag-definitions.h

Line 278 in 9404d3a

V(js_explicit_resource_management, "explicit resource management") \

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/streams
  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 8, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.89%. Comparing base (e1e312d) to head (4032995).
Report is 302 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/util.js 75.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54853      +/-   ##
==========================================
- Coverage   87.90%   87.89%   -0.01%     
==========================================
  Files         651      651              
  Lines      183343   183352       +9     
  Branches    35710    35710              
==========================================
  Hits       161165   161165              
+ Misses      15466    15463       -3     
- Partials     6712     6724      +12
Files with missing lines Coverage Δ
lib/_http_server.js 96.64% <100.00%> (ø)
lib/child_process.js 97.74% <100.00%> (ø)
lib/dgram.js 97.50% <100.00%> (-0.01%) ⬇️
lib/events.js 98.36% <100.00%> (-0.01%) ⬇️
lib/https.js 99.30% <100.00%> (ø)
lib/inspector.js 96.33% <100.00%> (+0.05%) ⬆️
lib/internal/child_process.js 95.16% <100.00%> (+0.34%) ⬆️
lib/internal/events/abort_listener.js 100.00% <100.00%> (ø)
lib/internal/fs/promises.js 98.24% <100.00%> (ø)
lib/internal/http2/core.js 95.56% <100.00%> (ø)
... and 16 more

... and 28 files with indirect coverage changes

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 9, 2024
mcollina
mcollina approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 10, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/62237/ 💛

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7c58645 into nodejs:main Sep 10, 2024
67 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7c58645

@aduh95 aduh95 deleted the symbol-async-dispose branch September 10, 2024 22:29
aduh95 added a commit that referenced this pull request Sep 12, 2024
@aduh95
lib: move Symbol[Async]Dispose polyfills to internal/util
7ab34c2 
PR-URL: #54853
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request Sep 13, 2024
@aduh95
lib: move Symbol[Async]Dispose polyfills to internal/util
378e293 
PR-URL: #54853
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request Sep 13, 2024
@aduh95
lib: move Symbol[Async]Dispose polyfills to internal/util
5f02e1b 
PR-URL: #54853
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024
@aduh95 aduh95 mentioned this pull request Oct 4, 2024
Open
@aduh95 aduh95 added backport-open-v20.x Indicate that the PR has an open backport and removed dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Oct 4, 2024
aduh95 added a commit to aduh95/node that referenced this pull request Oct 4, 2024
@aduh95
lib: move Symbol[Async]Dispose polyfills to internal/util
8c960bc 
PR-URL: nodejs#54853
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95 @louwers
lib: move Symbol[Async]Dispose polyfills to internal/util
7e9bdc6 
PR-URL: nodejs#54853
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@legendecas legendecas legendecas approved these changes

@MoLow MoLow MoLow approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v20.x Indicate that the PR has an open backport lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aduh95 @nodejs-github-bot @mcollina @jasnell @benjamingr @MoLow @legendecas @marco-ippolito @targos