doc: update require(ESM) history and stability status
#55199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
aduh95
added
backport-requested-v20.x
MoLow
approved these changes
Sep 30, 2024
guybedford
approved these changes
Oct 1, 2024
RedYetiDev
added
the
author ready
joyeecheung
approved these changes
Oct 1, 2024
joyeecheung
reviewed
Oct 1, 2024
joyeecheung
approved these changes
Oct 1, 2024
aduh95
added
commit-queue
aduh95
force-pushed
the
require-esm-history
branch
from
6d31676
to
78063b0
Compare
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55199 ✔ Done loading data for nodejs/node/pull/55199 ----------------------------------- PR info ------------------------------------ Title doc: update `require(ESM)` history and stability status (#55199) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:require-esm-history -> nodejs:main Labels doc, module, author ready, commit-queue-squash, backport-requested-v20.x, backport-requested-v22.x Commits 1 - doc: update `require(ESM)` history and stability status Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/55199 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55199 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: update `require(ESM)` history and stability status ℹ This PR was created on Mon, 30 Sep 2024 20:56:15 GMT ✔ Approvals: 3 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/55199#pullrequestreview-2338676190 ✔ - Guy Bedford (@guybedford): https://github.com/nodejs/node/pull/55199#pullrequestreview-2338931035 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/55199#pullrequestreview-2340448665 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11151507870 |
|
Landed in 348d865 |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Oct 4, 2024
PR-URL: nodejs#55199 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Oct 4, 2024
PR-URL: nodejs#55199 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Oct 4, 2024
PR-URL: nodejs#55199 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
added
backport-open-v20.x
targos
added
backport-open-v22.x
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Oct 8, 2024
PR-URL: nodejs#55199 Backport-PR-URL: nodejs#55263 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.