Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synse Server v3 release #383

Merged
merged 125 commits into from
Mar 30, 2020
Merged

Synse Server v3 release #383

merged 125 commits into from
Mar 30, 2020

Conversation

edaniszewski
Copy link
Contributor

This PR merges in the work for Synse v3

As the work here has been reviewed prior to merging into the synse v3 branch, hopefully this will just need a quick look-over.

edaniszewski and others added 30 commits March 27, 2020 14:55
* simplify/update development flow

* update to makefile

* fix i18n flow
* checkpoint

* updates

* fix temporary dep issue, improve dockerfile caching
* Fix returned data scheme in response/device_summary

* Fix returned data scheme in response/read

* Add toc for websocket events

* Fix table styling 1

* Fill in readcache event data

* Add version event

* Add note for plugin event

* Add read device event

* Update write sync event

* Add write async event

* Update transaction event
* Add som to read device event

* Fix write data scheme

* Update response scheme for consistency

* Rename request post data
* initial updates for the v3 http api

* move functions around

* add http endpoint logging

* remove old files

* remove old files

* more cleanup, remove dead code

* start adding in support for plugin endpoints

* add tags command

* query param parsing, add scan support

* update documentation for query params

* add debug logging to commands

* fix bool flag query param for tags request

* add support for info command

* device read/write support

* add support for transaction commands

* add initial support for reads

* initial support for writes

* cleanup

* update error handling

* bug fixes, cleanup, logging

* bug fixes, api consistency, notes for additional fixes

* updates, fixes
* update plugin loading, do not purge plugins once loaded

* update plugin management and active/inactive tracking

* add sync write transactions to cache

* fix bug with reading tags, use util to get plugin from device, exception handling

* update reading response scheme
Copy link
Contributor

@MatthewHink MatthewHink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NOTICE Outdated
@@ -1,6 +1,6 @@
NOTICE

Synse v2.0
Synse v3.0
Copyright (c) 2015-2019 Vapor IO, Inc. and Synse contributors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2020

# instance. Useful for learning, testing, and debugging.
#

version: '3.4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should double check this version? Examples look like version 3. https://docs.docker.com/compose/compose-file/compose-versioning/#compatibility-matrix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we need 3.4 (https://docs.docker.com/compose/compose-file/compose-versioning/#version-34) since the composefile uses the start_period option for health checks

synse_server/api/http.py Show resolved Hide resolved
synse_server/cache.py Show resolved Hide resolved
Copy link
Contributor

@hoanhan101 hoanhan101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edaniszewski edaniszewski merged commit a50a13e into master Mar 30, 2020
@edaniszewski edaniszewski deleted the v3/staging branch March 30, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants