Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params, core/forkid: schedule cancun fork on goerli #28719

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Dec 21, 2023

This PR schedules the cancun fork for the goerli testnet as discussed on ACD.
Spec: ethereum/execution-specs#860

We schedule:
goerli at 1705473120

@MariusVanDerWijden
Copy link
Member Author

see ethereum/execution-specs#860

Copy link
Contributor

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡🚀

core/forkid/forkid_test.go Outdated Show resolved Hide resolved
@MariusVanDerWijden MariusVanDerWijden changed the title params: core/forkid: schedule cancun fork on goerli params: core/forkid: schedule cancun fork on testnets Dec 21, 2023
@holiman
Copy link
Contributor

holiman commented Dec 22, 2023

Maybe let's not merge this until jan 4th, next ACD, to get it confirmed. The fork date is jan 18th or so, according to the grapevine (a.k.a @lightclient )

@fjl fjl changed the title params: core/forkid: schedule cancun fork on testnets params, core/forkid: schedule cancun fork on testnets Jan 4, 2024
@MariusVanDerWijden MariusVanDerWijden changed the title params, core/forkid: schedule cancun fork on testnets params, core/forkid: schedule cancun fork on goerli Jan 8, 2024
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit cfff3cb into ethereum:master Jan 8, 2024
1 of 3 checks passed
@fjl fjl added this to the 1.13.8 milestone Jan 8, 2024
@MariusVanDerWijden MariusVanDerWijden modified the milestones: 1.13.8, 1.13.9 Jan 10, 2024
{6500000, 2678832736, ID{Hash: checksumToBytes(0xf9843abf), Next: 0}}, // Future Shanghai block
{6000001, 1678832736, ID{Hash: checksumToBytes(0xf9843abf), Next: 1705473120}}, // First Shanghai block
{6500002, 1705473119, ID{Hash: checksumToBytes(0xf9843abf), Next: 1705473120}}, // Last Shanghai block
{6500003, 1705473120, ID{Hash: checksumToBytes(0x70cc14e2), Next: 0}}, // First Cancun block

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@cshintov
Copy link

cshintov commented Jan 10, 2024

The release note says 10th Jan.

This release fixes a few issues and enables the Cancun upgrade for the Goerli network at block timestamp 1705473120 (#28719) which is 9:30am 10. Jan. 2024 UTC.

Copy link

@Dayday10 Dayday10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@DragonDev1906
Copy link
Contributor

The release note says 10th Jan.

This confused me quite a bit when I've read it, too: Releasing a version for support for an (upcoming) new version that is supposed to happen before the release was published:

2024-01-11-102004_1520x372_scrot
https://github.com/ethereum/go-ethereum/releases/tag/v1.13.9

@karalabe
Copy link
Member

Fixed. Sry

Copy link

@Karma197617 Karma197617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you

Copy link

@Karma197617 Karma197617 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So were good?

Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
This PR schedules the cancun fork for the goerli testnet as discussed on ACD.
Spec: ethereum/execution-specs#860

We schedule:
  goerli at 1705473120
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Apr 29, 2024
This PR schedules the cancun fork for the goerli testnet as discussed on ACD.
Spec: ethereum/execution-specs#860

We schedule:
  goerli at 1705473120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.