Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: avoid setting default slog logger in init #28747

Merged
merged 1 commit into from
Dec 30, 2023
Merged

log: avoid setting default slog logger in init #28747

merged 1 commit into from
Dec 30, 2023

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Dec 29, 2023

Fixes #28738

@fjl fjl mentioned this pull request Dec 29, 2023
Closed
holiman
holiman approved these changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holiman holiman added this to the 1.13.8 milestone Dec 30, 2023
@fjl fjl merged commit c053eb7 into ethereum:master Dec 30, 2023
2 of 3 checks passed
@MariusVanDerWijden MariusVanDerWijden modified the milestones: 1.13.8, 1.13.9 Jan 10, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jan 10, 2024
Merged
@dnhn dnhn mentioned this pull request Jan 11, 2024
Merged
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@fjl @Dergarcon
log: avoid setting default slog logger in init (ethereum#28747)
fc684ad 
slog.SetDefault has undesirable side effects. It also sets the default logger destination,
for example. So we should not call it by default in init.
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Apr 29, 2024
@fjl @roberto-bayardo
log: avoid setting default slog logger in init (ethereum#28747)
84deec9 
slog.SetDefault has undesirable side effects. It also sets the default logger destination,
for example. So we should not call it by default in init.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.9
Development

Successfully merging this pull request may close these issues.

Native log broken for package consumers
3 participants
@fjl @holiman @MariusVanDerWijden