Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/filters: reset filter.begin in BenchmarkFilters #28830

Merged
merged 1 commit into from
Jan 18, 2024
Merged

eth/filters: reset filter.begin in BenchmarkFilters #28830

merged 1 commit into from
Jan 18, 2024

Conversation

darioush
Copy link
Contributor

@darioush darioush commented Jan 17, 2024 •
edited
Loading

This PR resets filter.begin to 0 between benchmark iterations, otherwise the filter backend will update begin after the call to Logs and the 2nd call will return no logs.
Alternatively, can move:

	filter := sys.NewRangeFilter(0, -1, []common.Address{addr1, addr2, addr3, addr4}, nil)

to the loop if you prefer.

holiman
holiman approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@holiman holiman added this to the 1.13.11 milestone Jan 18, 2024
@holiman holiman merged commit 830f3c7 into ethereum:master Jan 18, 2024
1 of 2 checks passed
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@darioush @Dergarcon
eth/filters: reset filter.begin in BenchmarkFilters (ethereum#28830)
2776748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.11
Development

Successfully merging this pull request may close these issues.
2 participants
@darioush @holiman