Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fast codegen-free generic object instantiation + improve Activator.CreateInstance perf #1

Closed
wants to merge 193 commits into from

Commits on May 11, 2020

  1. Fast object instantiation, take two

    - Eliminates ObjectFactory<T> except when caller explicitly wants a Func<T>
    - Uses C# 9.0 function pointers to avoid introducing new JIT intrinsics
    GrabYourPitchforks committed May 11, 2020
    Configuration menu
    Copy the full SHA
    d0bde83 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Configuration menu
    Copy the full SHA
    67539c2 View commit details
    Browse the repository at this point in the history
  2. PR feedback

    - Remove new public APIs
    - Remove most new native APIs
    - Plumb GetUninitializedObject atop new native code paths
    - Use actual builds from arcade
    GrabYourPitchforks committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    edf3858 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c5ae79f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e09e91b View commit details
    Browse the repository at this point in the history
  5. PR feedback

    - Don't be so aggressive about running cctors
    - Some minor code cleanup
    - Don't swallow OOMs
    GrabYourPitchforks authored Jul 8, 2020
    Configuration menu
    Copy the full SHA
    17a3bde View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Configuration menu
    Copy the full SHA
    2467fdd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb368eb View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Configuration menu
    Copy the full SHA
    b85fb74 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7426c10 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    faeef8c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4204aa9 View commit details
    Browse the repository at this point in the history
  5. Change SuperPMI collection to not use altjit mechanism (dotnet#44834)

    * Change SuperPMI collection to not use altjit mechanism
    
    The SuperPMI collection process interposes a "shim" JIT between the JIT and EE.
    As it is inconvenient to physically replace the existing JIT, currently this
    is done by enabling altjit compilation and setting `COMPlus_AltJitName` to the
    name of the shim JIT. This creates other inconvenience, especially with the
    new way of saving the altjit flag in the JIT flags, by requiring us to
    force the altjit flags bit to not be set, and force unset all the altjit flags.
    It also makes it inconvenient to collect and/or replay with an actual altjit.
    
    Change this collection mechanism to use the newly restored `COMPlus_JitName`
    variable to allow specifying the JIT, and use that to specify the SuperPMI shim.
    
    In addition, do not record in the MC file the `COMPlus_EnableExtraSuperPmiQueries`
    variable. This is only used during collections to attempt to make replays more
    flexible, but we never want to tell the JIT during replay that this is set.
    
    * Enable `COMPlus_JitName` for crossgen as well
    
    * Fix issue with empty collection args
    BruceForstall authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    14c0440 View commit details
    Browse the repository at this point in the history
  6. Fix ComponentDocumentDesigner references in DesignerAttribute to incl…

    …ude right base type (dotnet#44774)
    
    * Fix IComponent Designer attribute that was missing base designer type
    
    * Fix IRootDesigner references to use assembly qualified name
    
    * Fix build failures
    safern authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    a60137c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bdb403a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4e5463d View commit details
    Browse the repository at this point in the history
  9. Remove some allocations from ManifestBuilder.CreateManifestString (do…

    …tnet#44532)
    
    For the RuntimeEventSource, this removes around 30K of allocation, though that's only ~3% of what gets allocated.
    stephentoub authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    e28dbe9 View commit details
    Browse the repository at this point in the history
  10. Delete now unused target in crossgen2.csproj. (dotnet#44888)

    Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
    jkoritzinsky authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    42ffc8f View commit details
    Browse the repository at this point in the history
  11. Remove unnecessary GetTypeInfo from Microsoft.Extensions. (dotnet#44891)

    I also made a slight optimization to CallSiteFactory to use ToArray instead of ToList.
    eerhardt authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    0fad9d6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    722fb86 View commit details
    Browse the repository at this point in the history
  13. Fix discuss dotnet#44785:optimize constructor of ElapsedEventArgs (do…

    …tnet#44853)
    
    * optimize constructor of ElapsedEventArgs
    
    * delete the old ctor
    LeaFrock authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    7e3b310 View commit details
    Browse the repository at this point in the history
  14. Improve dumping GC info in R2RDump (dotnet#44857)

    The --raw command-line option used to dump bytes prefixed with their RVAs for all structures except GC blobs, which were dumped with file offsets instead. This change fixes that inconsistency. It also fixes the size reported by x86.GcInfo, which determines how many bytes to dump. In addition I simplified ReadyToRunMethod's code to store just the GC blob's RVA and avoid the delegate allocation.
    AntonLapounov authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    514079d View commit details
    Browse the repository at this point in the history
  15. Fix illumos managed build (dotnet#44386)

    * Fix illumos managed build
    * Fix CA1823 (unused private field) in `NetworkChange` partial for
      `UnknownUnix`.
    * Use official casing `illumos` in MSBuild property names (as done for
      iOS).
    * Fix Solaris version in test with SDK's PlatformDetection.
      * only major version is needed.
    
    * Implement Enviornment.WorkingSet for SunOS
    Difference between Linux and SunOS procfs is that files in latter
    contain binary data, so we need `read(2)` and cast into corresponding
    struct. Redeclaring system structs in managed code is not ideal, as
    they do change across the major versions of OS, which inevitably
    requires recompilation of binaries and replicating them in C# as is
    means additional/unnecessary maintenance of code.
    
    * Address CR feedback
    am11 authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    cb3ecbb View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    21f32f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Configuration menu
    Copy the full SHA
    c173fda View commit details
    Browse the repository at this point in the history
  2. Change gtGetThisArg not to return nullptr. (dotnet#44398)

    * Don't wrap string literal const as nop for CoreRT.
    
    It was probably an old workaround for another Jit bug, it is most likely fixed by now.
    
    * Change `gtGetThisArg` not to return `nullptr`.
    
    There was only 1 case where a null return was tolerated - for a tail call in `optAssertionGen` marked as virtual.
    However, a transformed tail call is never a virtual, fix `fgMorphTailCallViaJitHelper` to unset virtual flag.
    
    * Keep x86 tail call via jit helper as a virtual stub call.
    Sergey Andreenko authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    044ee8c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5c52acd View commit details
    Browse the repository at this point in the history
  4. Verify that OCSP and CRL checks fall back.

    Test that a CRL timeout chain build will use OCSP, and that an OCSP timeout chain build will use CRL.
    vcsjones authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    0cb3cfd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a1c362c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    999785e View commit details
    Browse the repository at this point in the history
  7. Fix indentation

    GrabYourPitchforks committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    3ce9c41 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    496bc88 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    904b25d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1f6434a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1eb8d17 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c1ecb07 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ffc0b7a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a7040b0 View commit details
    Browse the repository at this point in the history
  15. Use simple array for AggregateException inner exceptions storage (dot…

    …net#44787)
    
    * Use simple array for AggregateException inner exceptions storage
    
    * Replace cases which called into InnerExceptions inside SPC
    
    * Update src/libraries/System.Private.CoreLib/src/System/AggregateException.cs
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    
    * Fix typo
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    marek-safar and stephentoub authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    f2feed9 View commit details
    Browse the repository at this point in the history
  16. Fix s390x unwinding and remove need for backchain pointer (dotnet#44927)

    Fix unwinding for s390x. Removes the `-mbackchain` flag that had been used in the past when unwinding stack frames but has not been required for sometime. This should also improve performance.
    
    Co-authored-by: nealef <nealef@users.noreply.github.com>
    monojenkins and nealef authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    1821d9c View commit details
    Browse the repository at this point in the history
  17. Add AOT support for the EntryPoint property for UnmanagedCallersOnly. (

    …dotnet#44809)
    
    * Change mono_reflection_create_custom_attr_data_args_noalloc () so it returns the beginning of the metadata string so its length can be computed.
    
    * Add AOT support for the EntryPoint property for UnmanagedCallersOnly.
    
    Fixes dotnet#44803.
    
    * Update src/mono/mono/mini/driver.c
    
    Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
    
    Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
    vargaz and lambdageek authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    88c4a46 View commit details
    Browse the repository at this point in the history
  18. Move EventPipe C library into shared location. (dotnet#44791)

    * Move C EventPipe library into shared location.
    
    * Fix CMake build and add CMake eventpipe test runner build.
    lateralusX authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    01c8d63 View commit details
    Browse the repository at this point in the history
  19. Increment breaking change no for doubly linked freelists (dotnet#44800)

    Update breaking change number because doubly linked free lists use one additional bit in the method table pointer at the beginning of objects now.
    
    Added a comment noting that gcDacVars->major_version_number that is set in gc.cpp is not actually checked by SOS, so SOS_BREAKING_CHANGE_VERSION should be updated if GC changes in a way that is incompatible with the existing SOS.
    PeterSolMS authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    cb8c8ec View commit details
    Browse the repository at this point in the history
  20. [mono] Unconditionally check llvm::Expected<T> for success (dotnet#44908

    )
    
    `assert()` will expand to a no-op if NDEBUG is defined, which can
    cause an assertion-enabled LLVM to trap if an `llvm::Expected<T>` is
    destroyed before having had `operator bool` applied to it.
    imhameed authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    b5dffeb View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    eb7a815 View commit details
    Browse the repository at this point in the history
  22. Delete coreconsole test hosts (dotnet#44933)

    Superceded by the shipping single-file hosts
    
    Contributes to dotnet#44848
    jkotas authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    c17ecbd View commit details
    Browse the repository at this point in the history
  23. Speed up Crossgen2 by 10% (dotnet#44917)

    Server GC looks to improve Crossgen2 compile times by up to 15% so use it by default.
    nattress authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    5b48cae View commit details
    Browse the repository at this point in the history
  24. Fix issue 44646 - ILAsm incorrectly handles method .custom attribute …

    …when we have generic type constraint (dotnet#44850)
    
    * Fix issue 44646 - ILAsm incorrectly handles method .custom attribute when we have generic type constraint
    
    The IL Assembler incorrectly dropped a .custom attribute for the method
    This only occurred when the inline syntax for generic type parameters was used in the method definition.
    This behavior can also occur for a generic class definition.
    
    * Fix typo in comment
    briansull authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    d3e5aa8 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    2b41889 View commit details
    Browse the repository at this point in the history
  26. Consolidate RID and native file naming in MSBuild scripts (dotnet#43804)

    * Consolidate RID and native file naming in MSBuild scripts
    * Use short variable names for native files naming convention, that are
      used by `framework.sharedfx.targets` in arcade, and cleanup
      redefinitions from crossgen2 and installer. e.g. `ExeSuffix` instead
      of `ApplicationFileExtension`, `LibSuffix` instead of
      `LibraryFileExtension` and so on.
    * Calculate `TargetArchitecture`, `NonPortableRuntimeOS` (for
      `PortableBuild`) and `PackageRID` values once for the entire
      livebuild, inside `eng/Configurations.props`. This implementation is
      a union of three varied implementations that are being deleted.
    * Import `names.props` once in `eng/Configurations.props` based on
      calculated `PackageRID` and cleanup imports of this file from various
      places.
    * Combine OS targets definition in MSBuild scripts.
    
    * Delete legacy tooling properties
    
    * Delete legacy tooling properties
    am11 authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    75c0b99 View commit details
    Browse the repository at this point in the history
  27. Delete NetEventSource.IsEnabled (dotnet#44901)

    * Delete NetEventSource.IsEnabled
    
    These were all meant to be changed to NetEventSource.Log.IsEnabled(), and there are almost 900 occurrences of that pattern.  But there are still 9 stragglers, and the method itself.  Deleting the method and fixing the call sites.
    
    * Fix uses in NetEventSource itself
    stephentoub authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    8bbbf6d View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    cb035a3 View commit details
    Browse the repository at this point in the history
  29. Remove temporary SuperPMI scripting code (dotnet#44962)

    Now that we have new SPMI collections, after
    dotnet#44834,
    remove temporary scripting code.
    BruceForstall authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    3c5b4a6 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    3f97ea6 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    0897d4a View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    63923b5 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    a071262 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    dc417fd View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    6904495 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    05c35a8 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    3d8515a View commit details
    Browse the repository at this point in the history
  38. Run class cctor in RuntimeHelpers.GetUninitializedObject(type). (dotn…

    …et#44898)
    
    * Run class cctor in RuntimeHelpers.GetUninitializedObject(type).
    
    Fixes dotnet#44852.
    
    * Reenable test.
    
    * Don't run the cctor for beforefieldinit classes.
    vargaz authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    3440021 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    b58991b View commit details
    Browse the repository at this point in the history
  40. Move xunit test harness to its own directory under core_root (dotnet#…

    …44921)
    
    Running `xunit.console` from within the CoreRoot directory is problematic. It is executed by the shared runtime but has a full copy of the runtime and framework libraries next to it from which assemblies are getting loaded despite being for a pre-release test runtime.
    
    Place the xunit assemblies under `<core_root>/xunit` and update the places that invoke it in local and Helix test runs.
    
    The loaded tests do reference the xunit assemblies so they need to also be available in core_root for when the tests run (with the exception of the harness specific assemblies like xunit.console).
    nattress authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    705533e View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    20aa7ad View commit details
    Browse the repository at this point in the history
  42. Enables the interpreter on iOS (dotnet#44911)

    To enable on tests, you can pass MonoForceInterpreter=true as an extra MSBuild property.
    
    AppleAppBuilder will also have a ForceInterpreter property on it in order to flow down to device / simulator.
    steveisok authored Nov 19, 2020
    Configuration menu
    Copy the full SHA
    b851613 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    0f64477 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Configuration menu
    Copy the full SHA
    5acef41 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    adfae42 View commit details
    Browse the repository at this point in the history
  3. Fix linker warning

    GrabYourPitchforks committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    49a8de1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    98c7941 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0a443c2 View commit details
    Browse the repository at this point in the history
  6. Cleanup usings

    GrabYourPitchforks committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    3b34ae6 View commit details
    Browse the repository at this point in the history
  7. Fix handling of \G in Regex.Split/Replace (dotnet#44975)

    In our optimized Regex.Split loop, we failed to update runtextstart, which means the \G anchor (aka starting where the previous match ended).
    stephentoub authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    cb80f85 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6e1b7cd View commit details
    Browse the repository at this point in the history
  9. Fix TIE wrappers

    GrabYourPitchforks committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    b588d5d View commit details
    Browse the repository at this point in the history
  10. Update unit tests

    GrabYourPitchforks committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    55aa128 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0ef275c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    4c1f5dd View commit details
    Browse the repository at this point in the history
  13. Fix build breaks

    GrabYourPitchforks committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    97f5f60 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    867bdc0 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    2e44013 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    3ecf9db View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    9c267fd View commit details
    Browse the repository at this point in the history
  18. Removed unwanted ManualResetEvent from ServiceController (dotnet#44716)

    * Removed unwanted ManualResetEvent from ServiceController
    
    Fixes dotnet#44699
    
    * Addressed PR feedback.
    Added delay of 250 ms.
    ShreyasJejurkar authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    e2312e1 View commit details
    Browse the repository at this point in the history
  19. Fix pal cgroup v2 implementation (dotnet#44990)

    * Fix pal cgroup v2 implementation
    
    Fixes two issues in src/pal/src/misc/cgroup.cpp:
    
    * No subsystem match must be performed for cgroup v2.
    * Incorrect arguments for sscanf_s when reading cgroup path.
    
    The src/gc/unix/cgroup.cpp implementation doesn't have these issues.
    
    * Rename is_subsystem_match to isSubsystemMatch
    tmds authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    70c51bb View commit details
    Browse the repository at this point in the history
  20. Preserve symbols in dbgshim (dotnet#44970)

    * Preserve symbols in the dbgshim
    
    * Remove unused library group option.
    hoyosjs authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    d85f060 View commit details
    Browse the repository at this point in the history
  21. Increase Hosting test delay to fix flaky BackgroundServiceAsyncExcept…

    …ionGetsLogged test. (dotnet#44953)
    
    * Increase Hosting test delay to fix flaky BackgroundServiceAsyncExceptionGetsLogged test.
    
    Fix dotnet#43389
    
    * Use a Task to control the delay on the background service.
    eerhardt authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    46b8b22 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    8df6fe7 View commit details
    Browse the repository at this point in the history
  23. Use substitute SHA-1 implementation in wasm (dotnet#44982)

    * Use different managed SHA-1 implementation
    
    * Add missing call to Start
    GrabYourPitchforks authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    a61b054 View commit details
    Browse the repository at this point in the history
  24. Use TryParseUInt32HexNumberStyle directly from Guid.TryParse (dotnet#…

    …44918)
    
    Skips public entry points of uint.TryParse, including argument validation, branches for style, but most impactfully fetching the current number culture when it won't actually be needed.
    stephentoub authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    f22d7c5 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    38c9b98 View commit details
    Browse the repository at this point in the history
  26. Fix CFB8 with Zero padding

    vcsjones authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    2f18501 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    5301748 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    b9630c4 View commit details
    Browse the repository at this point in the history
  29. Updated mono testing doc (dotnet#44360)

    * Update testing.md
    
    * Create testing-mono.md
    
    * Update mono testing doc
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * PR feedback
    
    * Fix format
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * PR feedback
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Update docs/workflow/testing/mono/testing.md
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    
    * Replace bullet points with sub-headers
    
    * Update sub-headers to remove the duplicated part
    
    Co-authored-by: Ryan Lucia <rylucia@microsoft.com>
    fanyang-mono and CoffeeFlux authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    a6b3b23 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    2b6d79a View commit details
    Browse the repository at this point in the history
  31. Add chmod for the SoD tool (dotnet#45014)

    * Add chmod for the SoD tool
    
    * crossgen.out input path
    DrewScoggins authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    aca7af9 View commit details
    Browse the repository at this point in the history
  32. Add missing XML docs to System.Security.* (dotnet#44461)

    * Add missing XML docs to System.Security.*
    
    * add missing <
    
    * Apply suggestions from code review
    
    Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
    
    * Update src/libraries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
    
    Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
    
    * apply feedback
    
    * fix merge conflict (renamed parameters)
    
    * Apply suggestions from code review
    
    Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
    
    * Update src/libraries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampTokenInfo.cs
    
    Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
    Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
    3 people authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    58667e7 View commit details
    Browse the repository at this point in the history
  33. Register allocation cleanup (dotnet#44977)

    * Register allocation cleanup
    
    - Comment updates
    - Misc code cleanup
    
    * jit format
    kunalspathak authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    07193b8 View commit details
    Browse the repository at this point in the history
  34. PR feedback

    GrabYourPitchforks committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    bead4c6 View commit details
    Browse the repository at this point in the history
  35. Fix buffer comparison in stream conformance tests (dotnet#45012)

    * avoid using Assert.Equals for buffer comparison in stream conformance tests because it's super, super slow
    
    * Apply suggestions from code review
    
    update span comparisons
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    
    Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    3 people authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    c409a32 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    f2e83d7 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    8d38285 View commit details
    Browse the repository at this point in the history
  38. Remove more LINQ usage from various dotnet/runtime libraries (dotnet#…

    …44964)
    
    * Remove unnecessary OrderBy / copy from MemoryCache.Compact
    
    * Replace First() in ILEmitResolverBuilder with [0]
    
    * Remove stale "using System.Linq;" from System.Text.Json
    
    * Remove stale "using System.Linq;" from System.Security.Cryptography.X509Certificates
    
    * Remove some LINQ usage from System.Security.Cryptography.Pkcs
    
    * Remove System.Linq reference from System.Private.Xml
    
    * Remove System.Linq reference from System.Net.WebHeaderCollection
    
    * Remove stale "using System.Linq;" from CookieContainer
    
    * Remove stale "using System.Linq;" from AltSvcHeaderParser
    
    * Remove Enumerable.Contains on a string from System.IO.Packaging
    
    * Remove System.Linq dependency from System.Diagnostics.Process
    
    * Remove LINQ usage from Microsoft.Extensions.Options
    
    * Remove LINQ usage from Microsoft.Extensions.Logging
    
    * Remove LINQ usage from Microsoft.Extensions.Logging.Console
    
    * Remove LINQ from CollectionExtensions.GetAssets/RuntimeFiles
    
    * Update src/libraries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/Rfc3161TimestampToken.cs
    
    Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
    
    Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
    stephentoub and bartonjs authored Nov 20, 2020
    Configuration menu
    Copy the full SHA
    f9a8abc View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Configuration menu
    Copy the full SHA
    028cde2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f12dd8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99e9cbc View commit details
    Browse the repository at this point in the history
  4. [browser][tests] Standup System.Net.WebSockets.Client.Tests in CI (do…

    …tnet#44781)
    
    * [browser][tests] Standup System.Net.WebSockets.Client.Tests in CI
    
    * Just a small test to see if tests are actually kicked off and failing.
    
    * Remove comment from ActiveIssue to pass tests
    
    * Address review comments
    
    - mark the loopback issues as activeIssue - [ActiveIssue("dotnet#34690", TestPlatforms.Browser)]
    
    * Address review comments
    
    * Correct confusion I caused
    
    * Remove extra extra exclusion that snuck in
    
    * Make browser specific failure browser specific
    
    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    kjpou1 and lewing authored Nov 21, 2020
    Configuration menu
    Copy the full SHA
    0a14898 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6c80a3d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2f8959a View commit details
    Browse the repository at this point in the history
  7. Implement getMethodModule (dotnet#45046)

    R2R testing was failing by hitting an assert about unimplemented
    getMethodModule, called as part of R2R-only devirtualization handling
    in the JIT.
    
    I didn't determine why this regressed now.
    
    Fixes dotnet#45016
    BruceForstall authored Nov 21, 2020
    Configuration menu
    Copy the full SHA
    8a3dc16 View commit details
    Browse the repository at this point in the history
  8. Handle non-ASCII strings in GetNonRandomizedHashCodeOrdinalIgnoreCase (

    …dotnet#44688)
    
    * Fix GetNonRandomizedHashCodeOrdinalIgnoreCase
    
    * Add a test
    
    Co-authored-by: Levi Broderick <levib@microsoft.com>
    EgorBo and GrabYourPitchforks authored Nov 21, 2020
    Configuration menu
    Copy the full SHA
    eb5df0d View commit details
    Browse the repository at this point in the history
  9. Use HexConverter directly when producing hex representation of enum v…

    …alue (dotnet#44945)
    
    instead of hopping over layers of ToString indirections which end up calling HexConvertor anyway.
    marek-safar authored Nov 21, 2020
    Configuration menu
    Copy the full SHA
    c4c3981 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. Configuration menu
    Copy the full SHA
    3a2021d View commit details
    Browse the repository at this point in the history
  2. Refactor RunClassConstructor

    - Add "precise cctors only?" flag
    - Convert from FCALL to QCALL
    GrabYourPitchforks committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    46ed0b8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3bc632 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3f362f2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    879937b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    93bcedb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e04401f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9887e9a View commit details
    Browse the repository at this point in the history
  9. Fix failing tests

    GrabYourPitchforks committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    186fd83 View commit details
    Browse the repository at this point in the history
  10. Fix bad assert

    GrabYourPitchforks committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    4d3d9db View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    036cbf0 View commit details
    Browse the repository at this point in the history
  12. Drop Convert static constructor dependency from RuntimeType (dotnet#4…

    …5054)
    
    * Drop Convert static constructor dependency from RuntimeTypeto make it trimmable
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    marek-safar and jkotas authored Nov 22, 2020
    Configuration menu
    Copy the full SHA
    bb492cb View commit details
    Browse the repository at this point in the history
  13. Avoid using GetEEFuncEntryPoint

    - Works around failing assert in frames.cpp:1790
    GrabYourPitchforks committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    882b63e View commit details
    Browse the repository at this point in the history
  14. Fix Typos (#45024)

    N authored Nov 22, 2020
    Configuration menu
    Copy the full SHA
    f67389f View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0b0c8db View commit details
    Browse the repository at this point in the history
  16. Delete unused WinRT related strings (dotnet#45067)

    Fix a few typos
    jkotas authored Nov 22, 2020
    Configuration menu
    Copy the full SHA
    12ae956 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    c50d287 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e2235cc View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    cebbf48 View commit details
    Browse the repository at this point in the history
  20. Improve throughput of Environment.GetEnvironmentVariables() (dotnet#4…

    …5057)
    
    Use IndexOf to search for positions rather than open-coded loops, taking advantage of vectorization to improve throughput.
    stephentoub authored Nov 22, 2020
    Configuration menu
    Copy the full SHA
    bf302de View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Create cancellation token registration wrapper only when it's needed (d…

    …otnet#45075)
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    marek-safar and stephentoub authored Nov 23, 2020
    Configuration menu
    Copy the full SHA
    7218577 View commit details
    Browse the repository at this point in the history
  2. disable ReadWrite_Success_Large test for CryptoStream because it take…

    …s too long to run (dotnet#45081)
    
    Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
    geoffkizer and Geoffrey Kizer authored Nov 23, 2020
    Configuration menu
    Copy the full SHA
    e8c4f22 View commit details
    Browse the repository at this point in the history
  3. Skip Invariant initialization test for CultureData.Invariant (dotnet#…

    …45064)
    
    * Skip Invariant initalization test for CultureData.Invariant
    
    * Feedback
    benaadams authored Nov 23, 2020
    Configuration menu
    Copy the full SHA
    8861c41 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    65d42f0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e274015 View commit details
    Browse the repository at this point in the history
  6. Use argIsInvariant instead of argNode->OperIsConst() for inlining…

    … observations. (dotnet#44790)
    
    * Use `argIsInvariant` instead of `argNode->OperIsConst()`.
    
    * add a small repro test for the current issue.
    Sergey Andreenko authored Nov 23, 2020
    Configuration menu
    Copy the full SHA
    78adc93 View commit details
    Browse the repository at this point in the history
  7. Use Type.EmptyTypes consistently (dotnet#45112)

    We currently have several hundred uses of `Array.Empty<Type>()` and several hundred uses of `Type.EmptyTypes`.  This just changes the repo to use the latter consistently.
    stephentoub authored Nov 23, 2020
    Configuration menu
    Copy the full SHA
    e2099f6 View commit details
    Browse the repository at this point in the history
  8. Update ILVerify readme (dotnet#45123)

    ILVerify is published on nuget now. It is not required to use the nightly feed anymore.
    jkotas authored Nov 23, 2020
    Configuration menu
    Copy the full SHA
    202f6e1 View commit details
    Browse the repository at this point in the history
  9. Remove most uses of RuntimeTypeHandle.Allocate (dotnet#45085)

    - Refactoring paves way for related work in dotnet#32520
    - Fixes some possible GC holes in the reflection stack
    GrabYourPitchforks authored Nov 23, 2020
    Configuration menu
    Copy the full SHA
    3f89665 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Configuration menu
    Copy the full SHA
    d373fe7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    12b4578 View commit details
    Browse the repository at this point in the history
  3. PR feedback

    GrabYourPitchforks committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    a7fa617 View commit details
    Browse the repository at this point in the history
  4. Fix native build on arm and arm64. (dotnet#45131)

    * Fix native build on arm and arm64.
    
    * Fix a typo.
    Sergey Andreenko authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    89383aa View commit details
    Browse the repository at this point in the history
  5. Fix CoreRT frozen strings handling. (dotnet#45095)

    * Fix CoreRT frozen strings handling.
    
    * Review response.
    
    * Delete noway_assert.
    
    * Additional checks.
    
    * Fix failures.
    Sergey Andreenko authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    1fa2054 View commit details
    Browse the repository at this point in the history
  6. Update nullability.md

    stephentoub authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    aebd598 View commit details
    Browse the repository at this point in the history
  7. Reduce RuntimeType.MakeGenericType overheads (dotnet#45137)

    - Avoid an extra GetGenericArguments() call for all arities.
    - Special-case a Type[] with just one type.  In looking at all calls to MakeGenericType when starting up a basic ASP.NET MVC app, 70% were for a single generic argument (the rest were for two).
    stephentoub authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    664b962 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2e8c4c7 View commit details
    Browse the repository at this point in the history
  9. add support for less standard serial port speeds on macOS (dotnet#44052)

    * add support for less standard serial port speeds on macOS
    
    * s/ifdef/if
    wfurt authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    d73c65e View commit details
    Browse the repository at this point in the history
  10. Delay initialization of Task related properties which are rarely used (

    …dotnet#45127)
    
    * Delay initialization of Task related properties which are rarely used
    
    to reduce the dependencies chain
    
    * Apply PR review suggestions
    
    * fix up previous commit
    
    * Update src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    marek-safar and stephentoub authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    f3acf03 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    62f55e1 View commit details
    Browse the repository at this point in the history
  12. JIT: change basic block weight to float (dotnet#45052)

    Change the core data type for basic block weights from unsigned to float,
    to simplify overall calculations and allow for a wider dynamic range.
    
    Many changes are straightforward, but a few are worth noting:
    * LSRA needs a true max weight, so had to introduce infinity
    * I removed some of the overflow checking as floats naturally saturate.
    * The simple geometric loop weight scaling (*8 per loop nest level) leads
      to some very large counts in some tests (15 level loop nests). We may
      want to rethink this and scale less aggressively in deep nests.
    * Morph's use of the weighted ref counts for RCS_EARLY is nonstandard
      and the values are not actually weights, so I just added a cast back to unsigned.
    * Several places in the jit seem to try and compare or combine unweighted
      and weighted counts; I don't think this makes sense. But have left as is.
    * Lower, LIR, and Decompose were passing around weights but never using them.
    * I had to introduce a special new weight for the inline projection we do
      for the prejit root.
    
    These changes lead to small numbers of diffs, mostly places where small rounding
    changes have altered heuristics; notably:
    * cse weights
    * LSRA's initial take on whether a parameter should be enregistered
    
    Overall diff impact is a wash.
    
    There are almost no diffs without PGO/IBC data. Diffs are slightly more
    prominent in the Roslyn assemblies prejitted with some IBC.
    
    I've tried to keep the format of weights the same in dumps (in most places)
    and see minimal diffs in dumps too.
    AndyAyersMS authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    7031456 View commit details
    Browse the repository at this point in the history
  13. Reduce SafeHandle allocation in CertEnumCertificatesInStore (dotnet#4…

    …5166)
    
    And avoiding leaving the last invalid one for finalization.
    stephentoub authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    e04274e View commit details
    Browse the repository at this point in the history
  14. Fix work item exit code for helix tests (dotnet#45164)

    * Fix work item exit code for helix tests
    
    The helix work items are only supposed to return non-zero if they fail
    to report tests for some reason.
    
    * Fix if
    alexperovich authored Nov 24, 2020
    Configuration menu
    Copy the full SHA
    50c4607 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. Keep precise argument sizes between import and morph. (dotnet#43130)

    Create `GT_PUTARG_TYPE` when signature type does not match node type.
    Check in morph that this information has survived inlining and other phases between.
    Sergey Andreenko authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    3e65d68 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    93cbc09 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3e9438c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9c20d84 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fa367a3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4b38b6c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9ed2b9b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fe80a77 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0ebebd6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e08358f View commit details
    Browse the repository at this point in the history
  11. Fix Socket telemetry outerloop test failures (dotnet#45170)

    Based purely on code inspection, since I couldn't repro the failures happening in the lab, I believe what's happening is we're not outputting the right events if the connect ends up completing so fast that it's treated as a synchronous completion.  The fix is to move the relevant tracing to be done when the work completes, regardless of the completion mode.
    
    I was able to simulate at least one set of failures by delaying the calling thread before it reaches a particular point, and this fixes that issue, so even if it's not fixing all known problems (hopefully it is), it's at least fixing some.
    stephentoub authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    0262b49 View commit details
    Browse the repository at this point in the history
  12. Implement TCP Keep-Alive for WinHttpHandler (dotnet#44889)

    Implements the final version of the API proposal in dotnet#44025 except the [SupportedOSPlatform("windows10.0.2004")] bits
    antonfirsov authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    837785f View commit details
    Browse the repository at this point in the history
  13. Fix spelling of OverideEventProvider (dotnet#45113)

    * Fix spelling of OverideEventProvider
    
    * Fix a few more "overrides" in comments
    stephentoub authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    2c155c2 View commit details
    Browse the repository at this point in the history
  14. [master] Update dependencies from dotnet/icu dotnet/llvm-project dotn…

    …et/arcade dotnet/runtime-assets dotnet/xharness (dotnet#44459)
    
    [master] Update dependencies from dotnet/icu  dotnet/llvm-project dotnet/arcade dotnet/runtime-assets dotnet/xharness
    
    
     - Merge branch 'master' into darc-master-f04f89fe-a712-45ce-96bf-a8d278fcda72
    
     - Revert changes to dotnet sdk in global.json
    
    See dotnet#45108 (review)
    dotnet-maestro[bot] authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    96a49a1 View commit details
    Browse the repository at this point in the history
  15. [wasm] change filtering system timezones from zone.tab as a task para…

    …meter (dotnet#45138)
    
    * change filtering system timezones from zone.tab as a task parameter
    
    Co-authored-by: Ankit Jain <radical@gmail.com>
    tqiu8 and radical authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    d6b9adb View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f066972 View commit details
    Browse the repository at this point in the history
  17. Mono: switch to CMake build on Windows (dotnet#44976)

    This unifies the build with the other platforms.
    
    Hooks up the versioning targets so the mono libraries get the correct version.
    akoeplinger authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    23f7fbc View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    854fde6 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    ffc141a View commit details
    Browse the repository at this point in the history
  20. Initial version of class profiling for PGO (dotnet#45133)

    * Initial version of class profiling for PGO
    
    Add support to the jit and runtime so that PGO can determine the distribution of
    classes at virtual and indirect call sites.
    
    Use this information when jitting to enable guarded devirtualization, if there
    is a suitably likely class to guess for.
    
    Enable by setting:
    ```
    COMPlus_TieredCompilation=1
    COMPlus_TieredPGO=1
    COMPlus_JitClassProfiling=1
    COMPlus_JitEnableGuardedDevirtualization=1
    ```
    impact can be enhanced by also setting
    ```
    COMPlus_TC_QuickJitForLoops=1
    ```
    to allow more methods to pass through Tier0.
    AndyAyersMS authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    5a6c21c View commit details
    Browse the repository at this point in the history
  21. Handle unsupported browser warnings (dotnet#43363)

    * Handle browser warnings
    
    * Apply feedback, revert updates handled with different PRs
    
    * Add misssing diagnotic id
    
    * Address multitargeted warnings
    
    * Apply feedback
    
    * Small type/comment updates
    
    * Apply more feedback
    
    * Use project settings instead adding Directory.Build.props
    
    * Annotate APIs injecting unsupported type through DI
    
    * Fix window support related warnings found with generic type parameter
    
    * Fix another browser warning found with generic type parameter bug fix
    
    * All public APIs of ConsoleLoggerExtensions are unsupported, so marking entire type as unsupported on browser
    
    * Try handle mono warnings
    
    * Revert mono related changes, it was mistake
    
    * Try handle browser warninga in mono
    
    * Apply feedback and fix new warnings caused from corelib changes
    
    * Review update
    
    * Apply feedback
    
    * Move platform specific section from HttpTelemetry
    
    * Revering unwanted changes
    
    * Remove redundant attributes
    
    * Exclude cross platform build with browser target
    
    * small updates
    
    * Annotate entire type DiagnosticCounter unsupported
    
    * Apply feedback, improve suppression comments
    
    * Remove Unsupported browser from TypeDescriptor.CreateInstance, TypeDescriptionProvider.CreateInstance and related updates
    buyaa-n authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    abc525d View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    f48c8d5 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    9f6b9d1 View commit details
    Browse the repository at this point in the history
  24. Reduce allocation in OptionsManager (dotnet#45231)

    * Reduce allocation from OptionsCache's concurrent dictionary
    
    This type is primarily used for getting and rarely mutated after startup; we don't need to pay for lots of lock objects to optimize for mutation.
    
    * Avoid closure/delegate allocations in `OptionsManager<T>.Value`
    
    * Update src/libraries/Microsoft.Extensions.Options/src/OptionsCache.cs
    
    Co-authored-by: David Fowler <davidfowl@gmail.com>
    
    Co-authored-by: David Fowler <davidfowl@gmail.com>
    stephentoub and davidfowl authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    b8faf45 View commit details
    Browse the repository at this point in the history
  25. Update dependencies from https://github.com/dotnet/xharness build 202…

    …01125.2 (dotnet#45216)
    
    Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
     From Version 1.0.0-prerelease.20574.2 -> To Version 1.0.0-prerelease.20575.2
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Nov 25, 2020
    Configuration menu
    Copy the full SHA
    db9fe14 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    374cf34 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    6b23817 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. More code cleanup

    GrabYourPitchforks committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    11be754 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d43a91 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0635399 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9ac3c3f View commit details
    Browse the repository at this point in the history
  5. Fix bad assert

    GrabYourPitchforks committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    a06ef73 View commit details
    Browse the repository at this point in the history
  6. Update src/coreclr/src/vm/reflectioninvocation.cpp

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    GrabYourPitchforks and jkotas authored Nov 26, 2020
    Configuration menu
    Copy the full SHA
    1b1261f View commit details
    Browse the repository at this point in the history
  7. PR feedback

    GrabYourPitchforks committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    94f8614 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c73e9fa View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    359a588 View commit details
    Browse the repository at this point in the history