forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eng 3579 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding version params * test cases for version * removing console log
Persgroep wants to run full page takeovers hence the request. Separate discussion on-going for Demand Manager too.
* Initial revision of adocean bid adapter (ADOCEAN-13634, ADOCEAN-13635) * Minor fixes * new demo placement * formating after lint * move request parameters to params * adocean adpater tests * minor fixes * added ttl, netRevenue nad creativeId. merged with upstream * GDPR support * do not send empty gdpr_consent * GDPR support * do not send empty gdpr_consent * AdOcean adapter: tests for gdpr_support * remove old comment * Added possibility to use multiple times same ad placement * Tests for placement duplication and gdpr support. * formating * add randomized part to endpoint url * fix tests after endpoint url change Co-authored-by: Jacek Drobiecki <jacek.drobiecki@gmail.com>
…once. (prebid#4833) * Set srcPageUrl only once. * Set adCode only once.
* lemmaBidAdapter.js Added lemma bid adapter file * lemmaBidAdapter.md Added lemma bid adapter md file * lemmaBidAdapter_spec.js Added lemma bid adapter test spec file * Update lemmaBidAdapter.js Fixed automated code review alert comparison between inconvertible types * Update lemmaBidAdapter.js Fixed review changes * Update lemmaBidAdapter.md Correct parameter value. * Update lemmaBidAdapter.js Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter_spec.js Lemma Bid Adapter - v3.0 compliance * Update lemmaBidAdapter.md Lemma Bid Adapter - v3.0 compliance
updated GDPR implementation for OpenRTB v2.2+ support
* Fixed oneVideo TypeError when consentData is undefined * Check consentData is defined
* implements the todo comment in the code adUnit.sizes was still being referenced here in two places despite being deprecated. This simply deletes the references. * Update pbjs_api_spec.js * Update pbjs_api_spec.js
* Initial draft changes for adapter * Updated bids and tests * Fixed timeouts being sent all the time * Added prod endpoint back * Test Updates to be more in line with base spec file * Sending bidder params to server with win event * Missed a conflict with new XHR functionality * Added local Object.entries polyfill
* real time data module, browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe * change timeout&primary ad server only to auctionDelay update docs * support multiple providers * change promise to callbacks configure submodule on submodules.json * bug fixes * use Prebid ajax * tests fix * browsi real time data provider improvements * real time data module, browsi sub module for real time data, new hook bidsBackCallback, fix for config unsubscribe * change timeout&primary ad server only to auctionDelay update docs * support multiple providers * change promise to callbacks configure submodule on submodules.json * bug fixes * use Prebid ajax * tests fix * browsi real time data provider improvements * remove eval * use external script, update macro function * lint errors * removed log
* Support for user block from the Adapter * Added Unit tests and using utils.getCookie and utils.setCookie() * Dummy change to triger CI * Dummy change * Support for pixel sync urls
Updated email for current maintainer contact at sovrn jrosendahl@sovrn.com.
…#4841) * add seedingAlliance Adapter * add two native default params * ... * ... * seedingAlliance Adapter: add two more default native params
This module is deprecated and should not be used anymore. The Criteo ID for Exchanges module should be used instead. It is available here
* Aggiunge il passaggio della stringa di privacy ccpa * Cambia nome variabile us privacy in getUserSyncs
…les for prebid3.0 (prebid#4844) * Implemented schain support for prebid and updated documentation examples for prebid 3.0 * fix build failure
* pass us privacy consent string to request * passes bid response currency * adds test for passing bid response currency * implements video support * fix linting
* Add Adman bid adapter * Add supportedMediaTypes property * Update ADman Media bidder adapter * Remove console.log * Fix typo * revert package-json.lock * Delete package-lock.json * back to original package-lock.json * catch pbjs error * catch pbjs error * catch pbjs error * log * remove eu url * remove eu url * remove eu url * remove eu url * remove eu url Co-authored-by: mkatogi <mkatogi@gmail.com> Co-authored-by: minokem <48562317+minokem@users.noreply.github.com> Co-authored-by: ADman Media <ruben.caro@admanmedia.com>
* Add microadBidAdapter * Remove unnecessary encodeURIComponent from microadBidAdapter * Submit Advangelists Prebid Adapter * Submit Advangelists Prebid Adapter 1.1 * Correct procudtion endpoint for prebid * analytics update with wrapper name * reverted error merge * update changed default value of netRevenue to true * Support user and context first party data in rubicon and prebid server adapters * Place user and context within fpd object * Separate global and bidder-specific first party data * Repeat FPD for each bidder when sending to PBS Co-authored-by: Isaac A. Dettman <idettman@rubiconproject.com>
* Add COPPA support * Modify test
* longform and other e2etests with mock server * tests with mock response * fix indentation * instream e2e tests * consent management e2e tests * gdpr mock response file * currency e2e * refactor structure * add test for targeting keys * e2e prebid features * e2e sizeConfig feature * refactor * fix lint errors * update test title * multiple bidders adUnit test * switch to parent to switch frames * add debugger to test page Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com> Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
…rebid#4734) * add validation to callbackWithBidder to ensure called with function * better error message in callbackWithBidder
* added UserSync * added UserSync Unit Test * support for multi sizes * register the adapter as supporting video * supporting video * change requestId acquisition method * fix the parameter name of dealID * update test parameters * support instream video * add test for bidRequest * add test for interpretResponse * add test params * add note to documentaion * add payload params * add test * delete tmax param * add tid param
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * added .js to imports in vdoai spec
* Add consumed to bid response * Modify test * Use include instead of containAllKeys * Use adUnitCode to match response and request * Add test * Restore packageLock
* add no-console eslint rule for tests directory * remove console logs from onetag tests * update scope of rule to include src files
* replace karma-coverage-istanbul-reporter with karma-coverage * remove unused variable * create coverage folder when required * merge with master to fix issue of all unit tests not running * update processKillTimeout to 10secs * change reporter type html to lcov
* 7xbid adapter * fix error when cli build * update to implement prebid 3.0 * remove unneeded code Co-authored-by: Nguyen Le Thinh <thinhnl@geniee.co.jp>
Co-authored-by: rmartinez <Rachael24!>
Co-authored-by: rmartinez <Rachael24!>
Co-authored-by: Ambuj Gupta <ambuj.g@media.net>
* added option to url parser to ignore decoding entire url * add try catch just in case * updated to test Co-authored-by: rmartinez <Rachael24!>
Co-authored-by: rmartinez <Rachael24!>
* Added adapter without tests * Added readme * Added tests and CCPA support * Cleaned code, fixed tests * reverted examples * Added more tests + CR fixes * Fixed example in lifestreet readme, reverted integration example page * restored permission for page example
* implement size bucket filtration logic * finish implmenation of getFilteredMediaTypes * implement getBids function * log useful information to the console * enable test workflow * modify checkAdUnitSetup function to account for the new sizeConfig object * remove unrelated example * add decider function to choose between sizeMapping v1 and sizeMapping v2 * add getBidsHook for s2s bidders * handle edge case where all mediaTypes get filtered out and the case when bidder gets filtered out * add test examples for banner media type * update label check to pick up the fist label operator instead of the last on incase there are multiple lables present * added example for label checks with banner ad * add checkAdUnit setup hook on sizeMappingV2 modules to check presence of sizeConfig property in addition to doing normal adUnit checks * restore old hello world example * give free pass to video mediaTypes configured with sizeConfig property, while keeping in place the essential sizeConfig checks * fixing minor bus and enchancing bidder level sizeConfig checks * bugfix: checkBidderSizeConfigFormat * add more scenarios for testing sizeMapping V2 * small docs changes * feedback1 changes * modify logic for bailing out * add module description * refactor isUsingNewSizeMapping function by making it a pure function * add unit test case for isUsingNewSizeMapping function * made adUnit checks more robusts and fully make adUnit.mediaTypes mandatory * remove redundancy in checAdUnitSetupHook * add banner units test cases for checkAdUnitSetupHook function * add video and native mediaTypes units test for checkAdUnitSetupHook function * rewrite some of the log messages * redefine log messages to make it simple to the end user * code optimization done so that getFilteredMediaTypes function gets called only once per adUnit per auction * add code comments * code refactorization and more unit test cases * more unit tests for getBids function * add sizeMapping usage example * delete sizeMappingV2 directory * add doctype declaration * fix LGTM alert and revert changes to pbjs_api.spec.js * fix LGTM alerts in sizeMappingV2_spec file * add file extension for imports
* add mediaforce bid adapter * make use of unused variable language
* added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * fixing liveintent-segments added separate functions in config for eid.ext and uid.ext liventent segments should have been in eid.ext not in eid.uids[].ext * added example of generated eids array * formating * commeneted a console log; avoiding lint error * fixed breaking test-cases
aecook
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates prebid to the latest stable release - 3.11.0