merge from remote #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @aws-amplify/amplify-category-api@1.2.5 - amplify-category-function@3.4.0 - @aws-amplify/cli@7.6.14 - amplify-console-integration-tests@2.2.21 - amplify-container-hosting@2.4.16 - amplify-dotnet-function-template-provider@2.2.17 - amplify-e2e-core@2.6.4 - amplify-e2e-tests@3.7.4 - @aws-amplify/graphql-auth-transformer@0.7.0 - @aws-amplify/graphql-default-value-transformer@0.5.14 - @aws-amplify/graphql-function-transformer@0.7.9 - @aws-amplify/graphql-http-transformer@0.8.9 - @aws-amplify/graphql-index-transformer@0.11.0 - @aws-amplify/graphql-maps-to-transformer@1.1.0 - amplify-graphql-migration-tests@2.2.23 - @aws-amplify/graphql-model-transformer@0.13.0 - @aws-amplify/graphql-predictions-transformer@0.6.9 - @aws-amplify/graphql-relational-transformer@0.7.0 - @aws-amplify/graphql-schema-test-library@1.0.2 - @aws-amplify/graphql-searchable-transformer@0.13.0 - @aws-amplify/graphql-transformer-core@0.16.0 - @aws-amplify/graphql-transformer-interfaces@1.13.0 - @aws-amplify/graphql-transformer-migrator@1.2.21 - amplify-migration-tests@4.4.15 - amplify-nodejs-function-template-provider@2.2.17 - amplify-provider-awscloudformation@5.9.0 - amplify-util-mock@4.3.0 - @aws-amplify/amplify-util-uibuilder@1.2.6 - graphql-auth-transformer@7.2.17 - graphql-connection-transformer@5.2.17 - graphql-dynamodb-transformer@7.2.17 - graphql-elasticsearch-transformer@5.2.17 - graphql-function-transformer@3.3.8 - graphql-http-transformer@5.2.17 - graphql-key-transformer@3.2.17 - graphql-predictions-transformer@3.2.17 - graphql-relational-schema-transformer@2.21.4 - graphql-transformer-common@4.23.0 - graphql-transformer-core@7.4.0 - graphql-transformers-e2e-tests@7.4.0 - graphql-versioned-transformer@5.2.17
Co-authored-by: ammarkarachi <ammkara@dev-dsk-ammkara-2a-8b7d2720.us-west-2.amazon.com>
- amplify-app@4.2.16 - amplify-category-analytics@3.2.15 - @aws-amplify/amplify-category-api@1.2.6 - @aws-amplify/amplify-category-auth@2.4.12 - @aws-amplify/amplify-category-custom@2.3.14 - amplify-category-function@3.4.1 - amplify-category-geo@2.3.5 - amplify-category-hosting@3.2.15 - amplify-category-interactions@3.2.15 - amplify-category-predictions@3.2.15 - @aws-amplify/amplify-category-storage@3.1.11 - amplify-category-xr@3.2.15 - amplify-cli-core@2.4.10 - @aws-amplify/cli-extensibility-helper@2.3.10 - @aws-amplify/cli@7.6.15 - amplify-console-hosting@2.2.15 - amplify-console-integration-tests@2.2.22 - amplify-container-hosting@2.4.17 - amplify-dotnet-function-template-provider@2.2.18 - amplify-dynamodb-simulator@2.2.15 - amplify-e2e-core@2.6.5 - amplify-e2e-tests@3.7.5 - amplify-frontend-ios@3.3.15 - amplify-frontend-javascript@3.3.15 - amplify-go-function-runtime-provider@2.2.15 - @aws-amplify/graphql-auth-transformer@0.7.1 - @aws-amplify/graphql-maps-to-transformer@1.1.1 - amplify-graphql-migration-tests@2.2.24 - @aws-amplify/graphql-relational-transformer@0.7.1 - @aws-amplify/graphql-schema-test-library@1.0.3 - @aws-amplify/graphql-transformer-migrator@1.2.22 - amplify-java-function-runtime-provider@2.2.15 - amplify-migration-tests@4.4.16 - amplify-nodejs-function-runtime-provider@2.2.15 - amplify-nodejs-function-template-provider@2.2.18 - amplify-provider-awscloudformation@5.9.1 - amplify-python-function-runtime-provider@2.2.15 - amplify-util-import@2.2.15 - amplify-util-mock@4.3.1 - @aws-amplify/amplify-util-uibuilder@1.2.7 - graphql-auth-transformer@7.2.18 - graphql-connection-transformer@5.2.18 - graphql-dynamodb-transformer@7.2.18 - graphql-elasticsearch-transformer@5.2.18 - graphql-function-transformer@3.3.9 - graphql-http-transformer@5.2.18 - graphql-key-transformer@3.2.18 - graphql-predictions-transformer@3.2.18 - graphql-transformer-core@7.4.1 - graphql-transformers-e2e-tests@7.4.1 - graphql-versioned-transformer@5.2.18
* fix: validation for s3 bucketname in s3-cli walkthrough * address PR:9555 comments * address 9555-PR2 for prompter * e2e test for S3 bucket hyphenated bucket name * address PR-3 comment * removed e2e test for hyphens and fixed whitespaces * (chore) removed vars from now removed e2e test * (chore) add troubleshooting link for push, pull and publish errors * (chore) make document paths generic and move them to core Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com>
… add lambda types (#9649) * feat: consolidate console.log, add jsdoc, add lambda types * feat: add jsdoc to auth trigger templates * feat: improve jsdoc in auth trigger templates
* feat: update admin queries package dependencies, scripts * feat: move aws-sdk to devdependencies in adminqueries
* fix: rest policy size calculation * test: add tests * test: update rest e2e test with multiple paths to test policy slicing * fixup: test: updated tests Co-authored-by: Yathi <511386+yuth@users.noreply.github.com>
* chore(cli): remove enquirer direct dependency, extra import * fix: lgtm bot error
* fix: test for hosteduiproviders fix * test: updated snapshot Co-authored-by: ammarkarachi <ammkara@dev-dsk-ammkara-2a-8b7d2720.us-west-2.amazon.com>
Co-authored-by: ammarkarachi <ammkara@dev-dsk-ammkara-2a-8b7d2720.us-west-2.amazon.com>
The message shown on ERR_INVALID_URL errors changed slightly in Node 16. This commit updates two AWSURL unit tests to pass across supported Node.js versions. Fixes: #9703 Co-authored-by: Colin Ihrig <colihrig@amazon.com>
* test: add delay so the test does not pick previous pattern * test: use group names for walkthrough Co-authored-by: ammarkarachi <ammkara@dev-dsk-ammkara-2a-8b7d2720.us-west-2.amazon.com>
…uthenticated by cognito (#9682) * fix(graphql): allow iam private rule to access update mutation when authenticated by cognito * added tests * add update post vtl assertion
- amplify-app@4.2.20 - amplify-appsync-simulator@2.3.7 - amplify-category-analytics@3.2.19 - @aws-amplify/amplify-category-api@1.2.10 - @aws-amplify/amplify-category-auth@2.5.0 - @aws-amplify/amplify-category-custom@2.3.18 - amplify-category-function@3.5.0 - amplify-category-geo@2.3.9 - amplify-category-hosting@3.2.19 - amplify-category-interactions@3.2.19 - amplify-category-notifications@2.19.5 - amplify-category-predictions@3.2.19 - @aws-amplify/amplify-category-storage@3.1.15 - amplify-category-xr@3.2.19 - amplify-cli-core@2.4.14 - @aws-amplify/cli-extensibility-helper@2.3.14 - @aws-amplify/cli@7.6.19 - amplify-console-hosting@2.2.19 - amplify-console-integration-tests@2.2.26 - amplify-container-hosting@2.4.21 - amplify-dotnet-function-runtime-provider@1.6.7 - amplify-dotnet-function-template-provider@2.2.22 - amplify-dynamodb-simulator@2.2.19 - amplify-e2e-core@2.6.9 - amplify-e2e-tests@3.7.9 - amplify-frontend-ios@3.3.19 - amplify-frontend-javascript@3.3.19 - amplify-go-function-runtime-provider@2.2.19 - amplify-graphiql-explorer@2.4.4 - @aws-amplify/graphql-auth-transformer@0.7.5 - @aws-amplify/graphql-default-value-transformer@0.5.15 - @aws-amplify/graphql-maps-to-transformer@1.1.5 - amplify-graphql-migration-tests@2.2.28 - @aws-amplify/graphql-relational-transformer@0.7.5 - @aws-amplify/graphql-schema-test-library@1.0.7 - @aws-amplify/graphql-searchable-transformer@0.13.1 - @aws-amplify/graphql-transformer-migrator@1.2.26 - amplify-headless-interface@1.14.1 - amplify-java-function-runtime-provider@2.2.19 - amplify-migration-tests@4.4.20 - amplify-nodejs-function-runtime-provider@2.2.19 - amplify-nodejs-function-template-provider@2.3.0 - amplify-provider-awscloudformation@5.9.5 - amplify-python-function-runtime-provider@2.2.19 - amplify-storage-simulator@1.6.4 - amplify-util-headless-input@1.9.1 - amplify-util-import@2.2.19 - amplify-util-mock@4.3.5 - @aws-amplify/amplify-util-uibuilder@1.2.11 - graphql-auth-transformer@7.2.22 - graphql-connection-transformer@5.2.22 - graphql-dynamodb-transformer@7.2.22 - graphql-elasticsearch-transformer@5.2.22 - graphql-function-transformer@3.3.13 - graphql-http-transformer@5.2.22 - graphql-key-transformer@3.2.22 - graphql-predictions-transformer@3.2.22 - graphql-transformer-core@7.4.5 - graphql-transformers-e2e-tests@7.4.5 - graphql-versioned-transformer@5.2.22
Updates the URL displayed in the CLI to the new URL fix #9558
Bumps [simple-get](https://github.com/feross/simple-get) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/feross/simple-get/releases) - [Commits](feross/simple-get@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: simple-get dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) --- updated-dependencies: - dependency-name: ini dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.21) --- updated-dependencies: - dependency-name: lodash dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…t) (#10222) * Revert "Revert "feat: add handling of colon-delimited identity claims to query (#10189)" (#10213)" This reverts commit 9f13064. * feat: put field resolver behind feature flag * fix: add feature flag to tests * fix: use resolver helper for field * fix: update query requests with double delimiter * test: update snapshots for unit tests * test: add feature flag to mock e2e test * fix: fix primary and index key in auth * fix: add claim matching for passed in list params * fix: change field map to use claim and update snapshots
…10198) * test: e2e tests to check that libraries can query new identity claim * test: add feature flags to e2e tests * test: add e2e tests with feature flag to test backwards compatibility * fix: fix felds names in e2e custom claim test * Update packages/amplify-e2e-tests/src/schema-api-directives/common.ts Co-authored-by: John Hockett <jhockett@users.noreply.github.com> * test: update snapshot for api tests * test: add e2e test with ff off * fix: update snapshots to match double colon * test: add feature flag to transformers options e2e test * test: update list query to return expected query Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
…nd a feature flag (#10196) * feat: add writes with new identity claim and warning for change * fix: add double colon to tests and fix relational snap * fix: update snapshots for owner auth test * fix: update identity claim version change to next major * feat: add migration docs url to warning * fix: use owner claim list for field map with multi claims * test: update snapshots * fix: update velocity tests to use jwt token
Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com>
* feat: dedup appsync functions * chore: lint fixes * fix: address comments * feat: change to bump npm major version * fix: adds template hash function
- amplify-app@4.2.30 - amplify-category-analytics@4.0.3 - @aws-amplify/amplify-category-api@2.0.4 - @aws-amplify/amplify-category-auth@2.7.12 - @aws-amplify/amplify-category-custom@2.3.29 - amplify-category-function@4.0.3 - amplify-category-geo@2.5.2 - amplify-category-hosting@3.2.28 - amplify-category-interactions@4.0.3 - amplify-category-predictions@4.0.3 - @aws-amplify/amplify-category-storage@3.1.26 - amplify-category-xr@3.2.28 - amplify-cli-core@2.6.0 - @aws-amplify/cli-extensibility-helper@2.3.25 - @aws-amplify/cli@8.1.0 - @aws-amplify/cli-internal@8.1.0 - amplify-console-hosting@2.2.28 - amplify-console-integration-tests@2.2.37 - amplify-container-hosting@2.4.33 - amplify-dotnet-function-template-provider@2.2.32 - amplify-dynamodb-simulator@2.2.28 - amplify-e2e-core@3.1.2 - amplify-e2e-tests@3.9.0 - amplify-frontend-ios@3.4.2 - amplify-frontend-javascript@3.4.3 - amplify-go-function-runtime-provider@2.2.28 - @aws-amplify/graphql-auth-transformer@0.9.0 - @aws-amplify/graphql-default-value-transformer@0.5.22 - @aws-amplify/graphql-function-transformer@0.7.16 - @aws-amplify/graphql-http-transformer@0.8.16 - @aws-amplify/graphql-index-transformer@0.11.7 - @aws-amplify/graphql-maps-to-transformer@1.1.14 - amplify-graphql-migration-tests@2.2.39 - @aws-amplify/graphql-model-transformer@0.14.0 - @aws-amplify/graphql-predictions-transformer@0.6.16 - @aws-amplify/graphql-relational-transformer@0.9.0 - @aws-amplify/graphql-schema-test-library@1.0.17 - @aws-amplify/graphql-searchable-transformer@0.14.0 - @aws-amplify/graphql-transformer-core@0.17.0 - @aws-amplify/graphql-transformer-interfaces@1.14.0 - @aws-amplify/graphql-transformer-migrator@1.2.36 - amplify-java-function-runtime-provider@2.2.28 - amplify-migration-tests@4.4.31 - amplify-nodejs-function-runtime-provider@2.2.28 - amplify-nodejs-function-template-provider@2.3.14 - amplify-provider-awscloudformation@6.1.3 - amplify-python-function-runtime-provider@2.2.28 - amplify-util-import@2.2.28 - amplify-util-mock@4.4.0 - @aws-amplify/amplify-util-uibuilder@1.2.23 - graphql-auth-transformer@7.2.32 - graphql-connection-transformer@5.2.32 - graphql-dynamodb-transformer@7.2.32 - graphql-elasticsearch-transformer@5.2.32 - graphql-function-transformer@3.3.23 - graphql-http-transformer@5.2.32 - graphql-key-transformer@3.2.32 - graphql-predictions-transformer@3.2.32 - graphql-transformer-core@7.5.0 - graphql-transformers-e2e-tests@7.5.0 - graphql-versioned-transformer@5.2.32
* chore(amplify-category-api): split API plugin dependencies * chore(amplify-category-api): remove unrelated doc files * chore(amplify-category-api): update package scripts, tsconfig * chore(amplify-category-api): update dependency on migrated packages * chore: update yarn.lock after split * fix: update mock test avoid importing mocked featureflag provider from trasnsformer Co-authored-by: Al Harris <alharris@dev-dsk-alharris-2a-edcf13de.us-west-2.amazon.com>
…st packages which no longer exist in this repo (#10335)
…SO and credential_process (#9095) Make sure the right profile is used when using credential_process When using credential_process in the AWS profile (to get SSO to work for example) the ProcessCredentials Provider is used. When using the default chain from the aws-sdk no options are passed to it and it default to using AWS_PROFILE. With this change, we detect ```credential_process``` and specifically pass the profile name into the credential chain to ensure it gets used. re #4488
…ted (#10091) When an AppId is provided the analytics module is not responsible for creating the pinpoint resource. There is a condition named ```ShouldCreatePinpointApp``` to check for this. The auth and unAuth roles had this permission specified, which is unnecessary as the resources within them already have an if which outputs different values based on this condition.
* fix: windows unit test for missing path assertion * fix: lint errors * fix remove extraneous comment * fix flakiness in beta.runtests Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com>
Co-authored-by: John Corser <xss@amazon.com>
…10158) * fix: validate that the app limit has not been reached Validate that the app limit has not been reached by checking the meta file and print a warning it it has been reached Closes #10063 * refactor: change context.print to printer * refactor: change message content * fix: update warning message
…ands (#10288) * (chore) added flow report class * (feat) amplify cli flow journaling * (chore) insert unique project identifier to index logs * (chore) add timestamp to interactions for Dx tracking * feat: walkthrough logging for headless apis * chore: upgrade lodash dependencies * (chore) flow-report headless unit-tests and redactions * chore: fix unit tests broken by flow * chore: remove extraneous debug logs * chore: update unit tests for redactions and interactive flows * chore: remove extraneous lib folder and update gitignore * chore: address-pr-comment: remove input params from no-op functions * chore: PR comments make flowData as member of usageData instead of singleton * chore: PR comment - revert change which made line too long to read * chore: PR comment - remove extraneous calls to pushFlow and remove pushHeadlessFlow from prompter * chore: PR comment - changelog will be added only after the release * chore: fix lgtm bot errors * fix: ignore amplify-cli-shared-interfaces for testing * fix: prevent symlinks on nodejs package install (#10293) * fix auth unit-tests breaking because of headless flow logging * chore: redact hidden inputs * fix : mocking errors in usageData instance Co-authored-by: Sachin Panemangalore <sachinrp@amazon.com> Co-authored-by: John Hockett <jhockett@users.noreply.github.com>
abhi7cr
pushed a commit
that referenced
this pull request
May 6, 2022
* feat(cli-api): improve add and update api * Delete sam.schema.json * Delete cloudformation.schema.json * remove auto apply authmode code from update api workflow * remove unused import * fix lint issues * relative import * fix dependencies * fix lint comments * remove unused code * updated v2 templates * remove unused import * change to use executeProviderUtils * fixed formatting * several minor tweaks to add and update api workflow * update conflict detection label * remove app not deployed message * auto apply auth mode * auto apply authmode for v2 tranformer * add type amplify_global to v2 schemas * Update many-relationship-schema-v2.graphql * Update single-object-auth-schema-v2.graphql * Update single-object-schema-v2.graphql * feat: add @auth (#1) * feat: add @auth base package with Access Control * feat: graphql auth v2 add schemaChanges, iam policy generation, and query/read resolvers * feat: graphql auth v2 add auth on mutation and subscription resolvers * feat(amplify-category-api): add global sandbox mode directive on schema generation (aws-amplify#8074) * feat(amplify-category-api): add global sandbox mode directive on schema generation * test(amplify-e2e-tests): add e2e tests for sandbox mode * test(amplify-category-api): add unit test for generating sandbox mode directive; rm unused method * feat(cli): add sandbox mode warning to amplify status (aws-amplify#8078) * feat(amplify-category-api): prompt api key creation on amplify push (aws-amplify#8124) * feat(amplify-category-api): prompt api key create when invalid with sandbox mode * test(amplify-category-api): add unit tests for provider utils * test(amplify-category-api): fix test for adding api key prompt * refactor(cli): refactor api key prompt * refactor(amplify-category-api): add api key with gql compiled * feat: @model conflict resolution * auth directive support for index, searchable, predictions, functions, and relational directives (aws-amplify#8146) * feat: add support for index and updated unit and e2e tests * feat: directive suport for functions, predictions, searchable, and relational * test: updated unit tests for updated auth on directives * @auth support for datastore and add has auth flag (aws-amplify#8168) * feat: @auth v2 on datastore and updated unit tests * feat: add hasAuthFlag * feat(graphql-model-transformer): set up transformer for sandbox mode directive (aws-amplify#8138) * feat(graphql-model-transformer): add sandbox mode support to model transformer * refactor(graphql-transformer-core): do not persist sandbox mode meta data * fix: add command to show access control and field auth evaluation in access control (aws-amplify#8174) * fix: admin ui app state check and auth transformer index resolver name (aws-amplify#8175) * fix: has auth typo and qref on field conditions for private rule (aws-amplify#8180) * fix(graphql-model-transformer): use hasAuth flag when sandbox mode is disabled (aws-amplify#8179) * fix: update hasMany to use join table name, sync config warning, updated unit test * fix: add empty payload for sandbox mode * fix: snapshot test for @searchable * fix: udpated snapshot for index and relation directives * fix: use same none datasource name as resolver manager * fix: iam resolver check and relational payload (aws-amplify#8234) * fix: add datastore query in config for auth (aws-amplify#8246) * fix: auth filter expression (aws-amplify#8248) * fix: update iam auth to include roles in before template (aws-amplify#8259) * chore: rebase and update auth dependencies * fix(graphql-model-transformer): iam role name does not exceed 64 characters * fix: add base e2e tests with auth fixes Co-authored-by: Danielle Adams <6271256+danielleadams@users.noreply.github.com> Co-authored-by: lazpavel <85319655+lazpavel@users.noreply.github.com> * fix: update dependency versions * feat(amplify-provider-awscloudformation): match env directive field for sandbox mode (#3) * fix(amplify-provider-awscloudformation): invoke api function from invoker plugin (aws-amplify#8274) * fix(amplify-provider-awscloudformation): invoke api function from invoker plugin * fix(graphql-index-transformer): update snapshots for tests * test(amplify-provider-awscloudformation): fix tests for sandbox helpers * fix(amplify-provider-awscloudformation): remove sandbox mode directive from schema before transform (aws-amplify#8272) * chore(graphql-auth-transformer): update deps for auth transformer and api category * fix(graphql-model-transformer): revert code to master version * test(graphql-model-transformer): update the snapshot for the amplify/graphql-model-transformer test * chore: remove showacm as that was for testing purposes only * test(amplify-e2e-tests): update to use correct helpers * test(graphql-transformers-e2e-tests): enable sandbox mode on v2 transforms * test(amplify-e2e-tests): replace updateAPIResolution imports with new methods * fix: get item query for @model and relational directives * auto apply auth fix * auto apply auth modes v2 fix (#4) * test(amplify-e2e-tests): rm sandbox e2e test * fix(amplify-provider-awscloudformation): fix api key creation when sandbox mode enable * test(amplify-e2e-tests): create random app name generator for broken tests * fix api e2e workflow * test(amplify-e2e-core): add random app name generator, update snapshots and imports * chore(graphql-auth-transformer): upgrade deps in auth transformer * update e2e test to use new api workflow (#5) * feat(graphql-model-transformer): fix default value e2e test (#6) * test(amplify-e2e-tests): add missing helper * e2e fix for auth tests using new api workflow (aws-amplify#7) * update e2e test to use new api workflow * fix(test): update auth tests with new api workflow * test(amplify-e2e-tests): add missing helper and fix broken test Co-authored-by: Christopher Sundersingh <sundersc@amazon.com> Co-authored-by: Christopher Sundersingh <83315412+sundersc@users.noreply.github.com> Co-authored-by: Josue Ruiz <7465495+SwaySway@users.noreply.github.com> Co-authored-by: lazpavel <85319655+lazpavel@users.noreply.github.com> Co-authored-by: Colin Ihrig <colihrig@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.